✨ Add timeout after which check is considered inactive

We don't want our firmware checks to stay endlessly active and get
rechecked, usually things should be clear after the first few seconds
of connection to a printer.

In case this changes at some point we can override the timeout for
individual checks or even outright disable it.

Author: foosel

octoprint_firmware_check/__init__.py

@@ -176,6 +176,9 @@ def _run_checks(self, check_type, *args, **kwargs):
 					changes = True
 					break
 
+				check.evaluate_timeout()
+				self._logger.debug("Check {} active? {}".format(check, check.active))
+
 		if changes:
 			self._ping_clients()
 

octoprint_firmware_check/checks/__init__.py

@@ -4,14 +4,19 @@
 __license__ = 'GNU Affero General Public License http://www.gnu.org/licenses/agpl.html'
 __copyright__ = "Copyright (C) 2019 The OctoPrint Project - Released under terms of the AGPLv3 License"
 
+from octoprint.util import monotonic_time
+import logging
 
 class Check(object):
 	name = None
 	url = None
 
+	ACTIVE_TIMEOUT = 30.0
+
 	def __init__(self):
 		self._active = True
 		self._triggered = False
+		self._start_time = None
 
 	def received(self, line):
 		"""Called when receiving a new line from the printer"""
@@ -35,9 +40,20 @@ def triggered(self):
 		"""Whether the check has been triggered"""
 		return self._triggered
 
+	def evaluate_timeout(self):
+		if self._start_time is None:
+			self._start_time = monotonic_time()
+		else:
+			if monotonic_time() > self._start_time + self.ACTIVE_TIMEOUT:
+				# timeout ran out, this is now inactive
+				self._active = False
+				logging.getLogger(__name__).info("Deactivated {} due to timeout after {}s".format(__name__, self.ACTIVE_TIMEOUT))
+
 	def reset(self):
 		self._active = True
 		self._triggered = False
+		self._start_time = None
+
 
 
 class AuthorCheck(Check):