✨ Detect Creality firmware with broken temp reports

Author: foosel

README.md

@@ -41,11 +41,17 @@ and `firmware-broken` for firmware known to have a broken implementation of the
 ### Unsafe firmware
 
 Please refer to the [entry on the "unsafe firmware" warning in OctoPrint's FAQ](https://faq.octoprint.org/warning-firmware-unsafe)
-for a list of currently identified printers.
+for a list of currently known to be affected printers.
 
 ### Broken firmware
 
 #### "CBD" firmware
 
 Please refer to the [entry on the "broken CBD firmware" warning in OctoPrint's FAQ](https://faq.octoprint.org/warning-firmware-broken-cbd)
-for a list of currently identified printers.
+for a list of currently known to be affected printers.
+
+#### Creality firmware with broken temperature reporting
+
+Please refer to the [entry on the this warning in OctoPrint's FAQ](https://faq.octoprint.org/warning-firmware-broken-creality-temp)
+for variants of this and a list of currently known to be affected printers.
+

octoprint_firmware_check/checks/firmware_broken.py

@@ -10,10 +10,10 @@
 class FirmwareBrokenChecks(object):
 	@classmethod
 	def as_dict(cls):
-		return dict(checks=(CbdCheck(), ZwlfCheck()),
+		return dict(checks=(CbdCheck(), ZwlfCheck(), CrealityDoubleTempCheck(), CrealityEqualsTempCheck()),
 		            message=gettext("Your printer's firmware is known to have a broken implementation of the "
-		                            "communication protocol. This will cause print failures. You'll need to "
-		                            "take additional steps for OctoPrint to work with it."),
+		                            "communication protocol. This may cause print failures or other annoyances. "
+		                            "You'll need to take additional steps for OctoPrint to fully work with it."),
 		            severity=Severity.INFO)
 
 
@@ -29,3 +29,30 @@ def _is_match(self, line):
 class ZwlfCheck(CbdCheck):
 	name = "zwlf"
 	FRAGMENT = "ZWLF make it".lower()
+
+
+class CrealityDoubleTempCheck(LineCheck):
+	name = "creality_double_temp"
+	url = "https://faq.octoprint.org/warning-firmware-broken-creality-double-temp"
+
+	def m115(self, name, data):
+		# we cannot stop scanning after an M115 report as we might not yet have seen a temperature report then
+		pass
+
+	def _is_match(self, line):
+		# broken report: TT::27.9327.93 //0.000.00 BB::39.6739.67 //0.000.00 @@::00 BB@@::00
+		return "TT::" in line
+
+	def _is_ruled_out(self, line):
+		# first thing that looks like a proper report stops scanning
+		return ' T:' in line or line.startswith('T:') or ' T0:' in line or line.startswith('T0:') \
+						or ((' B:' in line or line.startswith('B:')) and not 'A:' in line)
+
+
+class CrealityEqualsTempCheck(CrealityDoubleTempCheck):
+	name = "creality_equals_temp"
+	url = "https://faq.octoprint.org/warning-firmware-broken-creality-equals-temp"
+
+	def _is_match(self, line):
+		# broken report: ==T:145.66 /210.00 ==B:60.15 /60.00 @:127 B@:0
+		return "==T:" in line