✨ Support placeholders in messages

Checks can parse/set their content so that the message for a warning
type can be customized a bit.

Author: foosel

octoprint_firmware_check/__init__.py

@@ -223,7 +223,9 @@ def _run_checks(self, check_type, *args, **kwargs):
                     if check.url is not None:
                         url = check.url
 
-                    self._register_warning(warning_type, message, severity, url)
+                    self._register_warning(
+                        warning_type, message.format(**check.placeholders), severity, url
+                    )
 
                     # noinspection PyUnresolvedReferences
                     self._event_bus.fire(

octoprint_firmware_check/checks/__init__.py

@@ -19,6 +19,7 @@ def __init__(self):
         self._active = True
         self._triggered = False
         self._start_time = None
+        self.placeholders = {}
 
     def received(self, line):
         """Called when receiving a new line from the printer"""

octoprint_firmware_check/checks/firmware_development.py

@@ -4,6 +4,9 @@
 __license__ = "GNU Affero General Public License http://www.gnu.org/licenses/agpl.html"
 __copyright__ = "Copyright (C) 2019 The OctoPrint Project - Released under terms of the AGPLv3 License"
 
+import datetime
+import re
+
 from flask_babel import gettext
 
 from . import Check, Severity
@@ -15,8 +18,9 @@ def as_dict(cls):
         return dict(
             checks=(MarlinBugfixCheck(),),
             message=gettext(
-                "Your printer's firmware is a development build. It might be more unstable "
-                "than a release version and should be updated regularly."
+                "Your printer's firmware is a {buildtype} build of {firmware} "
+                "(build date {builddate}). It might be more unstable "
+                "than a release version and should be kept up-to-date."
             ),
             severity=Severity.INFO,
         )
@@ -26,11 +30,36 @@ class MarlinBugfixCheck(Check):
     """
     Marlin bugfix builds.
 
-    Identified by firmware name that contains "Marlin bugfix-"
+    Identified by firmware name that contains "Marlin bugfix-<version> (<builddate>)"
     """
 
     name = "marlin_bugfix"
 
+    pattern = re.compile(
+        r"marlin (?P<version>bugfix-[^-]*)\s\((?P<builddate>.*)\)",
+    )
+
+    def __init__(self):
+        super().__init__()
+        self.placeholders = {
+            "firmware": "Marlin",
+            "version": "unknown",
+            "builddate": "unknown",
+            "buildtype": "development",
+        }
+
     def m115(self, name, data):
-        self._triggered = name and "marlin bugfix-" in name.lower()
+        match = self.pattern.match(name.lower())
+        if match:
+            self.placeholders["version"] = match.group("version")
+            self.placeholders["builddate"] = match.group("builddate")
+
+            try:
+                self.placeholders["builddate"] = datetime.datetime.strptime(
+                    match.group("builddate"), "%b %d %Y %H:%M:%S"
+                ).strftime("%Y%m%d")
+            except Exception:
+                pass
+
+        self._triggered = name and match
         self._active = False