Skip to content

Commit f6534f0

Browse files
authored
Merge pull request #2812 from ORCID/lmendoza/PD-5328
PD-5328, PD-5403
2 parents 9335251 + 97dddc2 commit f6534f0

3 files changed

Lines changed: 56 additions & 18 deletions

File tree

projects/orcid-registry-ui/src/lib/components/auth-challenge/auth-challenge.component.html

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,15 @@ <h1 class="orc-font-heading-small text-center font-normal" i18n>
2525
>and</ng-container
2626
>&nbsp;}@if (showTwoFactorField) {<ng-container i18n
2727
>a two-factor authentication code</ng-container
28-
>&nbsp;}to&nbsp;{{ actionDescription }}@if (boldText) {&nbsp;<b>{{
29-
boldText
30-
}}</b
28+
>&nbsp;}<ng-container
29+
i18n="
30+
auth challenge action clause|Clause in the verification sentence before
31+
a dynamic action fragment. actionDescription is a translated verb phrase
32+
like 'disable 2FA', 'unlink the alternate sign in account', or 'complete
33+
your password reset'. Keep the sentence natural in your
34+
language.@@authChallenge.toActionDescription"
35+
>to {{ actionDescription }}</ng-container
36+
>@if (boldText) {&nbsp;<b>{{ boldText }}</b
3137
>}@if (trailingText) {&nbsp;{{ trailingText }}}
3238
</p>
3339

src/app/layout/language/language.component.html

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,24 +14,19 @@
1414
#languageMenu="matMenu"
1515
id="cy-language-menu"
1616
[attr.aria-label]="labelLanguage"
17+
class="orcid-language-menu-panel"
1718
>
18-
<div
19+
<button
1920
*ngFor="let language of languageMenuOptions | keyvalue"
2021
(click)="changeLanguage(language.key)"
2122
mat-menu-item
22-
[ngClass]="{ 'orcid-mat-menu-item-active': language.key === locale }"
23-
class="orcid-menu-item-small"
23+
[attr.aria-label]="language.value"
24+
[ngClass]="{ 'orcid-language-menu-item-selected': language.key === locale }"
25+
class="orcid-language-menu-item"
2426
>
25-
<button
26-
mat-menu-item
27-
[ngClass]="{ 'orcid-mat-menu-item-active': language.key === locale }"
28-
class="orcid-menu-item-small"
29-
[attr.aria-label]="language.value"
30-
>
31-
<div class="row middle space-between">
32-
{{ language.value }}
33-
<mat-icon *ngIf="language.key === locale">check</mat-icon>
34-
</div>
35-
</button>
36-
</div>
27+
<div class="row middle space-between">
28+
{{ language.value }}
29+
<mat-icon *ngIf="language.key === locale">check</mat-icon>
30+
</div>
31+
</button>
3732
</mat-menu>

src/assets/scss/material.orcid.overwrites.scss/menu.scss

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,43 @@
1515
}
1616
}
1717

18+
.mat-mdc-menu-panel.orcid-language-menu-panel {
19+
.mat-mdc-menu-content:not(:empty) {
20+
padding: 0;
21+
}
22+
23+
.mat-mdc-menu-item.orcid-language-menu-item {
24+
min-height: 56px;
25+
line-height: 56px;
26+
padding: 0 16px;
27+
min-width: 160px;
28+
letter-spacing: 0.25px;
29+
}
30+
31+
.mat-mdc-menu-item.orcid-language-menu-item
32+
.mat-mdc-menu-item-text
33+
.row.space-between {
34+
width: 100%;
35+
}
36+
37+
.mat-mdc-menu-item.orcid-language-menu-item .mat-icon {
38+
margin: 0;
39+
height: auto;
40+
width: auto;
41+
}
42+
43+
.mat-mdc-menu-item.orcid-language-menu-item.orcid-language-menu-item-selected {
44+
background-color: $ui-background-light;
45+
}
46+
47+
.mat-mdc-menu-item.orcid-language-menu-item.cdk-focused,
48+
.mat-mdc-menu-item.orcid-language-menu-item.cdk-program-focused,
49+
.mat-mdc-menu-item.orcid-language-menu-item.cdk-keyboard-focused {
50+
background-color: rgba(16, 152, 255, 0.05);
51+
box-shadow: inset 0 0 0 2px #1098ff;
52+
}
53+
}
54+
1855
.mat-mdc-menu-panel.trusted-individuals {
1956
width: auto;
2057
max-width: initial;

0 commit comments

Comments
 (0)