Skip to content

Commit 22a4662

Browse files
authored
Merge pull request #2817 from ORCID/lmendoza/PD-5445
PD-5445
2 parents c8bedc4 + 40e0a46 commit 22a4662

3 files changed

Lines changed: 5 additions & 12 deletions

File tree

projects/orcid-registry-ui/src/lib/components/auth-challenge/auth-challenge.component.html

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,7 @@ <h1 class="orc-font-heading-small text-center font-normal" i18n>
2525
>and</ng-container
2626
>&nbsp;}@if (showTwoFactorField) {<ng-container i18n
2727
>a two-factor authentication code</ng-container
28-
>&nbsp;}<ng-container
29-
i18n="
30-
auth challenge action clause|Clause in the verification sentence before
31-
a dynamic action fragment. actionDescription is a translated verb phrase
32-
like 'disable 2FA', 'unlink the alternate sign in account', or 'complete
33-
your password reset'. Keep the sentence natural in your
34-
language.@@authChallenge.toActionDescription"
35-
>to {{ actionDescription }}</ng-container
28+
>&nbsp;}<ng-container>{{ actionDescription }}</ng-container
3629
>@if (boldText) {&nbsp;<b>{{ boldText }}</b
3730
>}@if (trailingText) {&nbsp;{{ trailingText }}}
3831
</p>

projects/orcid-ui-docs/src/app/pages/orcid-registry-ui/auth-challenge-page.component.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ <h4>2A. Usage via MatDialog</h4>
9393
&#123;
9494
data: &#123;
9595
parentForm: this.form,
96-
actionDescription: 'unlink the alternate sign in account',
96+
actionDescription: 'to unlink the alternate sign in account',
9797
boldText: 'Google',
9898
trailingText: 'to continue.',
9999
showTwoFactorField: this.twoFactorState, // true or false
@@ -139,7 +139,7 @@ <h4>2B. Usage via CdkPortalOutlet</h4>
139139

140140
// Bind inputs directly to the instance
141141
componentRef.instance.parentForm = this.form;
142-
componentRef.instance.actionDescription = 'complete your password reset';
142+
componentRef.instance.actionDescription = 'to complete your password reset';
143143
componentRef.instance.showPasswordField = false;
144144

145145
componentRef.instance.submitAttempt.subscribe(() => &#123;
@@ -214,7 +214,7 @@ <h4>4. Backend Implementation</h4>
214214
<li>
215215
<code style="font-weight: bold">actionDescription</code>:
216216
<code>string</code>. The contextual text for what the user is doing
217-
(e.g. <code>'unlink the alternate sign in account'</code>).
217+
(e.g. <code>'to unlink the alternate sign in account'</code>).
218218
</li>
219219
<li>
220220
<code style="font-weight: bold">boldText</code>: <code>string</code>.

projects/orcid-ui-docs/src/app/pages/orcid-registry-ui/auth-challenge-page.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ import { takeUntil } from 'rxjs/operators'
4040
export class AuthChallengePageComponent implements OnInit {
4141
showPasswordField = true
4242
showTwoFactorField = true
43-
actionDescription = 'perform this action on'
43+
actionDescription = 'to perform this action on'
4444
boldText = 'Example Account'
4545
trailingText = 'to continue.'
4646
form: UntypedFormGroup

0 commit comments

Comments
 (0)