Remove undocumented cruft from dev phase, add missing method support

Also switch Installation->name to method

Author: Krzysztof Chrapka

doc/examples/app.php

@@ -11,7 +11,7 @@
 
 $request = Request::createFromGlobals();
 $requestedInstallation = $request->server->get('SYMFONY_INSTALLATION'); // might be set by http server based on domain
-$installation = new Installation($requestedInstallation, Installation::TYPE_PROD);
+$installation = new Installation($requestedInstallation);
 $kernel = new AppKernel($installation, 'live', false);
 
 $response = $kernel->handle($request);

doc/examples/console.php

@@ -11,7 +11,7 @@
 $env = $input->getParameterOption(['--env', '-e'], getenv('SYMFONY_ENV') ?: 'dev');
 $requestedInstallation = $input->getParameterOption(['--installation']);
 
-$installation = new Installation($requestedInstallation, Installation::TYPE_PROD);
+$installation = new Installation($requestedInstallation);
 $kernel = new AppKernel($installation, $env);
 $application = new Application($kernel);
 $application->run($input);

src/Kernel/Installation.php

@@ -2,35 +2,26 @@
 
 namespace OJezu\DynamicParameterBundle\Kernel;
 
-use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
-
 class Installation
 {
-    const TYPE_PROD = 'prod';
-    const TYPE_NEXT = 'next';
-
-    const TYPES = [
-        self::TYPE_PROD,
-        self::TYPE_NEXT,
-    ];
+    /**
+     * @var string
+     */
+    private $name;
 
-    public function __construct($name, $type)
+    /**
+     * @param $name
+     */
+    public function __construct($name)
     {
-        if (!in_array($type, self::TYPES)) {
-            throw new InvalidConfigurationException('Unknown installation type: '.$type);
-        }
-
         $this->name = $name;
-        $this->type = $type;
     }
 
     /**
-     * @var string
+     * @return string
      */
-    public $name;
-
-    /**
-     * @var string
-     */
-    public $type;
+    public function name()
+    {
+        return $this->name;
+    }
 }

src/Service/DynamicParameterEnvVarProcessor.php

@@ -32,8 +32,11 @@ class DynamicParameterEnvVarProcessor implements EnvVarProcessorInterface
      * @param array $parameterMap
      * @param bool $loadConfiguration
      */
-    public function __construct(ParameterProviderInterface $parameterProvider, array $parameterMap, $loadConfiguration = true)
-    {
+    public function __construct(
+        ParameterProviderInterface $parameterProvider,
+        array $parameterMap,
+        $loadConfiguration = true
+    ) {
         $this->parameterProvider = $parameterProvider;
         $this->parameterMap = $parameterMap;
         $this->cache = [];

src/Service/InstallationEnvVarProcessor.php

@@ -35,11 +35,21 @@ public function __construct(Installation $installation)
      */
     public function getEnv($prefix, $name, \Closure $getEnv)
     {
-        if (!property_exists($this->installation, $name)) {
-            throw new InvalidArgumentException(sprintf('Installation object does not have »%s« property', $name));
+        $result = null;
+
+        if (is_callable([$this->installation, $name])) {
+            $result = $this->installation->{$name}();
+        } elseif (property_exists($this->installation, $name)) {
+            //TODO: reflection maybe?
+            $result = $this->installation->$name;
+        } else {
+            throw new InvalidArgumentException(sprintf(
+                'Installation object does not have »%s« property or method',
+                $name
+            ));
         }
 
-        return $this->installation->$name;
+        return $result;
     }
 
     /**