Skip to content

Commit 04f1650

Browse files
Finalizing externalizing Vocabulary Search Apache Solr implementation (#2308)
Referring common Vocabulary Search classes from Standardized Analysis API (org.ohdsi:standardized-analysis-specs:1.5.0) Adding webapi-solr profile and referencing a new webapi-solr repository (org.ohdsi:webapi-solr:1.0.0) Finalizing externalizing the Vocabulary Search Apache Solr implementation ===================================== Additionally fixing a failing unit test CohortResultsServiceTest.prepareGetTimeToEventDrilldown
1 parent 90cc866 commit 04f1650

21 files changed

Lines changed: 55 additions & 366 deletions

pom.xml

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,6 @@
6666
<cdm.version>5</cdm.version>
6767
<!-- Person properties -->
6868
<person.viewDates>false</person.viewDates>
69-
<!-- Full Text Search With SOLR Settings -->
70-
<solr.endpoint></solr.endpoint>
71-
<solr.query.prefix>{!complexphrase inOrder=true}</solr.query.prefix>
72-
<solr.version>8.11.2</solr.version>
7369
<!-- Heracles properties -->
7470
<heracles.smallcellcount>5</heracles.smallcellcount>
7571

@@ -1131,7 +1127,7 @@
11311127
<dependency>
11321128
<groupId>org.ohdsi</groupId>
11331129
<artifactId>standardized-analysis-specs</artifactId>
1134-
<version>1.4.0</version>
1130+
<version>1.5.0</version>
11351131
<exclusions>
11361132
<exclusion>
11371133
<groupId>com.fasterxml.jackson.core</groupId>
@@ -1197,12 +1193,6 @@
11971193
</exclusion>
11981194
</exclusions>
11991195
</dependency>
1200-
<dependency>
1201-
<groupId>org.apache.solr</groupId>
1202-
<artifactId>solr-solrj</artifactId>
1203-
<version>${solr.version}</version>
1204-
<type>jar</type>
1205-
</dependency>
12061196
<dependency>
12071197
<groupId>com.qmino</groupId>
12081198
<artifactId>miredot-annotations</artifactId>
@@ -1851,5 +1841,27 @@
18511841
</dependency>
18521842
</dependencies>
18531843
</profile>
1844+
<profile>
1845+
<id>webapi-solr</id>
1846+
<properties>
1847+
<!-- Full Text Search With SOLR Settings -->
1848+
<solr.endpoint></solr.endpoint>
1849+
<solr.query.prefix>{!complexphrase inOrder=true}</solr.query.prefix>
1850+
<solr.version>8.11.2</solr.version>
1851+
</properties>
1852+
<dependencies>
1853+
<dependency>
1854+
<groupId>org.ohdsi</groupId>
1855+
<artifactId>webapi-solr</artifactId>
1856+
<version>1.0.0</version>
1857+
</dependency>
1858+
<dependency>
1859+
<groupId>org.apache.solr</groupId>
1860+
<artifactId>solr-solrj</artifactId>
1861+
<version>${solr.version}</version>
1862+
<type>jar</type>
1863+
</dependency>
1864+
</dependencies>
1865+
</profile>
18541866
</profiles>
18551867
</project>

src/main/java/org/ohdsi/webapi/cohortanalysis/HeraclesConfigurationInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.ohdsi.webapi.cohortanalysis;
22

3-
import org.ohdsi.webapi.info.ConfigurationInfo;
3+
import org.ohdsi.info.ConfigurationInfo;
44
import org.springframework.beans.factory.annotation.Value;
55
import org.springframework.stereotype.Component;
66

src/main/java/org/ohdsi/webapi/conceptset/ConceptSetExport.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,11 @@
66
package org.ohdsi.webapi.conceptset;
77

88
import com.fasterxml.jackson.annotation.JsonProperty;
9+
910
import java.util.Collection;
11+
1012
import org.ohdsi.circe.vocabulary.ConceptSetExpression;
11-
import org.ohdsi.webapi.vocabulary.Concept;
13+
import org.ohdsi.vocabulary.Concept;
1214

1315
/**
1416
*

src/main/java/org/ohdsi/webapi/info/ConfigurationInfo.java

Lines changed: 0 additions & 16 deletions
This file was deleted.

src/main/java/org/ohdsi/webapi/info/InfoService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import javax.ws.rs.core.MediaType;
2525

2626
import org.apache.commons.lang3.StringUtils;
27-
import org.ohdsi.webapi.info.ConfigurationInfo;
27+
import org.ohdsi.info.ConfigurationInfo;
2828
import org.springframework.boot.info.BuildProperties;
2929
import org.springframework.stereotype.Controller;
3030

src/main/java/org/ohdsi/webapi/person/PersonConfigurationInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.ohdsi.webapi.person;
22

3-
import org.ohdsi.webapi.info.ConfigurationInfo;
3+
import org.ohdsi.info.ConfigurationInfo;
44
import org.springframework.beans.factory.annotation.Value;
55
import org.springframework.stereotype.Component;
66

src/main/java/org/ohdsi/webapi/plugins/PluginsConfigurationInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.ohdsi.webapi.plugins;
22

3-
import org.ohdsi.webapi.info.ConfigurationInfo;
3+
import org.ohdsi.info.ConfigurationInfo;
44
import org.springframework.beans.factory.annotation.Value;
55
import org.springframework.stereotype.Component;
66

src/main/java/org/ohdsi/webapi/security/SecurityConfigurationInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
package org.ohdsi.webapi.security;
22

3+
import org.ohdsi.info.ConfigurationInfo;
34
import org.ohdsi.webapi.Constants;
45
import org.ohdsi.webapi.shiro.management.AtlasRegularSecurity;
56
import org.ohdsi.webapi.shiro.management.Security;
6-
import org.ohdsi.webapi.info.ConfigurationInfo;
77
import org.springframework.beans.factory.annotation.Value;
88
import org.springframework.stereotype.Component;
99

src/main/java/org/ohdsi/webapi/service/ConceptSetService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,15 @@
1919
import java.util.*;
2020
import java.util.stream.Collectors;
2121
import java.util.stream.StreamSupport;
22+
2223
import javax.transaction.Transactional;
2324
import javax.ws.rs.*;
2425
import javax.ws.rs.core.MediaType;
2526
import javax.ws.rs.core.Response;
2627

2728
import org.apache.shiro.authz.UnauthorizedException;
2829
import org.ohdsi.circe.vocabulary.ConceptSetExpression;
30+
import org.ohdsi.vocabulary.Concept;
2931
import org.ohdsi.webapi.check.CheckResult;
3032
import org.ohdsi.webapi.check.checker.conceptset.ConceptSetChecker;
3133
import org.ohdsi.webapi.conceptset.ConceptSet;
@@ -56,7 +58,6 @@
5658
import org.ohdsi.webapi.versioning.dto.VersionDTO;
5759
import org.ohdsi.webapi.versioning.dto.VersionUpdateDTO;
5860
import org.ohdsi.webapi.versioning.service.VersionService;
59-
import org.ohdsi.webapi.vocabulary.Concept;
6061
import org.springframework.beans.factory.annotation.Autowired;
6162
import org.springframework.beans.factory.annotation.Value;
6263
import org.springframework.core.convert.support.GenericConversionService;

src/main/java/org/ohdsi/webapi/service/VocabularyService.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@
22

33
import static org.ohdsi.webapi.service.cscompare.ConceptSetCompareService.CONCEPT_SET_COMPARISON_ROW_MAPPER;
44
import static org.ohdsi.webapi.util.SecurityUtils.whitelist;
5+
56
import com.google.common.collect.Lists;
67
import com.google.common.collect.Maps;
8+
79
import java.sql.ResultSet;
810
import java.sql.SQLException;
911
import java.util.*;
@@ -34,6 +36,8 @@
3436
import org.ohdsi.circe.vocabulary.ConceptSetExpressionQueryBuilder;
3537
import org.ohdsi.sql.SqlRender;
3638
import org.ohdsi.sql.SqlTranslate;
39+
import org.ohdsi.vocabulary.Concept;
40+
import org.ohdsi.vocabulary.SearchProviderConfig;
3741
import org.ohdsi.webapi.activity.Activity.ActivityType;
3842
import org.ohdsi.webapi.activity.Tracker;
3943
import org.ohdsi.webapi.conceptset.ConceptSetComparison;
@@ -49,7 +53,6 @@
4953
import org.ohdsi.webapi.source.SourceInfo;
5054
import org.ohdsi.webapi.util.PreparedSqlRender;
5155
import org.ohdsi.webapi.util.PreparedStatementRenderer;
52-
import org.ohdsi.webapi.vocabulary.Concept;
5356
import org.ohdsi.webapi.vocabulary.ConceptRecommendedNotInstalledException;
5457
import org.ohdsi.webapi.vocabulary.ConceptRelationship;
5558
import org.ohdsi.webapi.vocabulary.ConceptSearch;
@@ -58,7 +61,6 @@
5861
import org.ohdsi.webapi.vocabulary.RecommendedConcept;
5962
import org.ohdsi.webapi.vocabulary.RelatedConcept;
6063
import org.ohdsi.webapi.vocabulary.RelatedConceptSearch;
61-
import org.ohdsi.webapi.vocabulary.SearchProviderConfig;
6264
import org.ohdsi.webapi.vocabulary.Vocabulary;
6365
import org.ohdsi.webapi.vocabulary.VocabularyInfo;
6466
import org.ohdsi.webapi.vocabulary.VocabularySearchService;

0 commit comments

Comments
 (0)