Skip to content

Commit 1ce6c37

Browse files
author
sreeder
committed
add condition to getDatasetREsults function
1 parent 2a22676 commit 1ce6c37

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

Examples/Sample.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#connect to database
1818
# createconnection (dbtype, servername, dbname, username, password)
1919
# session_factory = dbconnection.createConnection('connection type: sqlite|mysql|mssql|postgresql', '/your/path/to/db/goes/here', 2.0)#sqlite
20-
session_factory = dbconnection.createConnection('postgresql', 'localhost', 'odm2', 'ODM', 'odm')
20+
# session_factory = dbconnection.createConnection('postgresql', 'localhost', 'odm2', 'ODM', 'odm')
2121
# session_factory = dbconnection.createConnection('mysql', 'localhost', 'odm2', 'ODM', 'odm')#mysql
2222

2323
# session_factory= dbconnection.createConnection('mssql', "(local)", "ODM2", "ODM", "odm")#win MSSQL
@@ -27,6 +27,13 @@
2727
# session_factory = dbconnection.createConnection('sqlite', '/Users/stephanie/DEV/YODA-Tools/tests/test_files/XL_specimen.sqlite', 2.0)
2828

2929

30+
session_factory = dbconnection.createConnection('postgresql', 'odm2wofpy1.uwrl.usu.edu', 'odm2', 'dbadmin', 'pinkbananastastegross')
31+
32+
33+
34+
35+
36+
3037

3138

3239

odm2api/ODM2/services/readService.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -732,6 +732,7 @@ def getDataSetsResults(self, ids= None, codes=None, uuids=None, dstype=None):
732732
Retrieve a detailed list of Datasets along with detailed metadata about the datasets
733733
and the results contained within them
734734
735+
**Must specify either DataSetID OR DataSetUUID OR DataSetCode)**
735736
Args:
736737
ids (list, optional): List of DataSetsIDs.
737738
codes (list, optional): List of DataSet Codes.
@@ -752,6 +753,11 @@ def getDataSetsResults(self, ids= None, codes=None, uuids=None, dstype=None):
752753
>>> READ.getDataSetsResults(dstype='singleTimeSeries')
753754
754755
"""
756+
757+
# make sure one of the three arguments has been sent in
758+
if all(v is None for v in [ids, codes, uuids]):
759+
raise ValueError('Expected DataSetID OR DataSetUUID OR DataSetCode argument')
760+
755761
q = self._session.query(DataSetsResults)\
756762
.join(DataSets)
757763
if ids:

0 commit comments

Comments
 (0)