review(addon): type-validate :MISSION:SAVED: payload and defer final diary

Author: fank

addons/extension/fnc_initSession.sqf

@@ -160,9 +160,26 @@ addMissionEventHandler ["ExtensionCallback", {
     //   ["ok", path]
     //   ["partial", path, error]
     //   ["error", error]
-    private _status = _data param [0, ""];
-    private _detail = _data param [1, ""];
-    private _extra  = _data param [2, ""];
+    // Type-check each field: if the extension ever sends something
+    // unexpected, fall back to an empty string rather than crashing
+    // the callback handler with a type error in the switch below.
+    private _status = _data param [0, "", [""]];
+    private _detail = _data param [1, "", [""]];
+    private _extra  = _data param [2, "", [""]];
+
+    // finalDiary appends a final status entry to the OCAPInfo diary
+    // subject so the interim "being saved" record from fnc_exportData.sqf
+    // is followed by the authoritative outcome.
+    private _finalDiary = {
+      params ["_diaryHtml"];
+      [[_diaryHtml], {
+        params ["_html"];
+        player createDiaryRecord [
+          "OCAPInfo",
+          ["Status", _html]
+        ];
+      }] remoteExec ["call", [0, -2] select isDedicated, true];
+    };
 
     switch (_status) do {
       case "ok": {
@@ -173,6 +190,10 @@ addMissionEventHandler ["ExtensionCallback", {
           2,
           [0, 0.8, 0, 1]
         ] remoteExec ["CBA_fnc_notify", [0, -2] select isDedicated];
+        [format[
+          "<font color='#33FF33'>OCAP capture of %1 has been exported and uploaded successfully.</font>",
+          briefingName
+        ]] call _finalDiary;
       };
       case "partial": {
         WARNING_2("Mission save complete but upload failed — path: %1 error: %2",_detail,_extra);
@@ -182,6 +203,10 @@ addMissionEventHandler ["ExtensionCallback", {
           2,
           [1, 0.8, 0, 1]
         ] remoteExec ["CBA_fnc_notify", [0, -2] select isDedicated];
+        [format[
+          "<font color='#FFCC00'>OCAP capture of %1 was saved locally to %2, but the upload to the web server failed:</font><br/>%3",
+          briefingName, _detail, _extra
+        ]] call _finalDiary;
       };
       case "error": {
         ERROR_MSG_1("Mission save failed: %1",_detail);
@@ -191,6 +216,10 @@ addMissionEventHandler ["ExtensionCallback", {
           2,
           [1, 0, 0, 1]
         ] remoteExec ["CBA_fnc_notify", [0, -2] select isDedicated];
+        [format[
+          "<font color='#FF3333'>OCAP save of %1 failed:</font><br/>%2",
+          briefingName, _detail
+        ]] call _finalDiary;
       };
       default {
         WARNING_1("Unknown :MISSION:SAVED: status: %1",_status);

addons/recorder/fnc_exportData.sqf

@@ -134,6 +134,9 @@ OCAPEXTLOG(ARR4("Queued recording of mission",GVAR(missionName),"with tag",_save
 
 // Interim "saving..." toast; the final result comes from :MISSION:SAVED:
 [format["OCAP saving %1 (%2 frames) — upload will follow", briefingName, _endFrameNumber], 1, [1, 1, 1, 1]] remoteExec ["CBA_fnc_notify", [0, -2] select isDedicated];
+// Interim diary record. The final "exported successfully" / "upload failed"
+// record is appended from the :MISSION:SAVED: ExtensionCallback handler in
+// fnc_initSession.sqf once the async save completes.
 [[GVAR(missionName), GVAR(captureFrameNo)], {
   params ["_missionName", "_endFrame"];
 
@@ -146,7 +149,7 @@ OCAPEXTLOG(ARR4("Queued recording of mission",GVAR(missionName),"with tag",_save
     [
       "Status",
       format[
-        "<font color='#33FF33'>OCAP capture of %1 has been exported with %2 frames saved.</font><br/><br/>Upload results have been logged.",
+        "<font color='#FFFF33'>OCAP capture of %1 with %2 frames is being saved and uploaded.</font><br/><br/>Final status will be reported when the upload completes.",
         _missionName,
         _endFrame
       ]