fix: vehicle class exclusion broken when kindOf list is empty (#81)

* fix: vehicle class exclusion check failing when kindOf exclusion list is empty

The `_vic` variable (reference to the vehicle being checked) was declared
inside the `excludeKindFromRecord` conditional block. When that setting
was empty, the block never executed, leaving `_vic` undefined. The
subsequent `excludeClassFromRecord` check silently failed because
`typeOf nil` returns "" which never matches any class name.

This caused ACE_friesAnchorBar entities (and any other class-excluded
vehicles) to be recorded despite being in the exclusion list, resulting
in phantom black helicopter icons overlapping real helicopters in
playback.

Also sync the excludeClassFromRecord default value to include
WeaponHolderSimulated as the setting description already documents.

* perf: cache parseSimpleArray results for exclude checks

Avoid calling parseSimpleArray twice per setting (once for the emptiness
check, once for forEach) on every vehicle every frame.

Author: fank

addons/recorder/XEH_preInit.sqf

@@ -149,7 +149,7 @@ GVAR(allSettings) = [
       "Array of object classnames that should be excluded from recording. Use single quotes! Default: ['ACE_friesAnchorBar', 'WeaponHolderSimulated']"
     ],
     [COMPONENT_NAME, "Exclusions"], // Pretty name of the category where the setting can be found. Can be stringtable entry.
-    "['ACE_friesAnchorBar']", // default string value
+    "['ACE_friesAnchorBar','WeaponHolderSimulated']", // default string value
     true, // "_isGlobal" flag. Set this to true to always have this setting synchronized between all clients in multiplayer
     {}, // function that will be executed once on mission start and every time the setting is changed.
     false // requires restart to apply

addons/recorder/fnc_captureLoop.sqf

@@ -180,22 +180,24 @@ GVAR(PFHObject) = [
       if !(_x getVariable [QGVARMAIN(isInitialized), false]) then {
         _vehType = typeOf _x;
         _class = _vehType call FUNC(getClass);
+        private _vic = _x;
         private _toExcludeKind = false;
-        if (parseSimpleArray EGVAR(settings,excludeKindFromRecord) isNotEqualTo []) then {
-          private _vic = _x;
+        private _kindList = parseSimpleArray EGVAR(settings,excludeKindFromRecord);
+        if (_kindList isNotEqualTo []) then {
           {
             if (_vic isKindOf _x) exitWith {
               _toExcludeKind = true;
             };
-          } forEach (parseSimpleArray EGVAR(settings,excludeKindFromRecord));
+          } forEach _kindList;
         };
         private _toExcludeClass = false;
-        if (parseSimpleArray EGVAR(settings,excludeClassFromRecord) isNotEqualTo []) then {
+        private _classList = parseSimpleArray EGVAR(settings,excludeClassFromRecord);
+        if (_classList isNotEqualTo []) then {
           {
             if (typeOf _vic == _x) exitWith {
               _toExcludeClass = true;
             };
-          } forEach (parseSimpleArray EGVAR(settings,excludeClassFromRecord));
+          } forEach _classList;
         };
         if ((_class isEqualTo "unknown") || _toExcludeKind || _toExcludeClass) exitWith {
           LOG(ARR2("WARNING: vehicle is defined as 'unknown' or exclude:",_vehType));