refactor(state): remove DB writes from the new state to make writes atomic (#3360)

* squash

fix unit tests

cleanups

renames

unit tests

interface modifications

linter

linter

linter

* linter

* linter

* chore: remove last staticcheck, organise mocks

* squash

cleanups

Integrate common interfaces into rawdb

fixes after rebase

minor linter changes

clean-up blockchain.go, fix linter

minor cleanups

clean cache

fix unit tests

fixes after rebase

* squash

cleanups

Integrate common interfaces into rawdb

fixes after rebase

minor linter changes

clean-up blockchain.go, fix linter

minor cleanups

state atomicity

remove node ordering

fixes after rebase

* changes to the atomicity

* code style

* unit tests

* fix: minor fixes after rebase

* chore: address first batch of comments on the PR

* chore: fixes after rebase

* chore: remove empty state constructor

* chore: address the PR comments, use new felt constructors

* test: fix unit tests

* fix(core/state): compilation errors

* chore: address PR comments, fix unit tests

* test: improve code coverage

* chore: linter

* test: increase codecov

* chore: clean up unnecessary noise

---------

Co-authored-by: Rodrigo <rodrodpino@gmail.com>

Author: MaksymMalicki

core/state/cache.go

@@ -16,14 +16,12 @@ const (
 )
 
 type StateDB struct {
-	disk       db.KeyValueStore
-	triedb     database.TrieDB
-	stateCache *stateCache
+	disk   db.KeyValueStore
+	triedb database.TrieDB
 }
 
 func NewStateDB(disk db.KeyValueStore, triedb database.TrieDB) *StateDB {
-	stateCache := newStateCache()
-	return &StateDB{disk: disk, triedb: triedb, stateCache: &stateCache}
+	return &StateDB{disk: disk, triedb: triedb}
 }
 
 // Opens a class trie for the given state root

core/state/cache_test.go

@@ -15,7 +15,7 @@ type stateHistory struct {
 }
 
 func NewStateHistory(blockNum uint64, stateRoot *felt.Felt, db *StateDB) (stateHistory, error) {
-	state, err := New(stateRoot, db)
+	state, err := NewStateReader(stateRoot, db)
 	if err != nil {
 		return stateHistory{}, err
 	}

core/state/database.go

@@ -143,9 +143,11 @@ func TestStateHistoryClassOperations(t *testing.T) {
 		NewRoot:   &felt.Zero,
 		StateDiff: &core.StateDiff{},
 	}
-	state, err := New(&felt.Zero, stateDB)
+	batch := stateDB.disk.NewBatch()
+	state, err := New(&felt.Zero, stateDB, batch)
 	require.NoError(t, err)
 	err = state.Update(&core.Header{Number: 0}, stateUpdate, classes, false)
+	require.NoError(t, batch.Write())
 	require.NoError(t, err)
 	stateComm, err := state.Commitment("")
 	require.NoError(t, err)
@@ -159,10 +161,12 @@ func TestStateHistoryClassOperations(t *testing.T) {
 		class2Hash: class2,
 	}
 
-	state, err = New(&stateComm, stateDB)
+	batch = stateDB.disk.NewBatch()
+	state, err = New(&stateComm, stateDB, batch)
 	require.NoError(t, err)
 	err = state.Update(&core.Header{Number: 1}, stateUpdate, classes2, false)
 	require.NoError(t, err)
+	require.NoError(t, batch.Write())
 
 	historyBlock0, err := NewStateHistory(0, &felt.Zero, stateDB)
 	require.NoError(t, err)
@@ -225,7 +229,8 @@ func TestStateHistoryContractStorageLastUpdatedBlock(t *testing.T) {
 	value := felt.NewFromUint64[felt.Felt](99)
 
 	stateDB := newTestStateDB()
-	state, err := New(&felt.Zero, stateDB)
+	batch := stateDB.disk.NewBatch()
+	state, err := New(&felt.Zero, stateDB, batch)
 	require.NoError(t, err)
 
 	su0 := &core.StateUpdate{
@@ -239,11 +244,13 @@ func TestStateHistoryContractStorageLastUpdatedBlock(t *testing.T) {
 	}
 	firstChangeBlock := uint64(0)
 	require.NoError(t, state.Update(&core.Header{Number: firstChangeBlock}, su0, nil, true))
+	require.NoError(t, batch.Write())
 
 	root0, err := state.Commitment("")
 	require.NoError(t, err)
 
-	state, err = New(&root0, stateDB)
+	batch = stateDB.disk.NewBatch()
+	state, err = New(&root0, stateDB, batch)
 	require.NoError(t, err)
 
 	su3 := &core.StateUpdate{
@@ -257,6 +264,7 @@ func TestStateHistoryContractStorageLastUpdatedBlock(t *testing.T) {
 	}
 	secondChangeBlock := uint64(3)
 	require.NoError(t, state.Update(&core.Header{Number: secondChangeBlock}, su3, nil, true))
+	require.NoError(t, batch.Write())
 
 	t.Run("returns most recent update before history block", func(t *testing.T) {
 		history, err := NewStateHistory(2, &felt.Zero, stateDB)