Dev (#232)

* Remove extra 'class MovieSerializer' from an example in the README

* Fix serialization for nested nil includes with block

Author: shishirmk

README.md

@@ -284,7 +284,6 @@ block you opt-in to using params by adding it as a block parameter.
 
 ```ruby
 class MovieSerializer
-  class MovieSerializer
   include FastJsonapi::ObjectSerializer
 
   attributes :name, :year

lib/fast_jsonapi/serialization_core.rb

@@ -182,7 +182,7 @@ def fetch_id(record, relationship, params)
           object = relationship[:object_block].call(record, params)
 
           return object.map(&:id) if object.respond_to? :map
-          return object.id
+          return object.try(:id)
         end
 
         record.public_send(relationship[:id_method_name])

spec/lib/object_serializer_spec.rb

@@ -97,6 +97,13 @@
       expect(serializable_hash['data']['relationships']['owner']['data']).to be nil
     end
 
+    it 'returns correct json when belongs_to returns nil and there is a block for the relationship' do
+      movie.owner_id = nil
+      json = MovieSerializer.new(movie, {include: [:owner]}).serialized_json
+      serializable_hash = JSON.parse(json)
+      expect(serializable_hash['data']['relationships']['owner']['data']).to be nil
+    end
+
     it 'returns correct json when has_one returns nil' do
       supplier.account_id = nil
       json = SupplierSerializer.new(supplier).serialized_json

spec/shared/contexts/movie_context.rb

@@ -43,6 +43,13 @@ def advertising_campaign
         ac
       end
 
+      def owner
+        return unless owner_id
+        ow = Owner.new
+        ow.id = owner_id
+        ow
+      end
+
       def cache_key
         "#{id}"
       end
@@ -146,14 +153,24 @@ class Account
       attr_accessor :id
     end
 
+    class Owner
+      attr_accessor :id
+    end
+
+    class OwnerSerializer
+      include FastJsonapi::ObjectSerializer
+    end
+
     # serializers
     class MovieSerializer
       include FastJsonapi::ObjectSerializer
       set_type :movie
       # director attr is not mentioned intentionally
       attributes :name, :release_year
       has_many :actors
-      belongs_to :owner, record_type: :user
+      belongs_to :owner, record_type: :user do |object, params|
+        object.owner
+      end
       belongs_to :movie_type
       has_one :advertising_campaign
     end