Skip to content

Commit f1a7261

Browse files
committed
enable v8 inspector in application template
sync fixes btw test-app and template
1 parent c16a1d6 commit f1a7261

3 files changed

Lines changed: 19 additions & 0 deletions

File tree

build-artifacts/project-template-gradle/src/main/java/com/tns/AndroidJsDebugger.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626

2727
public class AndroidJsDebugger implements Debugger
2828
{
29+
private AndroidJsV8Inspector v8Inspector;
30+
2931
@Override
3032
public void onConnect(JsDebugger context)
3133
{
@@ -456,6 +458,17 @@ public void start()
456458
{
457459
AndroidJsDebugger.this.debugContext.enableAgent();
458460

461+
v8Inspector = new AndroidJsV8Inspector(context, logger);
462+
try
463+
{
464+
v8Inspector.start();
465+
}
466+
catch (IOException e)
467+
{
468+
e.printStackTrace();
469+
}
470+
471+
459472
handlerThread = new HandlerThread("debugAgentBroadCastReceiverHandler");
460473
handlerThread.start();
461474
Handler handler = new Handler(handlerThread.getLooper());

build-artifacts/project-template-gradle/src/main/java/com/tns/Util.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,10 @@ private static void silentClose(Closeable closeable)
114114

115115
public static Boolean isPositive(String value)
116116
{
117+
if(value == null) {
118+
return false;
119+
}
120+
117121
return (value.equals("true") || value.equals("TRUE") ||
118122
value.equals("yes") || value.equals("YES") ||
119123
value.equals("enabled") || value.equals("ENABLED"));

test-app/app/src/main/java/com/tns/AndroidJsDebugger.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,10 @@ public void run()
231231
state = State.Header;
232232
headers.clear();
233233

234+
if (!message.equals("FLUSH BUFFERS")) {
234235
AndroidJsDebugger.this.debugContext.sendMessage(message);
235236
}
237+
}
236238
else
237239
{
238240
if (leftOver == null)

0 commit comments

Comments
 (0)