fix a persistent static handle in NumericCasts

Author: petekanev

runtime/src/main/jni/NumericCasts.cpp

@@ -21,15 +21,13 @@ void NumericCasts::CreateGlobalCastFunctions(Isolate *isolate, const Local<Objec
 	globalTemplate->Set(ArgConverter::ConvertToV8String(isolate, "double"), FunctionTemplate::New(isolate, NumericCasts::MarkAsDoubleCallbackStatic, ext));
 	globalTemplate->Set(ArgConverter::ConvertToV8String(isolate, "float"), FunctionTemplate::New(isolate, NumericCasts::MarkAsFloatCallbackStatic, ext));
 	globalTemplate->Set(ArgConverter::ConvertToV8String(isolate, "char"), FunctionTemplate::New(isolate, NumericCasts::MarkAsCharCallbackStatic, ext));
-
-	s_castMarker = new Persistent<String>(isolate, ArgConverter::ConvertToV8String(isolate, "t::cast"));
 }
 
 CastType NumericCasts::GetCastType(const Local<Object>& object)
 {
 	auto ret = CastType::None;
 	auto isolate = object->GetIsolate();
-	auto key = Local<String>::New(isolate, *s_castMarker);
+	auto key = ArgConverter::ConvertToV8String(isolate, s_castMarker);
 	auto hidden = object->GetHiddenValue(key);
 	if (!hidden.IsEmpty())
 	{
@@ -456,12 +454,12 @@ void NumericCasts::MarkAsDoubleCallback(const v8::FunctionCallbackInfo<Value>& a
 void NumericCasts::MarkJsObject(const Local<Object>& object, CastType castType, const Local<Value>& value)
 {
 	auto isolate = object->GetIsolate();
-	auto key = Local<String>::New(isolate, *s_castMarker);
+	auto key = ArgConverter::ConvertToV8String(isolate, s_castMarker);
 	auto type = Integer::New(isolate, static_cast<int>(castType));
 
 	object->SetHiddenValue(key, type);
 	object->Set(V8StringConstants::GetValue(isolate), value);
 	DEBUG_WRITE("MarkJsObject: Marking js object: %d with cast type: %d", object->GetIdentityHash(), castType);
 }
 
-Persistent<String> *NumericCasts::s_castMarker = nullptr;
+std::string NumericCasts::s_castMarker = "t::cast";

runtime/src/main/jni/NumericCasts.h

@@ -57,7 +57,7 @@ namespace tns
 
 			static NumericCasts* GetThis(const v8::FunctionCallbackInfo<v8::Value>& args);
 
-			static v8::Persistent<v8::String> *s_castMarker;
+			static std::string s_castMarker;
 	};
 }
 

runtime/src/main/jni/Runtime.cpp

@@ -436,7 +436,9 @@ Isolate* Runtime::PrepareV8Runtime(const string& filesPath, jstring packageName,
 
 	V8::SetFlagsFromString(Constants::V8_STARTUP_FLAGS.c_str(), Constants::V8_STARTUP_FLAGS.size());
 	V8::SetCaptureStackTraceForUncaughtExceptions(true, 100, StackTrace::kOverview);
-	V8::AddMessageListener(NativeScriptException::OnUncaughtError);
+
+	isolate->AddMessageListener(NativeScriptException::OnUncaughtError);
+	
 	__android_log_print(ANDROID_LOG_DEBUG, "TNS.Native", "V8 version %s", V8::GetVersion());
 
 	auto globalTemplate = ObjectTemplate::New();