Skip to content

Commit dcb2553

Browse files
committed
Improved logging when an error is discarded
1 parent 2ba32e6 commit dcb2553

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

  • test-app
    • build-tools/static-binding-generator/src/main/java/org/nativescript/staticbindinggenerator
    • runtime/src/main/java/com/tns

test-app/build-tools/static-binding-generator/src/main/java/org/nativescript/staticbindinggenerator/Generator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -662,7 +662,7 @@ private void writeMethodBody(Method m, boolean isConstructor, boolean isApplicat
662662
if(this.suppressCallJSMethodExceptions) {
663663
w.writeln("\t\t} catch (Throwable t) {");
664664
w.writeln("\t\t\tcom.tns.Runtime.passSuppressedExceptionToJs(t, \"" + m.getName() + "\");");
665-
w.writeln("\t\t\tandroid.util.Log.w(\"Error\", t);");
665+
w.writeln("\t\t\tandroid.util.Log.w(\"Warning\", \"NativeScript discarding uncaught JS exception!\");");
666666
if (!ret.equals(Type.VOID)) {
667667
w.write("\t\t\t");
668668
w.write("return ");

test-app/runtime/src/main/java/com/tns/Runtime.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1157,8 +1157,7 @@ private Object dispatchCallJSMethodNative(final int javaObjectID, final String m
11571157
} catch (NativeScriptException e) {
11581158
if(discardUncaughtJsExceptions) {
11591159
String errorMessage = "Error on \"" + Thread.currentThread().getName() + "\" thread for callJSMethodNative\n";
1160-
// logger.write(errorMessage);
1161-
// e.printStackTrace();
1160+
android.util.Log.w("Warning", "NativeScript discarding uncaught JS exception!");
11621161
passDiscardedExceptionToJs(e, errorMessage);
11631162
} else {
11641163
throw e;
@@ -1180,9 +1179,7 @@ public void run() {
11801179
if(discardUncaughtJsExceptions) {
11811180
String errorMessage = "Error on \"" + Thread.currentThread().getName() + "\" thread for callJSMethodNative\n";
11821181
passDiscardedExceptionToJs(e, errorMessage);
1183-
// logger.write(errorMessage);
1184-
// e.printStackTrace();
1185-
1182+
android.util.Log.w("Warning", "NativeScript discarding uncaught JS exception!");
11861183
} else {
11871184
throw e;
11881185
}

0 commit comments

Comments
 (0)