Skip to content

Commit a2019ce

Browse files
committed
remove error prone ctor argument in LogcatLogger
1 parent 887c67c commit a2019ce

4 files changed

Lines changed: 6 additions & 16 deletions

File tree

build/project-template-gradle/src/main/java/com/tns/LogcatLogger.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,9 @@ public final class LogcatLogger implements Logger
99

1010
private boolean enabled;
1111

12-
public LogcatLogger(boolean isEnabled, Context context)
12+
public LogcatLogger(Context context)
1313
{
14-
this.enabled = isEnabled;
15-
16-
if (!isEnabled)
17-
{
18-
this.initLogging(context);
19-
}
14+
this.initLogging(context);
2015
}
2116

2217
public final boolean isEnabled()

build/project-template-gradle/src/main/java/com/tns/RuntimeHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public void initRuntime()
4646
{
4747
System.loadLibrary("NativeScript");
4848

49-
Logger logger = new LogcatLogger(false, app);
49+
Logger logger = new LogcatLogger(app);
5050
Debugger debugger = new AndroidJsDebugger(app, logger);
5151

5252
boolean showErrorIntent = hasErrorIntent();

test-app/src/com/tns/LogcatLogger.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,9 @@ public final class LogcatLogger implements Logger
99

1010
private boolean enabled;
1111

12-
public LogcatLogger(boolean isEnabled, Context context)
12+
public LogcatLogger(Context context)
1313
{
14-
this.enabled = isEnabled;
15-
16-
if (!isEnabled)
17-
{
18-
this.initLogging(context);
19-
}
14+
this.initLogging(context);
2015
}
2116

2217
public final boolean isEnabled()

test-app/src/com/tns/RuntimeHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public void initRuntime()
4646
{
4747
System.loadLibrary("NativeScript");
4848

49-
Logger logger = new LogcatLogger(true, app);
49+
Logger logger = new LogcatLogger(app);
5050
Debugger debugger = new AndroidJsDebugger(app, logger);
5151

5252
boolean showErrorIntent = hasErrorIntent();

0 commit comments

Comments
 (0)