Skip to content

Commit 7e62c65

Browse files
committed
add check for flag whether there are plugins consuming v8 apis
1 parent 29cce12 commit 7e62c65

2 files changed

Lines changed: 45 additions & 1 deletion

File tree

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
'use strict';
2+
3+
let args = process.argv;
4+
let dependencies = JSON.parse(args[2]);
5+
let platformsDir = args[3];
6+
7+
const path = require("path"),
8+
fs = require("fs");
9+
10+
if (dependencies) {
11+
let platformDir = path.join(platformsDir, "android");
12+
let buildDir = path.join(platformDir, "build-tools");
13+
let useV8File = path.join(buildDir, 'useV8');
14+
15+
try {
16+
fs.unlinkSync(useV8File);
17+
} catch (e) {
18+
19+
}
20+
21+
let useV8Symbols = false;
22+
23+
for (let dependencyName in dependencies) {
24+
let dependency = dependencies[dependencyName];
25+
26+
let isPlugin = !!dependency.nativescript;
27+
if (isPlugin) {
28+
let consumesV8Symbols = !!dependency.nativescript.useV8symbols;
29+
if (consumesV8Symbols) {
30+
useV8Symbols = true;
31+
break;
32+
}
33+
}
34+
}
35+
36+
if (useV8Symbols) {
37+
fs.writeFileSync(useV8File, "1");
38+
}
39+
}

build-artifacts/project-template-gradle/build.gradle

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,12 @@ dependencies {
212212

213213

214214
def copyNativeScriptAar() {
215-
def runtimeAarType = project.hasProperty("nooptimize") ? "regular" : "optimized";
215+
def useV8SymbolsFlag = new File("$projectDir/build-tools/useV8");
216+
def runtimeAarType = "optimized";
217+
if (useV8SymbolsFlag.exists() && !useV8SymbolsFlag.isDirectory()) {
218+
println "Using less-optimized runtime bundle.";
219+
runtimeAarType = "regular";
220+
}
216221

217222
copy {
218223
from "$projectDir/libs/runtime-libs/nativescript-${runtimeAarType}.aar"

0 commit comments

Comments
 (0)