Skip to content

Commit 755dbc9

Browse files
authored
Update extending-inspector.md
1 parent bbc692b commit 755dbc9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

docs/extending-inspector.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ This step involves fetching and building the V8 projectory, explanation for whic
7070
- [create a unique pointer wrapper for your new agent impl instance](https://github.com/NativeScript/android-runtime/blob/5a04e09439e2bc6a201577895b9ac6538441e758/test-app/runtime/src/main/cpp/v8_inspector/src/inspector/v8-inspector-session-impl.cc#L141), and call the static domain dispatcher's [wire](https://github.com/NativeScript/android-runtime/blob/5a04e09439e2bc6a201577895b9ac6538441e758/test-app/runtime/src/main/cpp/v8_inspector/src/inspector/v8-inspector-session-impl.cc#L143) method
7171
- make sure to call [agent.disable](https://github.com/NativeScript/android-runtime/blob/5a04e09439e2bc6a201577895b9ac6538441e758/test-app/runtime/src/main/cpp/v8_inspector/src/inspector/v8-inspector-session-impl.cc#L167) in V8InspectorSessionImpl's destructor.
7272
- register the newly implemented domain as a supported one inside [ V8InspectorSessionImpl::supportedDomainsImpl()](https://github.com/NativeScript/android-runtime/blob/5a04e09439e2bc6a201577895b9ac6538441e758/test-app/runtime/src/main/cpp/v8_inspector/src/inspector/v8-inspector-session-impl.cc#L389)
73-
- `#include "src/inspector/ns-v8-debugger-agent-impl.h"`
73+
- `#include "NSV8DebuggerAgentImpl.h"`
7474
- replace **V8DebuggerAgentImpl** with **NSV8DebuggerAgentImpl**
7575

7676
9. Don't forget to add the new classes to the CMakeLists!

0 commit comments

Comments
 (0)