removing lazy dependency to fix buffer warning (#1393)

Author: vtrifonov

build.gradle

@@ -127,6 +127,17 @@ task generateDtsgJar(type: Exec) {
     }
 }
 
+task jsParserNPMInstall(type: Exec) {
+    doFirst {
+        workingDir "$TEST_APP_PATH/build-tools/jsparser"
+        if (isWinOs) {
+            commandLine "cmd", "/c", "npm", "install"
+        } else {
+            commandLine "npm", "install"
+        }
+    }
+}
+
 task generateSbgJar(type: Exec) {
     doFirst {
         workingDir "$TEST_APP_PATH"
@@ -328,6 +339,7 @@ task createNpmPackage(type: Exec) {
 }
 
 generateSbgJar.dependsOn(generateDtsgJar)
+generateSbgJar.dependsOn(jsParserNPMInstall)
 generateMdgJar.dependsOn(generateSbgJar)
 createDistDir.dependsOn(generateMdgJar)
 

test-app/build-tools/jsparser/js_parser.js

@@ -22,10 +22,10 @@ loggingSettings = {
 var fs = require("fs"),
     babelParser = require("babylon"),
     traverse = require("babel-traverse"),
+    split = require('split'),
     logger = require('./helpers/logger')(loggingSettings),
     path = require("path"),
     es5_visitors = require("./visitors/es5-visitors"),
-    lazy = require("lazy"),
     eol = require('os').EOL,
 
     BUILD_TOOLS_DIR = `${__dirname}/../`,
@@ -99,17 +99,20 @@ readLinesFromFile(inputFilesPath, inputFiles, tsHelpersFilePath)
 */
 function readLinesFromFile(filePath, outArr, resolveParameter) {
     return new Promise(function (resolve, reject) {
-        new lazy(fs.createReadStream(filePath))
-            .lines
-            .forEach(function (line) {
+        fs.createReadStream(filePath)
+        .pipe(split())
+        .on('data', function (line) {
+            // skip empty lines
+            if(/\S/.test(line)) {
                 outArr.push(line.toString().trim());
-            }).on('pipe', function (err) {
-                if (err) {
-                    return reject(err);
-                }
-
-                return resolve(resolveParameter)
-            });
+            }
+        })
+        .on('error', function(err) {
+            return reject(err);
+        })
+        .on('close', function(e) {
+            return resolve(resolveParameter)
+        });
     });
 }
 
@@ -144,19 +147,21 @@ function getFileAst(tsHelpersFilePath) {
 */
 function readInterfaceNames(data, err) {
     return new Promise(function (resolve, reject) {
-        new lazy(fs.createReadStream(interfacesNamesFilePath))
-            .lines
-            .forEach(function (line) {
-                interfaceNames.push(line.toString());
-            }).on('pipe', function (err) {
-                if (err) {
-                    return reject(false);
-                }
-
-                inputDir = path.normalize(inputDir);
-
-                return resolve(inputDir);
-            });
+        fs.createReadStream(interfacesNamesFilePath)
+        .pipe(split())
+        .on('data', function (line) {
+            // skip empty lines
+            if(/\S/.test(line)) {
+                interfaceNames.push(line.toString().trim());
+            }
+        })
+        .on('error', function(e) {
+            return reject(false);
+        })
+        .on('close', function(e) {
+            inputDir = path.normalize(inputDir);
+            return resolve(inputDir);
+        });
     })
 }
 

test-app/build-tools/jsparser/package-lock.json

@@ -1,5 +1,5 @@
 {
-  "name": "ast-parser",
+  "name": "js-parser",
   "version": "1.0.0",
   "description": "javascript static analysis tool",
   "main": "js_parser.js",
@@ -13,7 +13,7 @@
     "babel-traverse": "6.26.0",
     "babel-types": "6.26.0",
     "babylon": "6.18.0",
-    "lazy": "1.0.11"
+    "split": "1.0.1"
   },
   "repository": "https://github.com/NativeScript/android-runtime",
   "devDependencies": {

test-app/build-tools/jsparser/package.json

@@ -7,14 +7,4 @@ include ':app',
 
 project(':static-binding-generator').projectDir = new File('build-tools/static-binding-generator')
 project(':android-metadata-generator').projectDir = new File('build-tools/android-metadata-generator')
-project(':dts-generator').projectDir = new File('build-tools/android-dts-generator/dts-generator')
-
-def isWinOs = System.properties['os.name'].toLowerCase().contains('windows')
-exec {
-    workingDir "$rootDir/build-tools/jsparser"
-    if (isWinOs) {
-        commandLine "cmd", "/c", "npm", "install"
-    } else {
-        commandLine "npm", "install"
-    }
-}
+project(':dts-generator').projectDir = new File('build-tools/android-dts-generator/dts-generator')