Show only the error message when built tool fails

Colorize the error outputs

Author: vtrifonov

.gitignore

@@ -20,4 +20,5 @@ bin/
 .settings
 
 .classpath
-android-runtime.iml
+android-runtime.iml
+test-app/build-tools/*.log

build.gradle

@@ -278,6 +278,10 @@ task copyFilesToProjectTemeplate {
             into "$DIST_FRAMEWORK_PATH/app/libs/runtime-libs"
             rename "runtime-optimized-with-inspector-release.aar", "nativescript-optimized-with-inspector.aar"
         }
+        copy {
+            from "$TEST_APP_PATH/app/gradle-helpers/BuildToolTask.gradle"
+            into "$DIST_FRAMEWORK_PATH/app/gradle-helpers"
+        }
         copy {
             from "$TEST_APP_PATH/app/build.gradle"
             into "$DIST_FRAMEWORK_PATH/app"
@@ -287,12 +291,12 @@ task copyFilesToProjectTemeplate {
             into "$DIST_FRAMEWORK_PATH"
         }
         copy {
-            from "$TEST_APP_PATH/paths.gradle"
-            into "$DIST_FRAMEWORK_PATH"
+            from "$TEST_APP_PATH/gradle-helpers/paths.gradle"
+            into "$DIST_FRAMEWORK_PATH/gradle-helpers"
         }
         copy {
-            from "$TEST_APP_PATH/user_properties_reader.gradle"
-            into "$DIST_FRAMEWORK_PATH"
+            from "$TEST_APP_PATH/gradle-helpers/user_properties_reader.gradle"
+            into "$DIST_FRAMEWORK_PATH/gradle-helpers"
         }
         copy {
             from "$TEST_APP_PATH/gradle"

test-app/app/build.gradle

@@ -27,8 +27,12 @@ import java.nio.file.Files
 import java.nio.file.Paths
 import java.nio.file.StandardCopyOption
 import java.security.MessageDigest
+import org.gradle.internal.logging.text.StyledTextOutputFactory
 
 apply plugin: "com.android.application"
+apply from: "gradle-helpers/BuildToolTask.gradle"
+def outLogger = services.get(StyledTextOutputFactory).create("colouredOutputLogger")
+gradle.useLogger(new BuildAdapter())
 
 def enableKotlin = (project.hasProperty("useKotlin") && project.useKotlin == "true")
 
@@ -464,7 +468,7 @@ tasks.whenTaskAdded({ org.gradle.api.DefaultTask currentTask ->
 ///////////////////////////// EXECUTUION PHASE /////////////////////////////////////
 ////////////////////////////////////////////////////////////////////////////////////
 
-task runSbg(type: JavaExec) {
+task runSbg(type: BuildToolTask) {
     dependsOn "collectAllJars"
     if (!findProject(':static-binding-generator').is(null)) {
         dependsOn ':static-binding-generator:jar'
@@ -484,6 +488,8 @@ task runSbg(type: JavaExec) {
         paramz.add("-show-deprecation-warnings")
     }
 
+    setOutputs outLogger
+
     args paramz
 
     doFirst {
@@ -695,7 +701,7 @@ task collectAllJars {
     }
 }
 
-task buildMetadata(type: JavaExec) {
+task buildMetadata(type: BuildToolTask) {
     if (!findProject(':android-metadata-generator').is(null)) {
         dependsOn ':android-metadata-generator:jar'
     }
@@ -749,11 +755,13 @@ task buildMetadata(type: JavaExec) {
         workingDir "$BUILD_TOOLS_PATH"
         main "-jar"
 
+        setOutputs outLogger
+
         args "android-metadata-generator.jar"
     }
 }
 
-task generateTypescriptDefinitions(type: JavaExec) {
+task generateTypescriptDefinitions(type: BuildToolTask) {
     if (!findProject(':dts-generator').is(null)) {
         dependsOn ':dts-generator:jar'
     }
@@ -785,6 +793,9 @@ task generateTypescriptDefinitions(type: JavaExec) {
 
         logger.info("Task generateTypescriptDefinitions: Call dts-generator.jar with arguments: " + paramz.toString().replaceAll(',', ''))
         println "Task generateTypescriptDefinitions: Call dts-generator.jar with arguments: " + paramz.toString().replaceAll(',', '')
+
+        setOutputs outLogger
+
         args paramz.toArray()
     }
 }

test-app/app/gradle-helpers/BuildToolTask.gradle

@@ -0,0 +1,50 @@
+import static org.gradle.internal.logging.text.StyledTextOutput.Style
+
+class BuildToolTask extends JavaExec {
+    void setOutputs(def logger) {
+        def logFile = new File("$workingDir/${name}.log")
+        if(logFile.exists()) {
+            logFile.delete()
+        }
+        standardOutput new FileOutputStream(logFile)
+        errorOutput new FailureOutputStream(logger, logFile)
+    }
+}
+
+class FailureOutputStream extends OutputStream {
+    private logger
+    private File logFile
+    private currentLine = ""
+    private firstWrite = true
+    FailureOutputStream(inLogger, inLogFile) {
+        logger = inLogger
+        logFile = inLogFile
+    }
+
+    @Override
+    void write(int i) throws IOException {
+        if(firstWrite) {
+            println ""
+            firstWrite = false
+        }
+        currentLine += String.valueOf((char) i)
+    }
+
+    @Override
+    void flush() {
+        if(currentLine?.trim()) {
+            logger.withStyle(Style.Failure).println currentLine.trim()
+            currentLine = ""
+        }
+    }
+
+    @Override
+    void close() {
+        if(!firstWrite && logFile.exists()) {
+            logger.withStyle(Style.Info).println "Detailed log here: ${logFile.getAbsolutePath()}\n"
+        }
+        super.close()
+    }
+}
+
+ext.BuildToolTask = BuildToolTask

test-app/build-tools/android-dts-generator

@@ -19,33 +19,39 @@ public class Generator {
     /**
      * @param args
      */
-    public static void main(String[] args) throws Exception {
-        String metadataOutputDir = "bin";
-        List<String> params = null;
-
+    public static void main(String[] args) {
         try {
-            metadataOutputDir = getFileRows(MDG_OUTPUT_DIR).get(0);
-        } catch (Exception e) {
-            throw new InvalidParameterException(String.format("You need to pass a file containing a single line: the output dir for the metadata generator1\n", e.getMessage()));
-        }
-        try {
-            params = getFileRows(MDG_JAVA_DEPENDENCIES);
-        } catch (Exception e) {
-            throw new InvalidParameterException(String.format("You need to pass a file containing a list of jar/class paths, so metadata can be generated for them!\n", e.getMessage()));
-        }
+            String metadataOutputDir;
+            List<String> params;
 
-        TreeNode root = Builder.build(params);
+            try {
+                metadataOutputDir = getFileRows(MDG_OUTPUT_DIR).get(0);
+            } catch (Exception e) {
+                throw new InvalidParameterException(String.format("You need to pass a file containing a single line: the output dir for the metadata generator1\n", e.getMessage()));
+            }
+            try {
+                params = getFileRows(MDG_JAVA_DEPENDENCIES);
+            } catch (Exception e) {
+                throw new InvalidParameterException(String.format("You need to pass a file containing a list of jar/class paths, so metadata can be generated for them!\n", e.getMessage()));
+            }
 
-        FileOutputStream ovs = new FileOutputStream(new File(metadataOutputDir, "treeValueStream.dat"));
-        FileStreamWriter outValueStream = new FileStreamWriter(ovs);
+            TreeNode root = Builder.build(params);
 
-        FileOutputStream ons = new FileOutputStream(new File(metadataOutputDir, "treeNodeStream.dat"));
-        FileStreamWriter outNodeStream = new FileStreamWriter(ons);
+            FileOutputStream ovs = new FileOutputStream(new File(metadataOutputDir, "treeValueStream.dat"));
+            FileStreamWriter outValueStream = new FileStreamWriter(ovs);
 
-        FileOutputStream oss = new FileOutputStream(new File(metadataOutputDir, "treeStringsStream.dat"));
-        FileStreamWriter outStringsStream = new FileStreamWriter(oss);
+            FileOutputStream ons = new FileOutputStream(new File(metadataOutputDir, "treeNodeStream.dat"));
+            FileStreamWriter outNodeStream = new FileStreamWriter(ons);
 
-        new Writer(outNodeStream, outValueStream, outStringsStream).writeTree(root);
+            FileOutputStream oss = new FileOutputStream(new File(metadataOutputDir, "treeStringsStream.dat"));
+            FileStreamWriter outStringsStream = new FileStreamWriter(oss);
+
+            new Writer(outNodeStream, outValueStream, outStringsStream).writeTree(root);
+        } catch (Exception ex) {
+            System.err.println(String.format("Error executing Metadata Generator: %s", ex.getMessage()));
+            ex.printStackTrace(System.out);
+            System.exit(1);
+        }
     }
 
     public static List<String> getFileRows(String filename) throws IOException {

test-app/build-tools/android-metadata-generator/src/src/com/telerik/metadata/Generator.java

@@ -35,22 +35,29 @@ public class Main {
         inputJsFiles = new ArrayList<>();
     }
 
-    public static void main(String[] args) throws IOException, ClassNotFoundException {
-        InputParameters.parseCommand(args);
+    public static void main(String[] args) {
+        try {
+            InputParameters.parseCommand(args);
+
+            validateInput();
 
-        validateInput();
+            getWorkerExcludeFile();
 
-        getWorkerExcludeFile();
+            List<DataRow> rows = Generator.getRows(dependenciesFile);
+            GetInterfaceNames.generateInterfaceFile(rows);
+            generateJsInputFile();
+            runJsParser();
 
-        List<DataRow> rows = Generator.getRows(dependenciesFile);
-        GetInterfaceNames.generateInterfaceFile(rows);
-        generateJsInputFile();
-        runJsParser();
+            // generate java bindings
+            String inputBindingFilename = Paths.get(System.getProperty("user.dir"), SBG_BINDINGS_NAME).toString();
+            Generator generator = new Generator(outputDir, rows, isSuppressCallJSMethodExceptionsEnabled());
 
-        // generate java bindings
-        String inputBindingFilename = Paths.get(System.getProperty("user.dir"), SBG_BINDINGS_NAME).toString();
-        Generator generator = new Generator(outputDir, rows, isSuppressCallJSMethodExceptionsEnabled());
-        generator.writeBindings(inputBindingFilename);
+            generator.writeBindings(inputBindingFilename);
+        } catch (Exception ex) {
+            System.err.println(String.format("Error executing Static Binding Generator: %s", ex.getMessage()));
+            ex.printStackTrace(System.out);
+            System.exit(1);
+        }
     }
 
     /*

test-app/build-tools/static-binding-generator/src/main/java/org/nativescript/staticbindinggenerator/Main.java

@@ -4,8 +4,8 @@ buildscript {
 
     def initialize = { ->
         def userDir = "${rootProject.projectDir}/../.."
-        apply from: "$rootDir/user_properties_reader.gradle"
-        apply from: "$rootDir/paths.gradle"
+        apply from: "$rootDir/gradle-helpers/user_properties_reader.gradle"
+        apply from: "$rootDir/gradle-helpers/paths.gradle"
         rootProject.ext.userDefinedGradleProperties = getUserProperties("${getAppResourcesPath(userDir)}/Android")
     }
     initialize()