Skip to content

Commit 34aeb60

Browse files
authored
Merge pull request #717 from NativeScript/pete/fix-console-messages-debug
Fix console messages not displaying when app is built in debug
2 parents 5dd31fc + a58e8ce commit 34aeb60

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

runtime/src/main/jni/JsV8InspectorClient.cpp

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
#include "JsV8InspectorClient.h"
2-
//#include "V8GlobalHelpers.h"
3-
//#include "ArgConverter.h"
4-
//#include "JniLocalRef.h"
5-
//#include "NativeScriptException.h"
6-
//#include "NativeScriptAssert.h"
72
#include <sstream>
83
#include <assert.h>
94
#include <include/libplatform/libplatform.h>
@@ -173,13 +168,12 @@ void JsV8InspectorClient::init() {
173168
v8::HandleScope handle_scope(isolate_);
174169

175170
v8::Local<Context> context = isolate_->GetCurrentContext();
176-
v8::Context::Scope context_scope(context);
177171

178172
inspector_ = V8Inspector::create(isolate_, this);
179173

180174
inspector_->contextCreated(v8_inspector::V8ContextInfo(context, 0, v8_inspector::StringView()));
181175

182-
v8::Persistent<v8::Context> persistentContext(context->GetIsolate(), context);
176+
v8::Persistent<v8::Context> persistentContext(context->GetIsolate(), JsV8InspectorClient::PersistentToLocal(isolate_, context_));
183177
context_.Reset(isolate_, persistentContext);
184178

185179
this->createInspectorSession(isolate_, context);

0 commit comments

Comments
 (0)