reuse JEnv instances

Author: Mihail Slavchev

src/jni/JsArgConverter.cpp

@@ -538,13 +538,11 @@ JsArgConverter::~JsArgConverter()
 {
 	if (m_argsLen > 0)
 	{
-		JEnv env;
-
 		int length = m_storedObjects.size();
 		for (int i = 0; i < length; i++)
 		{
 			int index = m_storedObjects[i];
-			env.DeleteLocalRef(m_args[index].l);
+			m_env.DeleteLocalRef(m_args[index].l);
 		}
 	}
 }

src/jni/ObjectManager.cpp

@@ -137,10 +137,8 @@ jweak ObjectManager::GetJavaObjectByID(uint32_t javaObjectID)
 	return obj;
 }
 
-jobject ObjectManager::GetJavaObjectByIDImpl(uint32_t javaObjectID)
+jobject ObjectManager::GetJavaObjectByIDImpl(JEnv& env, uint32_t javaObjectID)
 {
-	JEnv env;
-
 	jobject object = env.CallStaticObjectMethod(PlatformClass, GET_JAVAOBJECT_BY_ID_METHOD_ID, javaObjectID);
 	return object;
 }
@@ -788,9 +786,10 @@ jweak ObjectManager::NewWeakGlobalRefCallback(const int& javaObjectID, void *sta
 {
 	ObjectManager *objManager = reinterpret_cast<ObjectManager*>(state);
 
-	JniLocalRef obj(objManager->GetJavaObjectByIDImpl(javaObjectID));
-
 	JEnv env;
+
+	JniLocalRef obj(objManager->GetJavaObjectByIDImpl(env, javaObjectID));
+
 	jweak weakRef = env.NewWeakGlobalRef(obj);
 
 	return weakRef;

src/jni/ObjectManager.h

@@ -159,7 +159,7 @@ namespace tns
 
 			jweak GetJavaObjectByID(uint32_t javaObjectID);
 
-			jobject GetJavaObjectByIDImpl(uint32_t javaObjectID);
+			jobject GetJavaObjectByIDImpl(JEnv& env, uint32_t javaObjectID);
 
 			static jweak NewWeakGlobalRefCallback(const int& javaObjectID, void *state);