Skip to content

Commit 1f1ab6e

Browse files
author
Mihail Slavchev
committed
merge with master
1 parent 98fa3d3 commit 1f1ab6e

4 files changed

Lines changed: 11 additions & 8 deletions

File tree

src/jni/ArrayBufferHelper.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@
88
using namespace v8;
99
using namespace tns;
1010

11-
ArrayBufferHelper::ArrayBufferHelper(ObjectManager *objectManager)
12-
: m_objectManager(objectManager), m_ByteBufferClass(nullptr), m_isDirectMethodID(nullptr)
11+
ArrayBufferHelper::ArrayBufferHelper()
12+
: m_objectManager(nullptr), m_ByteBufferClass(nullptr), m_isDirectMethodID(nullptr)
1313
{
1414
}
1515

16-
void ArrayBufferHelper::CreateConvertFunctions(const Local<Object>& global)
16+
void ArrayBufferHelper::CreateConvertFunctions(Isolate *isolate, const Local<Object>& global, ObjectManager *objectManager)
1717
{
18-
auto isolate = Isolate::GetCurrent();
18+
m_objectManager = objectManager;
19+
1920
auto extData = External::New(isolate, this);
2021
auto fromFunc = FunctionTemplate::New(isolate, CreateFromCallbackStatic, extData)->GetFunction();
2122
auto ctx = isolate->GetCurrentContext();

src/jni/ArrayBufferHelper.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ namespace tns
99
class ArrayBufferHelper
1010
{
1111
public:
12-
ArrayBufferHelper(ObjectManager *objectManager);
12+
ArrayBufferHelper();
1313

14-
void CreateConvertFunctions(const v8::Local<v8::Object>& global);
14+
void CreateConvertFunctions(v8::Isolate *isolate, const v8::Local<v8::Object>& global, ObjectManager *objectManager);
1515

1616
private:
1717

src/jni/Runtime.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,8 +438,7 @@ Isolate* Runtime::PrepareV8Runtime(const string& filesPath, jstring packageName,
438438

439439
ArrayHelper::Init(context);
440440

441-
s_arrayBufferHeper = ArrayBufferHelper(g_objectManager);
442-
s_arrayBufferHeper.CreateConvertFunctions(global);
441+
m_arrayBufferHelper.CreateConvertFunctions(isolate, global, m_objectManager);
443442

444443
return isolate;
445444
}

src/jni/Runtime.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
#include "ObjectManager.h"
77
#include "SimpleAllocator.h"
88
#include "WeakRef.h"
9+
#include "ArrayBufferHelper.h"
910

1011
jobject ConvertJsValueToJavaObject(tns::JEnv& env, const v8::Local<v8::Value>& value, int classReturnType);
1112

@@ -49,6 +50,8 @@ namespace tns
4950

5051
ObjectManager *m_objectManager;
5152

53+
ArrayBufferHelper m_arrayBufferHelper;
54+
5255
WeakRef m_weakRef;
5356

5457
static void PrepareExtendFunction(v8::Isolate *isolate, jstring filesPath);

0 commit comments

Comments
 (0)