chore: fix weakref tests

Author: edusperoni

test-app/app/src/main/assets/app/tests/testNativeTimers.js

@@ -115,9 +115,12 @@ describe('native timer', () => {
             expect(!!weakRef.get()).toBe(true);
             clearInterval(interval);
             clearTimeout(timeout);
-            gc();
-            expect(!!weakRef.get()).toBe(false);
-            done();
+            // use another timeout as native weakrefs can't be gced until we leave the isolate after being used once
+            setTimeout(() => {
+                gc();
+                expect(!!weakRef.get()).toBe(false);
+                done();
+            })
         }, 200);
     })
 });

test-app/app/src/main/assets/app/tests/testWeakRef.js

@@ -1,149 +1,97 @@
 describe("Test WeakRef ", function () {
-	
-	it("Test if WeakRef gets cleared after gc", function () {
-		
+	it("Test if WeakRef gets cleared after gc", function (done) {
 		__log("TEST: TestWeakRefGetsClearedAfterGC");
-		
+
 		var wr = new WeakRef({ someProp: 12345 });
-		
+
 		var val = wr.get().someProp;
 		expect(val).toBe(12345);
-		
 		gc();
-		
-		var val = wr.get();
-		expect(val).toBe(null);
-	});
-	
-	it("Test if WeakRef gets cleared after clear", function () {
-		
-		__log("TEST: TestWeakRefGetsClearedAfterClear");
-		
-		var wr = new WeakRef({ someProp: 54321 });
-		
-		var val = wr.get().someProp;
-		expect(val).toBe(54321);
-		
-		wr.clear();
-		
-		var val = wr.get();
-		expect(val).toBe(null);
+
+		setTimeout(() => {
+			gc();
+			var val = wr.get();
+			expect(val).toBe(undefined);
+			done();
+		});
 	});
-	
-	it("Test if WeakRef can create multiple instances", function () {
-		
+
+	it("Test if WeakRef can create multiple instances", function (done) {
 		__log("TEST: TestWeakRefCanCreateMultipleInstances");
-		
-		var target = { someProp: 54321 };
-		
-		var wr1 = new WeakRef(target);
-		var wr2 = new WeakRef(target);
-		
-		target = null;
-		
-		wr1.clear();
-		
-		var val = wr1.get();
-		expect(val).toBe(null);
-		
-		val = wr2.get().someProp;
-		expect(val).toBe(54321);
-	});
-	
-	it("Test if WeakRef can create multiple instances 2", function () {
 
-		__log("TEST: TestWeakRefCanCreateMultipleInstances2");
-		
 		var target = { someProp: 54321 };
-		
+
 		var wr1 = new WeakRef(target);
 		var wr2 = new WeakRef(target);
-		
+
 		target = null;
-		gc();
-		
-		var val1 = wr1.get();
-		expect(val1).toBe(null);
-		
-		var val2 = wr2.get();
-		expect(val2).toBe(null);
+		setTimeout(() => {
+			gc();
+
+			var val1 = wr1.get();
+			expect(val1).toBe(undefined);
+
+			var val2 = wr2.get();
+			expect(val2).toBe(undefined);
+			done();
+		});
 	});
-	
+
 	it("Test if WeakRef throws exception when constructed with wrong number of parameters", function () {
-		
-		__log("TEST: TestWeakRefThrowsExceptionWhenConstructedWithWrongNumberOfParameters");
-		
+		__log(
+			"TEST: TestWeakRefThrowsExceptionWhenConstructedWithWrongNumberOfParameters"
+		);
+
 		var exceptionCaught = false;
-		try
-		{
+		try {
 			new WeakRef();
-		}
-		catch (e)
-		{
+		} catch (e) {
 			exceptionCaught = true;
 		}
 		expect(exceptionCaught).toBe(true);
-		
+
 		exceptionCaught = false;
-		try
-		{
+		try {
 			new WeakRef(1, 2);
-		}
-		catch (e)
-		{
+		} catch (e) {
 			exceptionCaught = true;
 		}
 		expect(exceptionCaught).toBe(true);
-		
 	});
 
 	it("Test if WeakRef throws exception when constructed with non object", function () {
-		
 		__log("TEST: TestWeakRefThrowsExceptionWhenConstructedWithNonObject");
-		
+
 		var exceptionCaught = false;
-		try
-		{
+		try {
 			new WeakRef(1);
-		}
-		catch (e)
-		{
+		} catch (e) {
 			exceptionCaught = true;
 		}
 		expect(exceptionCaught).toBe(true);
-		
+
 		exceptionCaught = false;
-		try
-		{
+		try {
 			new WeakRef(false);
-		}
-		catch (e)
-		{
+		} catch (e) {
 			exceptionCaught = true;
 		}
 		expect(exceptionCaught).toBe(true);
 
 		exceptionCaught = false;
-		try
-		{
+		try {
 			new WeakRef(null);
-		}
-		catch (e)
-		{
+		} catch (e) {
 			exceptionCaught = true;
 		}
 		expect(exceptionCaught).toBe(true);
 
 		exceptionCaught = false;
-		try
-		{
+		try {
 			new WeakRef(undefined);
-		}
-		catch (e)
-		{
+		} catch (e) {
 			exceptionCaught = true;
 		}
 		expect(exceptionCaught).toBe(true);
 	});
 });
-