Skip to content

Commit 000ae8b

Browse files
author
Mihail Slavchev
committed
remove ApplicationID parameter
1 parent 2528c11 commit 000ae8b

4 files changed

Lines changed: 8 additions & 21 deletions

File tree

src/jni/NativePlatform.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ Persistent<Context> *PrimaryContext = nullptr;
3838
Context::Scope *context_scope = nullptr;
3939
ObjectManager *g_objectManager = nullptr;
4040
bool tns::LogEnabled = true;
41-
int AppJavaObjectID = -1;
4241
int count = 0;
4342
SimpleAllocator g_allocator;
4443

@@ -59,9 +58,8 @@ void NativePlatform::Init(JavaVM *vm, void *reserved)
5958
DEBUG_WRITE("JNI_ONLoad END");
6059
}
6160

62-
Isolate* NativePlatform::InitNativeScript(JNIEnv *_env, jobject obj, jstring filesPath, jint appJavaObjectId, jboolean verboseLoggingEnabled, jstring packageName, jobjectArray args, jobject jsDebugger)
61+
Isolate* NativePlatform::InitNativeScript(JNIEnv *_env, jobject obj, jstring filesPath, jboolean verboseLoggingEnabled, jstring packageName, jobjectArray args, jobject jsDebugger)
6362
{
64-
AppJavaObjectID = appJavaObjectId;
6563
tns::LogEnabled = verboseLoggingEnabled;
6664

6765
JEnv env(_env);
@@ -78,7 +76,7 @@ Isolate* NativePlatform::InitNativeScript(JNIEnv *_env, jobject obj, jstring fil
7876
JniLocalRef snapshotScript(env.GetObjectArrayElement(args, 3));
7977
Constants::V8_HEAP_SNAPSHOT_SCRIPT = ArgConverter::jstringToString(snapshotScript);
8078

81-
DEBUG_WRITE("Initializing Telerik NativeScript: app instance id:%d", appJavaObjectId);
79+
DEBUG_WRITE("Initializing Telerik NativeScript");
8280

8381
NativeScriptException::Init(g_jvm, g_objectManager);
8482
s_isolate = PrepareV8Runtime(env, filesRoot, packageName, jsDebugger);

src/jni/NativePlatform.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace tns
1414
{
1515
public:
1616
static void Init(JavaVM *vm, void *reserved);
17-
static v8::Isolate* InitNativeScript(JNIEnv *_env, jobject obj, jstring filesPath, jint appJavaObjectId, jboolean verboseLoggingEnabled, jstring packageName, jobjectArray args, jobject jsDebugger);
17+
static v8::Isolate* InitNativeScript(JNIEnv *_env, jobject obj, jstring filesPath, jboolean verboseLoggingEnabled, jstring packageName, jobjectArray args, jobject jsDebugger);
1818
static void RunModule(JNIEnv *_env, jobject obj, jstring scriptFile);
1919
static jobject RunScript(JNIEnv *_env, jobject obj, jstring scriptFile);
2020
static jobject CallJSMethodNative(JNIEnv *_env, jobject obj, jint javaObjectID, jstring methodName, jint retType, jboolean isConstructor, jobjectArray packagedArgs);

src/jni/com_tns_Platform.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ JNIEXPORT jint JNICALL JNI_OnLoad(JavaVM *vm, void *reserved)
3333
return JNI_VERSION_1_6;
3434
}
3535

36-
extern "C" void Java_com_tns_Platform_initNativeScript(JNIEnv *_env, jobject obj, jstring filesPath, jint appJavaObjectId, jboolean verboseLoggingEnabled, jstring packageName, jobjectArray args, jobject jsDebugger)
36+
extern "C" void Java_com_tns_Platform_initNativeScript(JNIEnv *_env, jobject obj, jstring filesPath, jboolean verboseLoggingEnabled, jstring packageName, jobjectArray args, jobject jsDebugger)
3737
{
3838
try
3939
{
40-
g_isolate = NativePlatform::InitNativeScript(_env, obj, filesPath, appJavaObjectId, verboseLoggingEnabled, packageName, args, jsDebugger);
40+
g_isolate = NativePlatform::InitNativeScript(_env, obj, filesPath, verboseLoggingEnabled, packageName, args, jsDebugger);
4141
}
4242
catch (NativeScriptException& e)
4343
{

src/src/com/tns/Platform.java

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
public class Platform
2727
{
28-
private static native void initNativeScript(String filesPath, int appJavaObjectId, boolean verboseLoggingEnabled, String packageName, Object[] v8Options, JsDebugger jsDebugger);
28+
private static native void initNativeScript(String filesPath, boolean verboseLoggingEnabled, String packageName, Object[] v8Options, JsDebugger jsDebugger);
2929

3030
private static native void runModule(String filePath) throws NativeScriptException;
3131

@@ -100,7 +100,7 @@ public static void setErrorActivityClass(Class<?> clazz)
100100
errorActivityClass = clazz;
101101
}
102102

103-
public static int init(Application application, ThreadScheduler threadScheduler, Logger logger, String appName, File runtimeLibPath, File rootDir, File appDir, ClassLoader classLoader, File dexDir, String dexThumb) throws RuntimeException
103+
public static void init(Application application, ThreadScheduler threadScheduler, Logger logger, String appName, File runtimeLibPath, File rootDir, File appDir, ClassLoader classLoader, File dexDir, String dexThumb) throws RuntimeException
104104
{
105105
if (initialized)
106106
{
@@ -113,20 +113,10 @@ public static int init(Application application, ThreadScheduler threadScheduler,
113113

114114
Platform.dexFactory = new DexFactory(logger, classLoader, dexDir, dexThumb);
115115

116-
int appJavaObjectId = -1;
117-
118116
if (logger.isEnabled())
119117
{
120118
logger.write("Initializing NativeScript JAVA");
121119
}
122-
123-
appJavaObjectId = generateNewObjectId();
124-
makeInstanceStrong(application, appJavaObjectId);
125-
if (logger.isEnabled())
126-
{
127-
logger.write("Initialized app instance id:" + appJavaObjectId);
128-
}
129-
130120

131121
try
132122
{
@@ -143,7 +133,7 @@ public static int init(Application application, ThreadScheduler threadScheduler,
143133
jsDebugger = new JsDebugger(application, logger, threadScheduler);
144134
}
145135

146-
Platform.initNativeScript(Module.getApplicationFilesPath(), appJavaObjectId, logger.isEnabled(), appName, v8Config, jsDebugger);
136+
Platform.initNativeScript(Module.getApplicationFilesPath(), logger.isEnabled(), appName, v8Config, jsDebugger);
147137

148138
if (jsDebugger != null)
149139
{
@@ -160,7 +150,6 @@ public static int init(Application application, ThreadScheduler threadScheduler,
160150
}
161151

162152
initialized = true;
163-
return appJavaObjectId;
164153
}
165154

166155
@RuntimeCallable

0 commit comments

Comments
 (0)