Skip to content

Commit c0145c6

Browse files
committed
Merge branch 'main' into 572_project_setup
2 parents 8c0c074 + 8b05160 commit c0145c6

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
### Added
66
* Keep project_setup.md for all the profiles and remove from the menu [#576](https://github.com/NLeSC/python-template/pull/576)
77
* Make contributing guidelines optional [#465](https://github.com/NLeSC/python-template/pull/465)
8+
* Make editorconfig optional [#571](https://github.com/NLeSC/python-template/pull/571)
9+
* Make contributing guidelines optional [#465]()
810
* Make developer documentation optional [#467](https://github.com/NLeSC/python-template/pull/541)
911
* Make Code of Conduct optional [#464](https://github.com/NLeSC/python-template/pull/530)
1012
* New YAML files for copier questions [#529](https://github.com/NLeSC/python-template/pull/529)

copier/questions/features_code_quality.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ SelectCodeQualityFeatures:
77
type: yaml
88
default: |-
99
{% if template_profile == 'recommended' %}
10-
[SelectGitHubActions_flag, not_implemented_linting, AddSonarCloud_flag, not_implemented_editor_config]
10+
[SelectGitHubActions_flag, not_implemented_linting, AddSonarCloud_flag, AddEditorConfig_flag]
1111
{%- else -%}
1212
[]
1313
{%- endif %}
@@ -26,8 +26,8 @@ SelectCodeQualityFeatures:
2626
Code analysis (using SonarCloud):
2727
value: AddSonarCloud_flag
2828
# validator: "{% if something != 'AnotherThing' %}BlaBla{% endif %}"
29-
Editorconfig (NOT_IMPLEMENTED):
30-
value: not_implemented_editor_config
29+
Editorconfig:
30+
value: AddEditorConfig_flag
3131
# validator: "{% if something != 'AnotherThing' %}BlaBla{% endif %}"
3232

3333

@@ -80,3 +80,8 @@ AddSonarCloud:
8080
type: bool
8181
default: "{{ 'AddSonarCloud_flag' in SelectCodeQualityFeatures }}"
8282
when: false
83+
84+
AddEditorConfig:
85+
type: bool
86+
default: "{{ 'AddEditorConfig_flag' in SelectCodeQualityFeatures }}"
87+
when: false

template/.editorconfig renamed to template/{% if AddEditorConfig %}.editorconfig{% endif %}

File renamed without changes.

0 commit comments

Comments
 (0)