Skip to content

Commit 4f3248d

Browse files
NishaSharma14NishaSharma14
authored
Merge pull request #137 from NFDI4Chem/refactor-workflows
refactor: workflows
2 parents ea81efc + b3ddd83 commit 4f3248d

5 files changed

Lines changed: 75 additions & 78 deletions

File tree

‎.github/workflows/dev-build.yml‎

Lines changed: 2 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -25,47 +25,10 @@ env:
2525

2626
jobs:
2727
e2etest:
28-
runs-on: ubuntu-latest
29-
strategy:
30-
matrix:
31-
project: [chromium, firefox, webkit]
32-
fail-fast: false
33-
steps:
34-
- uses: actions/checkout@v3
35-
- uses: actions/setup-node@v3
36-
with:
37-
node-version: 18.x
38-
- name: Install dependencies
39-
run: npm ci
40-
- name: Install Playwright
41-
run: npx playwright install --with-deps
42-
- name: Build test application
43-
run: npm run build-no-minify
44-
- name: Run E2E tests on ${{ matrix.project }}
45-
run: npx playwright test --project ${{ matrix.project }}
46-
continue-on-error: ${{ matrix.project == 'webkit' }}
47-
- name: Upload test results
48-
if: always()
49-
uses: actions/upload-artifact@v3
50-
with:
51-
name: test-results-${{ matrix.project }}
52-
path: test-results
28+
uses: NFDI4Chem/nmrium-react-wrapper/.github/workflows/e2e.yml@main
5329

5430
lint:
55-
runs-on: ubuntu-latest
56-
steps:
57-
- uses: actions/checkout@v2
58-
- uses: actions/setup-node@v2
59-
with:
60-
node-version: 16.x
61-
- name: Install dependencies
62-
run: npm ci
63-
- name: Run ESLint
64-
run: npm run eslint
65-
- name: Run Prettier
66-
run: npm run prettier
67-
- name: Check types
68-
run: npm run check-types
31+
uses: NFDI4Chem/nmrium-react-wrapper/.github/workflows/nodejs.yml@main
6932

7033
setup-build-publish-deploy-dev:
7134
name: Deploy to dev

‎.github/workflows/dev-check.yml‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
name: Node.js Dev Checking
2+
3+
on:
4+
push:
5+
branches-ignore:
6+
- 'main'
7+
- 'development'
8+
pull_request:
9+
branches:
10+
- development
11+
12+
jobs:
13+
e2etest:
14+
uses: NFDI4Chem/nmrium-react-wrapper/.github/workflows/e2e.yml@main
15+
lint:
16+
uses: NFDI4Chem/nmrium-react-wrapper/.github/workflows/nodejs.yml@main
17+

‎.github/workflows/e2e.yml‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
name: e2e tests
2+
3+
on:
4+
workflow_call:
5+
6+
jobs:
7+
e2etest:
8+
runs-on: ubuntu-latest
9+
strategy:
10+
matrix:
11+
project: [chromium, firefox, webkit]
12+
fail-fast: false
13+
steps:
14+
- uses: actions/checkout@v3
15+
- uses: actions/setup-node@v3
16+
with:
17+
node-version: 18.x
18+
- name: Install dependencies
19+
run: npm ci
20+
- name: Install Playwright
21+
run: npx playwright install --with-deps
22+
- name: Build test application
23+
run: npm run build-no-minify
24+
- name: Run E2E tests on ${{ matrix.project }}
25+
run: npx playwright test --project ${{ matrix.project }}
26+
continue-on-error: ${{ matrix.project == 'webkit' }}
27+
- name: Upload test results
28+
if: always()
29+
uses: actions/upload-artifact@v3
30+
with:
31+
name: test-results-${{ matrix.project }}
32+
path: test-results
33+

‎.github/workflows/nodejs.yml‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
name: Node.js check
2+
3+
on:
4+
workflow_call:
5+
6+
jobs:
7+
nodejs:
8+
runs-on: ubuntu-latest
9+
steps:
10+
- uses: actions/checkout@v2
11+
- uses: actions/setup-node@v2
12+
with:
13+
node-version: 16.x
14+
- name: Install dependencies
15+
run: npm ci
16+
- name: Run ESLint
17+
run: npm run eslint
18+
- name: Run Prettier
19+
run: npm run prettier
20+
- name: Check types
21+
run: npm run check-types

‎.github/workflows/release-please.yml‎

Lines changed: 2 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -17,47 +17,10 @@ on:
1717

1818
jobs:
1919
e2etest:
20-
runs-on: ubuntu-latest
21-
strategy:
22-
matrix:
23-
project: [chromium, firefox, webkit]
24-
fail-fast: false
25-
steps:
26-
- uses: actions/checkout@v3
27-
- uses: actions/setup-node@v3
28-
with:
29-
node-version: 18.x
30-
- name: Install dependencies
31-
run: npm ci
32-
- name: Install Playwright
33-
run: npx playwright install --with-deps
34-
- name: Build test application
35-
run: npm run build-no-minify
36-
- name: Run E2E tests on ${{ matrix.project }}
37-
run: npx playwright test --project ${{ matrix.project }}
38-
continue-on-error: ${{ matrix.project == 'webkit' }}
39-
- name: Upload test results
40-
if: always()
41-
uses: actions/upload-artifact@v3
42-
with:
43-
name: test-results-${{ matrix.project }}
44-
path: test-results
20+
uses: NFDI4Chem/nmrium-react-wrapper/.github/workflows/e2e.yml@main
4521

4622
lint:
47-
runs-on: ubuntu-latest
48-
steps:
49-
- uses: actions/checkout@v2
50-
- uses: actions/setup-node@v2
51-
with:
52-
node-version: 16.x
53-
- name: Install dependencies
54-
run: npm ci
55-
- name: Run ESLint
56-
run: npm run eslint
57-
- name: Run Prettier
58-
run: npm run prettier
59-
- name: Check types
60-
run: npm run check-types
23+
uses: NFDI4Chem/nmrium-react-wrapper/.github/workflows/nodejs.yml@main
6124

6225
release-please:
6326
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)