Add localization for position parse error messages

Author: benwoo1110

src/main/java/org/mvplugins/multiverse/core/command/MVCommandContexts.java

@@ -116,7 +116,8 @@ private ContentFilter parseContentFilter(BukkitCommandExecutionContext context)
         }
 
         return destinationsProvider.parseDestination(context.getSender(), destination)
-                .getOrThrow(failure -> MVInvalidCommandArgument.of(failure.getFailureMessage()));
+                .getOrThrow(failure ->
+                        new InvalidCommandArgument(failure.getFailureMessage().formatted(context.getIssuer())));
     }
 
     private GameRule<?> parseGameRule(BukkitCommandExecutionContext context) {

src/main/java/org/mvplugins/multiverse/core/locale/MVCorei18n.java

@@ -346,6 +346,11 @@ public enum MVCorei18n implements MessageKeyProvider {
     EXCEPTION_MULTIVERSEWORLD_UNLOADPLAYERSINWORLD,
     EXCEPTION_MULTIVERSEWORLD_UNLOADERROR,
 
+    // multiverse position parse exception
+    EXCEPTION_POSITIONPARSE_INVALIDDIRECTION,
+    EXCEPTION_POSITIONPARSE_INVALIDCOORDINATES,
+    EXCEPTION_POSITIONPARSE_INVALIDNUMBER,
+
     // generic
     GENERIC_SUCCESS,
     GENERIC_FAILURE,

src/main/java/org/mvplugins/multiverse/core/utils/position/FaceDirection.java

@@ -3,8 +3,12 @@
 import org.bukkit.Location;
 import org.jetbrains.annotations.ApiStatus;
 import org.mvplugins.multiverse.core.exceptions.utils.position.PositionParseException;
+import org.mvplugins.multiverse.core.locale.MVCorei18n;
+import org.mvplugins.multiverse.core.locale.message.Message;
 import org.mvplugins.multiverse.core.utils.REPatterns;
 
+import static org.mvplugins.multiverse.core.locale.message.MessageReplacement.replace;
+
 /**
  * Represents a direction to face, defined by pitch and yaw.
  *
@@ -62,7 +66,8 @@ public static FaceDirection ofLocation(org.bukkit.Location location) {
     public static FaceDirection fromString(String directionStr) throws PositionParseException {
         String[] parts = REPatterns.COLON.split(directionStr, 2);
         if (parts.length != 2) {
-            throw new PositionParseException("Invalid direction string format: " + directionStr + ". Expected format: <pitch>:<yaw>");
+            throw new PositionParseException(Message.of(MVCorei18n.EXCEPTION_POSITIONPARSE_INVALIDDIRECTION,
+                    replace("{format}").with(directionStr)));
         }
         //TODO: Add support for compass directions (N, S, E, W, NE, NW, SE, SW) for yaw
         PositionNumber pitch = PositionNumber.fromString(parts[0]);

src/main/java/org/mvplugins/multiverse/core/utils/position/PositionNumber.java

@@ -3,6 +3,10 @@
 import io.vavr.control.Try;
 import org.jetbrains.annotations.ApiStatus;
 import org.mvplugins.multiverse.core.exceptions.utils.position.PositionParseException;
+import org.mvplugins.multiverse.core.locale.MVCorei18n;
+import org.mvplugins.multiverse.core.locale.message.Message;
+
+import static org.mvplugins.multiverse.core.locale.message.MessageReplacement.replace;
 
 /**
  * Represents a number that can be either absolute or relative (prefixed with '~').
@@ -65,7 +69,9 @@ static PositionNumber fromString(String string) throws PositionParseException {
 
     private static double tryParseDouble(String str) throws PositionParseException {
         return Try.of(() -> Double.parseDouble(str))
-                .getOrElseThrow(throwable -> new PositionParseException("Invalid number: " + str));
+                .getOrElseThrow(throwable -> new PositionParseException(
+                        Message.of(MVCorei18n.EXCEPTION_POSITIONPARSE_INVALIDNUMBER,
+                                replace("{number}").with(str))));
     }
 
     /**

src/main/java/org/mvplugins/multiverse/core/utils/position/VectorPosition.java

@@ -4,8 +4,12 @@
 import org.bukkit.util.Vector;
 import org.jetbrains.annotations.ApiStatus;
 import org.mvplugins.multiverse.core.exceptions.utils.position.PositionParseException;
+import org.mvplugins.multiverse.core.locale.MVCorei18n;
+import org.mvplugins.multiverse.core.locale.message.Message;
 import org.mvplugins.multiverse.core.utils.REPatterns;
 
+import static org.mvplugins.multiverse.core.locale.message.MessageReplacement.replace;
+
 /**
  * Represents an x, y, z position in 3D space, with support for absolute and relative coordinates.
  *
@@ -81,7 +85,8 @@ public static VectorPosition ofLocation(Location location) {
     public static VectorPosition fromString(String coordStr) throws PositionParseException {
         String[] parts = REPatterns.COMMA.split(coordStr);
         if (parts.length != 3) {
-            throw new PositionParseException("Invalid coordinates format: " + coordStr + ". Expected format: <x>,<y>,<z>");
+            throw new PositionParseException(Message.of(MVCorei18n.EXCEPTION_POSITIONPARSE_INVALIDCOORDINATES,
+                    replace("{format}").with(coordStr)));
         }
         return new VectorPosition(
                 PositionNumber.fromString(parts[0]),

src/main/resources/multiverse-core_en.properties

@@ -255,7 +255,7 @@ mv-core.destination.cannon.failurereason.invalidformat=&cCannon destination form
 mv-core.destination.exact.failurereason.invalidformat=&cExact destination format is: &6e:worldname:x,y,z:pitch:yaw
 mv-core.destination.player.failurereason.playernotfound=&cPlayer '&6{player}&c' does not exist or is not online!
 mv-core.destination.shared.failurereason.invalidcoordinatesformat=You must specify a valid coordinate in this format: &6{x},{y},{z}
-mv-core.destination.shared.failurereason.invalidnumberformat=&cInvalid number format. {error}
+mv-core.destination.shared.failurereason.invalidnumberformat=&cInvalid destination input. {error}
 mv-core.destination.shared.failurereason.worldnotfound=&cWorld '&6{world}&c' does not exist or is not loaded!
 mv-core.destination.parse.failurereason.invaliddestinationid=Invalid destination id: {id}. Valid destination ids are: {ids}
 
@@ -327,6 +327,11 @@ mv-core.exception.multiverseworld.unloaddefaultworld=&cYou can't unload the defa
 mv-core.exception.multiverseworld.unloadplayersinworld=&cThere are still &6{count}&c player(s) in the world! Use '&6--remove-players&c' flag to your command to teleport all players out of the world.
 mv-core.exception.multiverseworld.unloaderror=&cAn unknown error occurred while unloading world: &6{world}&c.\n&cSee console for more details.
 
+# multiverse position parse exception
+mv-core.exception.positionparse.invaliddirection=&cInvalid direction string format: {format}. Expected format: <pitch>:<yaw>
+mv-core.exception.positionparse.invalidcoordinates=&cInvalid coordinates format: {format}. Expected format: <x>,<y>,<z>
+mv-core.exception.positionparse.invalidnumber=&cInvalid number format: {number}. Expects a numeric value.
+
 # generic
 mv-core.generic.success=Success!
 mv-core.generic.failure=Failed!