Skip to content

Commit eb31d14

Browse files
committed
fix(tests): Remove drop_collection for reducing the flakiness of transaction
1 parent 187b50e commit eb31d14

2 files changed

Lines changed: 0 additions & 8 deletions

File tree

tests/asynchronous/test_context_managers.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -368,8 +368,6 @@ async def test_updating_a_document_within_a_transaction_that_fails(self):
368368
class A(Document):
369369
name = StringField()
370370

371-
await A.adrop_collection()
372-
373371
a_doc = await A.aobjects.create(name="a")
374372

375373
with pytest.raises(TestRollbackError):
@@ -386,8 +384,6 @@ async def test_creating_a_document_within_a_transaction(self):
386384
class A(Document):
387385
name = StringField()
388386

389-
await A.adrop_collection()
390-
391387
# ensure the collection is created (needed for transaction with MongoDB <= 4.2)
392388
await A.aobjects.create(name="test")
393389
await A.aobjects.delete()

tests/synchronous/test_context_managers.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -397,8 +397,6 @@ def test_updating_a_document_within_a_transaction_that_fails(self):
397397
class A(Document):
398398
name = StringField()
399399

400-
A.drop_collection()
401-
402400
a_doc = A.objects.create(name="a")
403401

404402
with pytest.raises(TestRollbackError):
@@ -415,8 +413,6 @@ def test_creating_a_document_within_a_transaction(self):
415413
class A(Document):
416414
name = StringField()
417415

418-
A.drop_collection()
419-
420416
# ensure collection is created (needed for transaction with MongoDB <= 4.2)
421417
A.objects.create(name="test")
422418
A.objects.delete()

0 commit comments

Comments
 (0)