fix(tests): fix parallel race condition

Author: abhinand-c

tests/asynchronous/test_connection.py

@@ -403,21 +403,21 @@ async def test_sharing_async_connections(self):
     async def test_async_connect_uri(self):
         """Ensure that the async_connect() method works properly with URIs."""
         c = await async_connect(db=MONGO_TEST_DB, alias="admin")
-        await c.admin.system.users.delete_many({})
-        await c.mongoenginetest.system.users.delete_many({})
+        admin_username = f"admin_{uuid.uuid4().hex[:8]}"
+        user_username = f"user_{uuid.uuid4().hex[:8]}"
 
-        await c.admin.command("createUser", "admin", pwd="password", roles=["root"])
+        await c.admin.command("createUser", admin_username, pwd="password", roles=["root"])
 
         adminadmin_settings = connection._connection_settings[
             "adminadmin"
         ] = connection._connection_settings["admin"].copy()
-        adminadmin_settings["username"] = "admin"
+        adminadmin_settings["username"] = admin_username
         adminadmin_settings["password"] = "password"
         ca = await async_connect(db=MONGO_TEST_DB, alias="adminadmin")
-        await ca.admin.command("createUser", "username", pwd="password", roles=["dbOwner"])
+        await ca.admin.command("createUser", user_username, pwd="password", roles=["dbOwner"])
 
         await async_connect(
-            "testdb_uri", host=f"mongodb://username:password@localhost/{MONGO_TEST_DB}"
+            f"{MONGO_TEST_DB}_testdb_uri", host=f"mongodb://username:password@localhost/{MONGO_TEST_DB}"
         )
 
         conn = await async_get_connection()
@@ -427,8 +427,8 @@ async def test_async_connect_uri(self):
         assert isinstance(db, AsyncDatabase)
         assert db.name == MONGO_TEST_DB
 
-        await c.admin.system.users.delete_many({})
-        await c.mongoenginetest.system.users.delete_many({})
+        await c.admin.command("dropUser", user_username)
+        await c.admin.command("dropUser", admin_username)
 
     @pytest.mark.asyncio
     async def test_async_connect_uri_without_db(self):
@@ -487,14 +487,14 @@ async def test_async_connect_uri_with_authsource(self):
         # Create users
         c = await async_connect(MONGO_TEST_DB)
 
-        await c.admin.system.users.delete_many({})
-        await c.admin.command("createUser", "username2", pwd="password", roles=["dbOwner"])
+        username = f"user_{uuid.uuid4().hex[:8]}"
+        await c.admin.command("createUser", username, pwd="password", roles=["dbOwner"])
 
         # Authentication fails without "authSource"
         test_conn = await async_connect(
             MONGO_TEST_DB,
             alias="test1",
-            host=f"mongodb://username2:password@localhost/{MONGO_TEST_DB}",
+            host=f"mongodb://{username}:password@localhost/{MONGO_TEST_DB}",
         )
         with pytest.raises(OperationFailure):
             await test_conn.server_info()
@@ -504,15 +504,15 @@ async def test_async_connect_uri_with_authsource(self):
             MONGO_TEST_DB,
             alias="test2",
             host=(
-                f"mongodb://username2:password@localhost/{MONGO_TEST_DB}?authSource=admin"
+                f"mongodb://{username}:password@localhost/{MONGO_TEST_DB}?authSource=admin"
             ),
         )
         db = await async_get_db("test2")
         assert isinstance(db, AsyncDatabase)
         assert db.name == MONGO_TEST_DB
 
         # Clear all users
-        await authd_conn.admin.system.users.delete_many({})
+        await authd_conn.admin.command("dropUser", username)
 
     @pytest.mark.asyncio
     async def test_register_async_connection(self):

tests/synchronous/fields/test_file_field.py

@@ -18,7 +18,7 @@
 except ImportError:
     HAS_PIL = False
 
-from tests.synchronous.utils import MongoDBTestCase
+from tests.synchronous.utils import MongoDBTestCase, MONGO_TEST_DB
 
 require_pil = pytest.mark.skipif(not HAS_PIL, reason="PIL not installed")
 
@@ -483,7 +483,7 @@ class TestImage(Document):
         t.image.delete()
 
     def test_file_multidb(self):
-        register_connection("test_files", "test_files")
+        register_connection("test_files", f"{MONGO_TEST_DB}_test_files")
 
         class TestFile(Document):
             name = StringField()

tests/synchronous/test_connection.py

@@ -417,21 +417,21 @@ def test_sharing_connections(self):
     def test_connect_uri(self):
         """Ensure that the connect() method works properly with URIs."""
         c = connect(db=MONGO_TEST_DB, alias="admin")
-        c.admin.system.users.delete_many({})
-        c.mongoenginetest.system.users.delete_many({})
+        admin_username = f"admin_{uuid.uuid4().hex[:8]}"
+        user_username = f"user_{uuid.uuid4().hex[:8]}"
 
-        c.admin.command("createUser", "admin", pwd="password", roles=["root"])
+        c.admin.command("createUser", admin_username, pwd="password", roles=["root"])
 
         adminadmin_settings = mongoengine.synchronous.connection._connection_settings[
             "adminadmin"
         ] = mongoengine.synchronous.connection._connection_settings["admin"].copy()
-        adminadmin_settings["username"] = "admin"
+        adminadmin_settings["username"] = admin_username
         adminadmin_settings["password"] = "password"
         ca = connect(db=MONGO_TEST_DB, alias="adminadmin")
-        ca.admin.command("createUser", "username", pwd="password", roles=["dbOwner"])
+        ca.admin.command("createUser", user_username, pwd="password", roles=["dbOwner"])
 
         connect(
-            "testdb_uri", host=f"mongodb://username:password@localhost/{MONGO_TEST_DB}"
+            f"{MONGO_TEST_DB}_uri", host=f"mongodb://username:password@localhost/{MONGO_TEST_DB}"
         )
 
         conn = get_connection()
@@ -441,8 +441,8 @@ def test_connect_uri(self):
         assert isinstance(db, pymongo.database.Database)
         assert db.name == MONGO_TEST_DB
 
-        c.admin.system.users.delete_many({})
-        c.mongoenginetest.system.users.delete_many({})
+        c.admin.command("dropUser", user_username)
+        c.admin.command("dropUser", admin_username)
 
     def test_connect_uri_without_db(self):
         """Ensure connect() method works properly if the URI doesn't
@@ -496,15 +496,15 @@ def test_connect_uri_with_authsource(self):
         """
         # Create users
         c = connect(MONGO_TEST_DB)
+        username = f"user_{uuid.uuid4().hex[:8]}"
 
-        c.admin.system.users.delete_many({})
-        c.admin.command("createUser", "username2", pwd="password", roles=["dbOwner"])
+        c.admin.command("createUser", username, pwd="password", roles=["dbOwner"])
 
         # Authentication fails without "authSource"
         test_conn = connect(
             MONGO_TEST_DB,
             alias="test1",
-            host=f"mongodb://username2:password@localhost/{MONGO_TEST_DB}",
+            host=f"mongodb://{username}:password@localhost/{MONGO_TEST_DB}",
         )
         with pytest.raises(OperationFailure):
             test_conn.server_info()
@@ -514,15 +514,15 @@ def test_connect_uri_with_authsource(self):
             MONGO_TEST_DB,
             alias="test2",
             host=(
-                f"mongodb://username2:password@localhost/{MONGO_TEST_DB}?authSource=admin"
+                f"mongodb://{username}:password@localhost/{MONGO_TEST_DB}?authSource=admin"
             ),
         )
         db = get_db("test2")
         assert isinstance(db, pymongo.database.Database)
         assert db.name == MONGO_TEST_DB
 
         # Clear all users
-        authd_conn.admin.system.users.delete_many({})
+        authd_conn.admin.command("dropUser", username)
 
     def test_register_connection(self):
         """Ensure that connections with different aliases may be registered."""