Hopefully fix the timeouts checking for updates

Signed-off-by: KiriCattus <19393068+KiriCattus@users.noreply.github.com>

Author: KiriCattus

src/commander/java/com/mcmoddev/mmdbot/commander/updatenotifiers/SharedVersionHelpers.java

@@ -37,12 +37,8 @@
 import java.net.http.HttpRequest;
 import java.net.http.HttpResponse;
 import java.nio.charset.StandardCharsets;
+import java.time.Duration;
 
-/**
- * Helper methods for the Fabric and Quilt mod loader.
- *
- * @author KiriCattus
- */
 public class SharedVersionHelpers {
 
 
@@ -58,7 +54,10 @@ public static InputStreamReader getReader(final String urlString) {
     @Nullable
     public static InputStream getStream(final String urlString) {
         try {
-            HttpClient client = HttpClient.newHttpClient();
+            HttpClient client = HttpClient.newBuilder()
+                .connectTimeout(Duration.ofSeconds(5L))
+                .followRedirects(HttpClient.Redirect.NORMAL)
+                .build();
             HttpRequest request = HttpRequest.newBuilder()
                     .uri(URI.create(urlString))
                     .build();

src/commander/java/com/mcmoddev/mmdbot/commander/updatenotifiers/forge/ForgeUpdateNotifier.java

@@ -82,16 +82,15 @@ protected EmbedBuilder getEmbed(@Nullable final MinecraftForgeVersions oldVersio
         embed.setTitle("Forge version update");
         embed.setColor(0x0000FF);
 
-        final String oldForgeVersionFull = oldVersion == null ? null : oldVersion.byMcVersion().get(mcVersion);
-        if (oldForgeVersionFull == null) {
+        final String oldForgeVersion = oldVersion == null ? null : oldVersion.byMcVersion().get(mcVersion);
+        if (oldForgeVersion == null) {
             embed.addField("Version", version, true);
         } else {
-            boolean isNoLongerBeta = isNoLongerBeta(oldForgeVersionFull, version);
-
-            embed.addField(isNoLongerBeta ? "New stable release" : "Latest", "**%s** -> **%s**".formatted(oldForgeVersionFull, version), true);
+            boolean isNoLongerBeta = isNoLongerBeta(oldForgeVersion, version);
+            embed.addField(isNoLongerBeta ? "New stable release" : "Latest", "**%s** -> **%s**".formatted(oldForgeVersion, version), true);
         }
 
-        addChangelog(embed, oldForgeVersionFull, version);
+        addChangelog(embed, oldForgeVersion, version);
 
         return embed;
     }

src/commander/java/com/mcmoddev/mmdbot/commander/updatenotifiers/neoforge/NeoForgeUpdateNotifier.java

@@ -73,14 +73,12 @@ protected EmbedBuilder getEmbed(@Nullable final NeoForgeVersions oldVersion, fin
                 .getValue();
         }
 
-        final String[] split = version.split("\\.");
-
-        final String mcVersion = "1." + split[0] + "." + split[1];
+        final String mcVersion = version.split("-")[0];
 
         final var embed = new EmbedBuilder();
         embed.addField("Minecraft Version", mcVersion, true);
         embed.setTitle("NeoForge version update");
-        embed.setColor(Color.YELLOW);
+        embed.setColor(0xFFFF00);
 
         final String oldNeoVersion = oldVersion == null ? null : oldVersion.byMcVersion().get(mcVersion);
         if (oldNeoVersion == null) {