Skip to content

Commit f80b3ef

Browse files
SimaoBolota-MetaCellSimaoBolota-MetaCell
committed
improved tests adding waitrForSelectors on missing clicks
1 parent b72b555 commit f80b3ef

8 files changed

Lines changed: 74 additions & 61 deletions

‎tests/frontend/e2e/tests/ControlPanel.test.js‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,11 @@ describe('Test for the Control Panel - color picker', () => {
111111
await control_panel_page.waitForTimeout(PAGE_WAIT * 2)
112112
await control_panel_page.waitForSelector(selectors.SELECT_CELL_BUTTON_SELECTOR, { timeout: TIMEOUT })
113113
await control_panel_page.waitForTimeout(PAGE_WAIT)
114+
await control_panel_page.waitForSelector(selectors.TUTORIALS_BUTTON_SELECTOR, { timeout: TIMEOUT })
114115
await control_panel_page.click(selectors.TUTORIALS_BUTTON_SELECTOR, { timeout: TIMEOUT })
115116

116117
console.log('Loading Tutorial #2')
117-
118+
await control_panel_page.waitForSelector(selectors.TUTORIAL_2_SELECTOR, { timeout: TIMEOUT })
118119
await control_panel_page.click(selectors.TUTORIAL_2_SELECTOR, { timeout: TIMEOUT })
119120
await control_panel_page.waitForTimeout(PAGE_WAIT)
120121
await control_panel_page.waitForSelector(selectors.PYR_2_CELL_SELECTOR)
@@ -211,7 +212,7 @@ describe('Test for the Control Panel - color picker', () => {
211212
it('Randomize Sub level E network color', async () => {
212213

213214
console.log('Randomize Sub Level E network color')
214-
215+
await control_panel_page.waitForSelector(selectors.CONTROL_PANEL_NETWORK_ROWS_SELECTOR, { timeout: TIMEOUT })
215216
const rows = await control_panel_page.$$(selectors.CONTROL_PANEL_NETWORK_ROWS_SELECTOR)
216217
for (var i = 0; i < rows.length; i++) {
217218
await rows[1].click()
@@ -254,7 +255,7 @@ describe('Test for the Control Panel - color picker', () => {
254255
it('Pick a color for the sublevel I netowrk', async () => {
255256

256257
console.log('Selecting a color for the I network')
257-
258+
await control_panel_page.waitForSelector(selectors.CONTROL_PANEL_NETWORK_ROWS_SELECTOR, { timeout: TIMEOUT })
258259
const rows = await control_panel_page.$$(selectors.CONTROL_PANEL_NETWORK_ROWS_SELECTOR)
259260
for (var i = 0; i < rows.length; i++) {
260261
await rows[1].click()
@@ -319,7 +320,7 @@ describe('Test for the Control Panel - color picker', () => {
319320
await control_panel_page.waitForTimeout(PAGE_WAIT)
320321
console.log('Filtering results')
321322

322-
await control_panel_page.waitForTimeout(selectors.CONTROL_PANEL_FILTER_SELECTOR, {timeout: PAGE_WAIT})
323+
await control_panel_page.waitForSelector(selectors.CONTROL_PANEL_FILTER_SELECTOR, {timeout: PAGE_WAIT})
323324
await control_panel_page.type(selectors.CONTROL_PANEL_FILTER_SELECTOR, 'E')
324325

325326
await control_panel_page.waitForTimeout(PAGE_WAIT)

‎tests/frontend/e2e/tests/ExperimentManager_Tut#1.test.js‎

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -161,11 +161,11 @@ describe('Experiment Manager test using Tut#1', () => {
161161

162162
await experiment_manager_page.waitForSelector(selectors.CREATE_NEW_EXPERIMENT_POPUP_SELECTOR)
163163
await experiment_manager_page.click(selectors.CONFIRM_SELECTOR)
164-
await experiment_manager_page.waitForSelector(selectors.EXPERIMENT_NAME_SELECTOR)
164+
await experiment_manager_page.waitForSelector(selectors.EXPERIMENT_NAME_SELECTOR, { timeout: TIMEOUT , visible: true})
165165

166166
await expect(experiment_manager_page).toFill(selectors.EXPERIMENT_NAME_SELECTOR, 'Test Experiment')
167167
await experiment_manager_page.waitForTimeout(PAGE_WAIT);
168-
168+
await experiment_manager_page.waitForSelector(selectors.PARAMETER_SELECTION_SELECTOR)
169169
await experiment_manager_page.click(selectors.PARAMETER_SELECTION_SELECTOR)
170170

171171

@@ -177,23 +177,23 @@ describe('Experiment Manager test using Tut#1', () => {
177177
});
178178

179179
await experiment_manager_page.waitForTimeout(PAGE_WAIT);
180-
180+
await experiment_manager_page.waitForSelector(selectors.FROM_VALUE_SELECTOR);
181181
const inputFromValue = await experiment_manager_page.$eval('#undefined-from', el => el.value);
182182
await experiment_manager_page.click(selectors.FROM_VALUE_SELECTOR);
183183
for (let i = 0; i < inputFromValue.length; i++) {
184184
await experiment_manager_page.keyboard.press('Backspace');
185185
}
186186

187187
await experiment_manager_page.type(selectors.FROM_VALUE_SELECTOR, '1')
188-
188+
await experiment_manager_page.waitForSelector(selectors.TO_VALUE_SELECTOR);
189189
const inputToValue = await experiment_manager_page.$eval('#undefined-to', el => el.value);
190190
await experiment_manager_page.click(selectors.TO_VALUE_SELECTOR);
191191
for (let i = 0; i < inputToValue.length; i++) {
192192
await experiment_manager_page.keyboard.press('Backspace');
193193
}
194194

195195
await experiment_manager_page.type(selectors.TO_VALUE_SELECTOR, '4')
196-
196+
await experiment_manager_page.waitForSelector(selectors.STEP_VALUE_SELECTOR);
197197
const inputStepValue = await experiment_manager_page.$eval('#undefined-step', el => el.value);
198198
await experiment_manager_page.click(selectors.STEP_VALUE_SELECTOR);
199199
for (let i = 0; i < inputStepValue.length; i++) {
@@ -203,7 +203,7 @@ describe('Experiment Manager test using Tut#1', () => {
203203
await experiment_manager_page.type(selectors.STEP_VALUE_SELECTOR, '1')
204204

205205
await experiment_manager_page.waitForTimeout(PAGE_WAIT);
206-
206+
await experiment_manager_page.waitForSelector(selectors.CREATE_EXPERIMENT_BUTTON_SELECTOR)
207207
await experiment_manager_page.click(selectors.CREATE_EXPERIMENT_BUTTON_SELECTOR)
208208

209209
await experiment_manager_page.waitForSelector(selectors.EXPERIMENT_TABLE_HEADER_SELECTOR)
@@ -250,7 +250,7 @@ describe('Experiment Manager test using Tut#1', () => {
250250
it('Check Experiment Condition #1', async () => {
251251

252252
console.log('Checking experiment condition #1')
253-
253+
await experiment_manager_page.waitForSelector(selectors.BACK_TO_EDIT_SELECTOR)
254254
await experiment_manager_page.click(selectors.BACK_TO_EDIT_SELECTOR)
255255

256256
await experiment_manager_page.waitForTimeout(PAGE_WAIT * 2)
@@ -333,6 +333,7 @@ describe('Experiment Manager test using Tut#1', () => {
333333
console.log('Checking experiment condition #3')
334334

335335
await experiment_manager_page.waitForTimeout(PAGE_WAIT)
336+
await experiment_manager_page.waitForSelector(selectors.BACK_TO_EDIT_SELECTOR)
336337
await experiment_manager_page.click(selectors.BACK_TO_EDIT_SELECTOR)
337338

338339
await experiment_manager_page.waitForTimeout(PAGE_WAIT * 3)
@@ -364,10 +365,11 @@ describe('Experiment Manager test using Tut#1', () => {
364365
console.log('Deleting experiment')
365366

366367
await experiment_manager_page.waitForTimeout(PAGE_WAIT)
368+
await experiment_manager_page.waitForSelector(selectors.BACK_TO_EDIT_SELECTOR)
367369
await experiment_manager_page.click(selectors.BACK_TO_EDIT_SELECTOR)
368370

369371
await experiment_manager_page.waitForTimeout(PAGE_WAIT)
370-
372+
await experiment_manager_page.waitForSelector(selectors.EDIT_EXPERIMENT_BACK_SELECTOR)
371373
await experiment_manager_page.click(selectors.EDIT_EXPERIMENT_BACK_SELECTOR)
372374

373375
await experiment_manager_page.waitForTimeout(PAGE_WAIT)

‎tests/frontend/e2e/tests/RxD.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const SNAPSHOT_OPTIONS = {
2323
ssim: 'fast',
2424
},
2525
failureThresholdType: 'percent',
26-
failureThreshold: 0.05
26+
failureThreshold: 0.5
2727
};
2828

2929

‎tests/frontend/e2e/tests/Tut#2_smoke.test.js‎

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ describe('Tutorial #2 for Smoke Testing', () => {
134134

135135
await tutorial_2_page.waitForTimeout(PAGE_WAIT * 3)
136136

137-
await tutorial_2_page.waitForSelector(selectors.THREE_D_REP_SELECTOR)
137+
await tutorial_2_page.waitForSelector(selectors.THREE_D_REP_SELECTOR, { timeout: TIMEOUT })
138138

139139
console.log('... taking snapshot ...');
140140
await tutorial_2_page.waitForTimeout(PAGE_WAIT);
@@ -143,8 +143,9 @@ describe('Tutorial #2 for Smoke Testing', () => {
143143
...SNAPSHOT_OPTIONS,
144144
customSnapshotIdentifier: 'Tutorial#2 Network'
145145
});
146-
146+
await tutorial_2_page.waitForSelector(selectors.MODEL_BUTTON_SELECTOR, { timeout: TIMEOUT });
147147
await tutorial_2_page.click(selectors.MODEL_BUTTON_SELECTOR, { timeout: TIMEOUT });
148+
await tutorial_2_page.waitForSelector(selectors.SIMULATE_NETWORK_SELECTOR, { timeout: TIMEOUT });
148149
await tutorial_2_page.click(selectors.SIMULATE_NETWORK_SELECTOR, { timeout: TIMEOUT });
149150
console.log('Simulate network')
150151

@@ -159,6 +160,7 @@ describe('Tutorial #2 for Smoke Testing', () => {
159160
it('Connections Plot', async () => {
160161

161162
await tutorial_2_page.waitForTimeout(PAGE_WAIT * 2);
163+
await tutorial_2_page.waitForSelector(selectors.CONNECTIONS_PLOT_SELECTOR, { timeout: TIMEOUT })
162164
await tutorial_2_page.click(selectors.CONNECTIONS_PLOT_SELECTOR, { timeout: TIMEOUT })
163165
await tutorial_2_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
164166
console.log('View Connections Plot ...')
@@ -174,7 +176,7 @@ describe('Tutorial #2 for Smoke Testing', () => {
174176
});
175177

176178
it('2D Net Plot', async () => {
177-
179+
await tutorial_2_page.waitForSelector(selectors.TWO_D_NET_PLOT_SELECTOR, { timeout: TIMEOUT })
178180
await tutorial_2_page.click(selectors.TWO_D_NET_PLOT_SELECTOR, { timeout: TIMEOUT })
179181
await tutorial_2_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
180182
console.log('View 2D Net Plot ...')
@@ -189,7 +191,7 @@ describe('Tutorial #2 for Smoke Testing', () => {
189191
});
190192

191193
it('Cell Traces Plot', async () => {
192-
194+
await tutorial_2_page.waitForSelector(selectors.CELL_TRACES_PLOT_SELECTOR, { timeout: TIMEOUT })
193195
await tutorial_2_page.click(selectors.CELL_TRACES_PLOT_SELECTOR, { timeout: TIMEOUT })
194196
await tutorial_2_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
195197
console.log('View Cell Traces Plot ...')
@@ -204,7 +206,7 @@ describe('Tutorial #2 for Smoke Testing', () => {
204206
});
205207

206208
it('Raster Plot', async () => {
207-
209+
await tutorial_2_page.waitForSelector(selectors.RASTER_PLOT_SELECTOR, { timeout: TIMEOUT })
208210
await tutorial_2_page.click(selectors.RASTER_PLOT_SELECTOR, { timeout: TIMEOUT })
209211
await tutorial_2_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
210212
console.log('View Raster Plot ...')
@@ -219,7 +221,7 @@ describe('Tutorial #2 for Smoke Testing', () => {
219221
});
220222

221223
it('Spike Hist Plot', async () => {
222-
224+
await tutorial_2_page.waitForSelector(selectors.SPIKE_HIST_PLOT_SELECTOR, { timeout: TIMEOUT })
223225
await tutorial_2_page.click(selectors.SPIKE_HIST_PLOT_SELECTOR, { timeout: TIMEOUT })
224226
await tutorial_2_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
225227
console.log('View Spike Hist Plot ...')
@@ -234,7 +236,7 @@ describe('Tutorial #2 for Smoke Testing', () => {
234236
});
235237

236238
it('Granger Plot', async () => {
237-
239+
await tutorial_2_page.waitForSelector(selectors.GRANGER_PLOT_SELECTOR, { timeout: TIMEOUT })
238240
await tutorial_2_page.click(selectors.GRANGER_PLOT_SELECTOR, { timeout: TIMEOUT })
239241
await tutorial_2_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
240242
console.log('View Granger Plot ...')
@@ -249,7 +251,7 @@ describe('Tutorial #2 for Smoke Testing', () => {
249251
});
250252

251253
it('Rate Spectogram Plot', async () => {
252-
await tutorial_2_page.waitForSelector(selectors.RATE_SPECTROGRAM_PLOT_SELECTOR, { visible: true })
254+
await tutorial_2_page.waitForSelector(selectors.RATE_SPECTROGRAM_PLOT_SELECTOR, { visible: true, timeout: TIMEOUT})
253255
await tutorial_2_page.click(selectors.RATE_SPECTROGRAM_PLOT_SELECTOR, { timeout: TIMEOUT })
254256
await tutorial_2_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
255257

‎tests/frontend/e2e/tests/Tut#3a_smoke.test.js‎

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ describe('Tutorial #3a for Smoke Testing', () => {
134134

135135
await tutorial_3a_page.waitForTimeout(PAGE_WAIT * 3)
136136

137-
await tutorial_3a_page.waitForSelector(selectors.THREE_D_REP_SELECTOR)
137+
await tutorial_3a_page.waitForSelector(selectors.THREE_D_REP_SELECTOR, { timeout: TIMEOUT })
138138

139139
console.log('... taking snapshot ...');
140140
await tutorial_3a_page.waitForTimeout(PAGE_WAIT);
@@ -143,8 +143,9 @@ describe('Tutorial #3a for Smoke Testing', () => {
143143
...SNAPSHOT_OPTIONS,
144144
customSnapshotIdentifier: 'Tutorial#3a Network'
145145
});
146-
146+
await tutorial_3a_page.waitForSelector(selectors.MODEL_BUTTON_SELECTOR, { timeout: TIMEOUT });
147147
await tutorial_3a_page.click(selectors.MODEL_BUTTON_SELECTOR, { timeout: TIMEOUT });
148+
await tutorial_3a_page.waitForSelector(selectors.SIMULATE_NETWORK_SELECTOR, { timeout: TIMEOUT });
148149
await tutorial_3a_page.click(selectors.SIMULATE_NETWORK_SELECTOR, { timeout: TIMEOUT });
149150

150151

@@ -161,6 +162,7 @@ describe('Tutorial #3a for Smoke Testing', () => {
161162
it('Connections Plot', async () => {
162163

163164
await tutorial_3a_page.waitForTimeout(PAGE_WAIT * 2);
165+
await tutorial_3a_page.waitForSelector(selectors.CONNECTIONS_PLOT_SELECTOR, { timeout: TIMEOUT })
164166
await tutorial_3a_page.click(selectors.CONNECTIONS_PLOT_SELECTOR, { timeout: TIMEOUT })
165167
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
166168
console.log('View Connections Plot ...')
@@ -176,7 +178,7 @@ describe('Tutorial #3a for Smoke Testing', () => {
176178
});
177179

178180
it('2D Net Plot', async () => {
179-
181+
await tutorial_3a_page.waitForSelector(selectors.TWO_D_NET_PLOT_SELECTOR, { timeout: TIMEOUT })
180182
await tutorial_3a_page.click(selectors.TWO_D_NET_PLOT_SELECTOR, { timeout: TIMEOUT })
181183
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
182184
console.log('View 2D Net Plot ...')
@@ -191,7 +193,7 @@ describe('Tutorial #3a for Smoke Testing', () => {
191193
});
192194

193195
it('Cell Traces Plot', async () => {
194-
196+
await tutorial_3a_page.waitForSelector(selectors.CELL_TRACES_PLOT_SELECTOR, { timeout: TIMEOUT })
195197
await tutorial_3a_page.click(selectors.CELL_TRACES_PLOT_SELECTOR, { timeout: TIMEOUT })
196198
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
197199
console.log('View Cell Traces Plot ...')
@@ -206,7 +208,7 @@ describe('Tutorial #3a for Smoke Testing', () => {
206208
});
207209

208210
it('Raster Plot', async () => {
209-
211+
await tutorial_3a_page.waitForSelector(selectors.RASTER_PLOT_SELECTOR, { timeout: TIMEOUT })
210212
await tutorial_3a_page.click(selectors.RASTER_PLOT_SELECTOR, { timeout: TIMEOUT })
211213
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
212214
console.log('View Raster Plot ...')
@@ -221,7 +223,7 @@ describe('Tutorial #3a for Smoke Testing', () => {
221223
});
222224

223225
it('Spike Hist Plot', async () => {
224-
226+
await tutorial_3a_page.waitForSelector(selectors.SPIKE_HIST_PLOT_SELECTOR, { timeout: TIMEOUT })
225227
await tutorial_3a_page.click(selectors.SPIKE_HIST_PLOT_SELECTOR, { timeout: TIMEOUT })
226228
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
227229
console.log('View Spike Hist Plot ...')
@@ -236,7 +238,7 @@ describe('Tutorial #3a for Smoke Testing', () => {
236238
});
237239

238240
it('LFP Time Series Plot', async () => {
239-
241+
await tutorial_3a_page.waitForSelector(selectors.LFP_TS_PLOT_SELECTOR, { timeout: TIMEOUT })
240242
await tutorial_3a_page.click(selectors.LFP_TS_PLOT_SELECTOR, { timeout: TIMEOUT })
241243
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
242244
console.log('View LFP Time Series Plot ...')
@@ -251,7 +253,7 @@ describe('Tutorial #3a for Smoke Testing', () => {
251253
});
252254

253255
it('LFP PSD Plot', async () => {
254-
256+
await tutorial_3a_page.waitForSelector(selectors.LFP_PSD_PLOT_SELECTOR, { timeout: TIMEOUT })
255257
await tutorial_3a_page.click(selectors.LFP_PSD_PLOT_SELECTOR, { timeout: TIMEOUT })
256258
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
257259
console.log('View LFP PSD Plot ...')
@@ -266,7 +268,7 @@ describe('Tutorial #3a for Smoke Testing', () => {
266268
});
267269

268270
it('LFP Spectrogram Plot', async () => {
269-
271+
await tutorial_3a_page.waitForSelector(selectors.LFP_SPECTOGRAM_PLOT_SELECTOR, { timeout: TIMEOUT })
270272
await tutorial_3a_page.click(selectors.LFP_SPECTOGRAM_PLOT_SELECTOR, { timeout: TIMEOUT })
271273
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
272274
console.log('View LFP Spectrogram Plot ...')
@@ -281,7 +283,7 @@ describe('Tutorial #3a for Smoke Testing', () => {
281283
});
282284

283285
it('Granger Plot', async () => {
284-
286+
await tutorial_3a_page.waitForSelector(selectors.GRANGER_PLOT_SELECTOR, { timeout: TIMEOUT })
285287
await tutorial_3a_page.click(selectors.GRANGER_PLOT_SELECTOR, { timeout: TIMEOUT })
286288
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
287289
console.log('View Granger Plot ...')
@@ -296,7 +298,7 @@ describe('Tutorial #3a for Smoke Testing', () => {
296298
});
297299

298300
it('RxD concentration plot', async () => {
299-
301+
await tutorial_3a_page.waitForSelector(selectors.RXD_CONCENTRATION_PLOT_SELECTOR, { timeout: TIMEOUT })
300302
await tutorial_3a_page.click(selectors.RXD_CONCENTRATION_PLOT_SELECTOR, { timeout: TIMEOUT })
301303
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
302304
console.log('View RxD concentration plot ...')
@@ -311,12 +313,12 @@ describe('Tutorial #3a for Smoke Testing', () => {
311313
});
312314

313315
it('Rate Spectogram Plot', async () => {
314-
316+
await tutorial_3a_page.waitForSelector(selectors.RATE_SPECTROGRAM_PLOT_SELECTOR, { timeout: TIMEOUT })
315317
await tutorial_3a_page.click(selectors.RATE_SPECTROGRAM_PLOT_SELECTOR, { timeout: TIMEOUT })
316318
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
317319

318320
await tutorial_3a_page.waitForTimeout(PAGE_WAIT);
319-
321+
await tutorial_3a_page.waitForSelector(selectors.CONNECTIONS_PLOT_SELECTOR, { timeout: TIMEOUT })
320322
await tutorial_3a_page.click(selectors.CONNECTIONS_PLOT_SELECTOR, { timeout: TIMEOUT })
321323
await tutorial_3a_page.waitForSelector(selectors.CANVAS_SELECTOR, { timeout: TIMEOUT })
322324

0 commit comments

Comments
 (0)