Skip to content

Commit e722c15

Browse files
author
rodriguez-facundo
committed
Use redux
1 parent e3ef6b7 commit e722c15

2 files changed

Lines changed: 14 additions & 7 deletions

File tree

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,7 @@ pygeppetto/
88
netpyne/
99
org.geppetto.frontend.jupyter/
1010
*.ipynb
11-
init.py
11+
init.py
12+
npm*
13+
.vscode
14+
app.log

netpyne_ui/netpyne_geppetto.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def instantiateNetPyNEModelInGeppetto(self, args):
5959
netpyne_model = self.instantiateNetPyNEModel()
6060
self.geppetto_model = self.model_interpreter.getGeppettoModel(netpyne_model)
6161

62-
return json.loads(GeppettoModelSerializer().serialize(self.geppetto_model))
62+
return json.loads(GeppettoModelSerializer.serialize(self.geppetto_model))
6363
except:
6464
return utils.getJSONError("Error while instantiating the NetPyNE model", sys.exc_info())
6565

@@ -185,7 +185,7 @@ def remove(dictionary):
185185
sim.loadSimData(args['jsonModelFolder'])
186186
self.geppetto_model = self.model_interpreter.getGeppettoModel(sim)
187187

188-
return json.loads(GeppettoModelSerializer().serialize(self.geppetto_model))
188+
return json.loads(GeppettoModelSerializer.serialize(self.geppetto_model))
189189
else:
190190
return utils.getJSONReply()
191191
except:
@@ -281,7 +281,7 @@ def importNeuroML(self, modelParams):
281281
sim.initialize()
282282
sim.importNeuroML2(modelParams['neuroMLFolder'], simConfig=specs.SimConfig(), simulate=False, analyze=False)
283283
self.geppetto_model = self.model_interpreter.getGeppettoModel(sim)
284-
return json.loads(GeppettoModelSerializer().serialize(self.geppetto_model))
284+
return json.loads(GeppettoModelSerializer.serialize(self.geppetto_model))
285285

286286
except:
287287
return utils.getJSONError("Error while exporting the NetPyNE model", sys.exc_info())
@@ -482,10 +482,14 @@ def deleteParam(self, model, label):
482482
else:
483483
pass
484484
else:
485-
getattr(self.netParams, model).pop(label)
485+
population = getattr(self.netParams, model).pop(label)
486486
if "popParams" in model:
487487
self.propagate_field_rename("pop", None, label)
488+
self.propagate_field_rename("cellModel", None, population['cellModel'])
489+
self.propagate_field_rename("cellType", None, population['cellType'])
490+
488491
elif "stimSourceParams" in model:
492+
489493
self.propagate_field_rename("source", None, label)
490494
elif "synMechParams" in model:
491495
self.propagate_field_rename("synMech", None, label)
@@ -596,7 +600,7 @@ def unique(label=label, old=old):
596600
for p in self.netParams.popParams:
597601
if label in self.netParams.popParams[p]:
598602
classes.append(self.netParams.popParams[p][label])
599-
if classes.count(old)>1:
603+
if classes.count(old) > 0:
600604
return False
601605
else:
602606
return True
@@ -608,7 +612,7 @@ def unique(label=label, old=old):
608612
self.propagate_syn_mech_rename(new, old)
609613
return True
610614
else:
611-
if unique():
615+
if unique():
612616
for (model, cond) in [['cellParams','conds'], ['connParams', 'preConds'], ['connParams', 'postConds'], ['stimTargetParams', 'conds'], ['analysis', 'include'] ]:
613617
self.propagate(model, label, cond, new, old)
614618
return True

0 commit comments

Comments
 (0)