Skip to content

Commit ce639e2

Browse files
committed
#292 #277 small cleaning
1 parent 8074ee4 commit ce639e2

4 files changed

Lines changed: 6 additions & 7 deletions

File tree

Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,5 @@ RUN python install.py ${BUILD_ARGS}
2929
WORKDIR ${INSTALLATION_FOLDER}
3030

3131
RUN pip install -r requirements-test.txt
32-
RUN pip install -e .
3332
RUN pytest tests/backend
3433
CMD /bin/bash -c "jupyter notebook --NotebookApp.default_url=/geppetto --NotebookApp.token='' --library=netpyne_ui --NotebookApp.disable_check_xsrf=True"

netpyne_ui/mod_utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import shutil
12
import subprocess
23
import os
34

@@ -30,7 +31,8 @@ def compileModMechFiles(compileMod, modFolder):
3031
if compileMod:
3132
modPath = os.path.join(str(modFolder), "x86_64")
3233

33-
subprocess.call(["rm", "-r", modPath])
34+
if os.path.exists(modPath):
35+
shutil.rmtree(modPath)
3436

3537
os.chdir(modFolder)
3638
subprocess.call(["nrnivmodl"])

netpyne_ui/netpyne_geppetto.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626
from netpyne_ui.constants import NETPYNE_WORKDIR_PATH, NUM_CONN_LIMIT
2727
from netpyne_ui.mod_utils import compileModMechFiles
2828

29-
3029
os.chdir(NETPYNE_WORKDIR_PATH)
3130

32-
neuron.nrn_dll_loaded.append(os.path.join(NETPYNE_WORKDIR_PATH, 'mod')) # Avoids to load workspace modfiles twice
31+
neuron.nrn_dll_loaded.append(os.path.join(NETPYNE_WORKDIR_PATH, 'mod')) # Avoids to load workspace modfiles twice
32+
3333

3434
class NetPyNEGeppetto:
3535

@@ -117,8 +117,6 @@ def simulateNetPyNEModelInGeppetto(self, args):
117117
except:
118118
return utils.getJSONError("Error while simulating the NetPyNE model", sys.exc_info())
119119

120-
121-
122120
def loadModel(self, args):
123121
""" Imports a model stored as file in json format.
124122

utilities/install.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ def main(netpyne_branch, workspace_branch, pygeppetto_branch=None, jupyter_geppe
105105
else:
106106
# install requirements
107107
cprint("Installing UI python package...")
108-
execute(cmd=['pip', 'install', '.', '--no-deps'], cwd=ROOT_DIR)
108+
execute(cmd=['pip', 'install', '-e', '.', '--no-deps'], cwd=ROOT_DIR)
109109

110110
os.chdir(ROOT_DIR)
111111
cprint("Cloning workspace")

0 commit comments

Comments
 (0)