Merge pull request #438 from MetaCell/feature/381-error-dialog-management

Feature/381 error dialog management

Author: filippomc

netpyne_ui/netpyne_geppetto.py

@@ -14,6 +14,7 @@
 from shutil import copyfile
 from dacite import from_dict
 import base64
+import jsonpickle
 
 import neuron
 import numpy as np
@@ -266,6 +267,7 @@ def simulateNetPyNEModelInGeppetto(self, args):
         """
         allTrials = args.get('allTrials', True)
         use_prev_inst = args.get('usePrevInst', False)
+        sim_id = args.get('simId', 0)
 
         try:
             experiment = experiments.get_current()
@@ -289,17 +291,17 @@ def simulateNetPyNEModelInGeppetto(self, args):
                         return self.simulate_single_model(experiment, use_prev_inst)
                 except Exception:
                     experiment.state = model.ExperimentState.ERROR
-                    message = "Unknown error during simulation of Experiment"
+                    message = ("Unknown error during simulation of Experiment. SimulationId %i" % sim_id)
                     logging.exception(message)
-                    return utils.getJSONError("Unknown error during simulation of Experiment", sys.exc_info())
+                    return utils.getJSONError("Unknown error during simulation of Experiment", sys.exc_info(), { "sim_id": sim_id})
 
             else:
                 return self.simulate_single_model(use_prev_inst=use_prev_inst)
 
-        except Exception:
-            message = "Error while simulating the NetPyNE model"
+        except Exception as e :
+            message = ("Error while simulating the NetPyNE model: %s. SimulationId %f" % (e, sim_id))
             logging.exception(message)
-            return utils.getJSONError(message, sys.exc_info())
+            return utils.getJSONError(message, sys.exc_info(), { "sim_id": sim_id})
 
     def _prepare_simulation_files(self, experiment: model.Experiment = None, use_prev_inst: bool = False) -> str:
         """Prepares template files and netpyne model files for a single simulation """
@@ -647,6 +649,8 @@ def instantiateNetPyNEModel(self):
             saveData = sim.allSimData if hasattr(sim, 'allSimData') and 'spkt' in sim.allSimData.keys() and len(
                 sim.allSimData['spkt']) > 0 else False
 
+            #netcoded = jsonpickle.encode(self.netParams, unpicklable=False)
+            #simcoded = jsonpickle.encode(self.simConfig, unpicklable=False)
             sim.create(self.netParams, self.simConfig)
             sim.net.defineCellShapes()  # creates 3d pt for cells with stylized geometries
             sim.gatherData(gatherLFP=False)

webapp/Utils.js

@@ -195,6 +195,9 @@ const Utils = {
       } else if (Object.prototype.hasOwnProperty.call(parsedData, 'websocket')) {
         error.message = parsedData.websocket;
       }
+      if (Object.prototype.hasOwnProperty.call(parsedData, 'additional_info')) {
+        error.additionalInfo = parsedData.additional_info ;
+      }
       return error;
     }
     return null;

webapp/redux/middleware/middleware.js

@@ -39,6 +39,7 @@ export const processError = (response) => {
     return {
       errorMessage: parsedResponse.message,
       errorDetails: parsedResponse.details,
+      additionalInfo: parsedResponse.additionalInfo
     };
   }
   return false;
@@ -106,6 +107,26 @@ const simulateNetwork = (payload) => createSimulateBackendCall(
   GEPPETTO.Resources.RUNNING_SIMULATION,
 );
 
+class PythonMessageFilter {
+  errorIds = new Set();
+  shouldLaunch(e) {    
+    const errorId = e.additionalInfo?.sim_id ;
+    if (!errorId)
+      return true ;
+    if (errorId)
+    {
+      if(this.errorIds.has(errorId))
+        return false ;
+      else {
+        this.errorIds.add(errorId);
+        return true ;
+      }
+    }
+  }
+}
+
+const errorMessageFilter = new PythonMessageFilter();
+
 export default (store) => (next) => (action) => {
   const switchLayoutAction = (edit = true, reset = true) => {
     previousLayout[store.getState().general.editMode ? 'edit' : 'network'] = store.getState().layout;
@@ -129,7 +150,10 @@ export default (store) => (next) => (action) => {
 
   const pythonErrorCallback = (error) => {
     console.debug(Utils.getPlainStackTrace(error.errorDetails));
-    return next(openBackendErrorDialog(error));
+    if (errorMessageFilter.shouldLaunch(error))
+      return next(openBackendErrorDialog(error));
+    else  
+      return next(action);
   };
 
   switch (action.type) {
@@ -166,12 +190,14 @@ export default (store) => (next) => (action) => {
       break;
     }
     case CREATE_SIMULATE_NETWORK: {
-      simulateNetwork({ allTrials: false })
+      const payload = { allTrials: false, simId: new Date().getTime() }
+      simulateNetwork(payload)
         .then(toNetworkCallback(false), pythonErrorCallback);
       break;
     }
     case SIMULATE_NETWORK:
-      simulateNetwork({ allTrials: action.payload, usePrevInst: false })
+      const payload = { allTrials: action.payload, simId: new Date().getTime(), usePrevInst: false }
+      simulateNetwork(payload)
         .then(toNetworkCallback(false), pythonErrorCallback);
       break;
     case PYTHON_CALL: {