Skip to content

Commit ac49fbe

Browse files
author
Lucas Rebscher
committed
#263 Update todo
1 parent 0442dda commit ac49fbe

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

netpyne_ui/netpyne_geppetto.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ def simulateNetPyNEModelInGeppetto(self, args):
103103
else:
104104
logging.info("Starting simulation")
105105

106-
# TODO: (#263) we should instantiate the network here per default
107-
# or we need a mechanism to detect if the currently instantiated network matches with
108-
# the current net params and simConfig, otherwise this can cause errors
109106
if not args.get('usePrevInst', False):
110107
logging.debug('Instantiating single thread simulation')
111108
netpyne_model = self.instantiateNetPyNEModel()

webapp/components/topbar/menuConfiguration.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,8 @@ export const getModelMenu = (props) => (
325325
label: TOPBAR_CONSTANTS.SIMULATE,
326326
action: {
327327
handlerAction: 'redux',
328+
// TODO: (#263) this logic causes issues by potentially simulating
329+
// old instance with modified netParams and simConfig
328330
parameters: [props.modelState === MODEL_STATE.NOT_INSTANTIATED ? createAndSimulateNetwork : simulateNetwork],
329331
},
330332
},

0 commit comments

Comments
 (0)