#389 Set experiment parameters, fetch param on create, simulate, create&simulate and test with indesign experiment

Author: vidhyalongani

webapp/components/experiments/ExperimentEdit.js

@@ -26,7 +26,8 @@ import ParameterMenu from './ParameterMenu';
 import useStyles from './ExperimentEditStyle';
 import * as ExperimentHelper from './ExperimentHelper';
 import DialogBox from '../general/DialogBox';
-
+// import { useDispatch } from 'react-redux';
+// import { setExperimentParameters } from 'root/redux/actions/experiments';
 const RANGE_VALUE = 0;
 const SUPPORTED_TYPES = [REAL_TYPE.INT, REAL_TYPE.FLOAT, REAL_TYPE.STR, REAL_TYPE.BOOL];
 const MAX_TRIALS = 100;
@@ -198,7 +199,7 @@ const ExperimentEdit = (props) => {
   const experiments = useSelector((state) => state.experiments.experiments);
 
   let numberOfTrials = 1;
-
+  // const dispatch = useDispatch();
   const validateParameter = (param) => {
     let updatedParam = param;
     if (param.type === LIST) {
@@ -267,6 +268,9 @@ const ExperimentEdit = (props) => {
         });
 
         console.debug(`Size before ${paramKeys.length}, after: ${filteredKeys.length}`);
+        // dispatch(setExperimentParameters({
+        //   parameters: filteredKeys,
+        // }));
         setSelectionParams(filteredKeys);
       });
   };

webapp/redux/actions/experiments.js

@@ -5,6 +5,7 @@ export const VIEW_EXPERIMENTS_RESULTS = 'VIEW_EXPERIMENT_RESULTS';
 export const TRIAL_LOAD_MODEL_SPEC = 'TRIAL_LOAD_MODEL_SPEC';
 export const OPEN_LAUNCH_DIALOG = 'OPEN_LAUNCH_DIALOG';
 export const CLOSE_LAUNCH_DIALOG = 'CLOSE_LAUNCH_DIALOG';
+export const SET_EXPERIMENT_PARAMETERS = 'SET_EXPERIMENT_PARAMETERS';
 
 /**
  * Triggers fetching the Experiments from the backend.
@@ -21,6 +22,14 @@ export const setExperiments = (payload) => ({
   payload,
 });
 
+/**
+ * Set fetched experiments.
+ */
+ export const setExperimentParameters = (payload) => ({
+  type: SET_EXPERIMENT_PARAMETERS,
+  payload,
+});
+
 /**
  * View results of selected experiment/trial.
  */

webapp/redux/middleware/middleware.js

@@ -26,7 +26,9 @@ import { closeDrawerDialogBox } from '../actions/drawer';
 import Utils from '../../Utils';
 import { downloadJsonResponse, downloadPythonResponse } from './utils';
 import * as Constants from '../../constants';
-
+import * as ExperimentsApi from 'root/api/experiments';
+import { setExperimentParameters } from 'root/redux/actions/experiments';
+const SUPPORTED_TYPES = [Constants.REAL_TYPE.INT, Constants.REAL_TYPE.FLOAT, Constants.REAL_TYPE.STR, Constants.REAL_TYPE.BOOL];
 let previousLayout = {
   edit: undefined,
   network: undefined,
@@ -161,18 +163,90 @@ export default (store) => (next) => (action) => {
       break;
     }
     case CREATE_NETWORK: {
-      instantiateNetwork({})
-        .then(toNetworkCallback(false), pythonErrorCallback);
+      ExperimentsApi.getParameters()
+      .then((params) => {
+        const flattened = Utils.flatten(params);
+        const paramKeys = Object.keys(flattened);
+
+        const filteredKeys = paramKeys.filter((key) => {
+          // TODO: avoid to fetch field twice!
+          const field = Utils.getMetadataField(`netParams.${key}`);
+          if (field && SUPPORTED_TYPES.includes(field.type)) {
+            return true;
+          }
+          return false;
+        });
+        next(setExperimentParameters({
+          parameters: filteredKeys,
+        }));
+        const expData = store.getState().experiments;
+        expData?.inDesign?.params?.map((param) => {
+          if(filteredKeys.includes(param.mapsTo)) {
+            instantiateNetwork({})
+            .then(toNetworkCallback(false), pythonErrorCallback);
+          } else {
+            pythonErrorCallback({errorDetails: 'Missing Parameters', errorMessage: 'Error'})
+          }
+        })
+      });
       break;
     }
     case CREATE_SIMULATE_NETWORK: {
-      simulateNetwork({ allTrials: false })
-        .then(toNetworkCallback(false), pythonErrorCallback);
+      ExperimentsApi.getParameters()
+      .then((params) => {
+        const flattened = Utils.flatten(params);
+        const paramKeys = Object.keys(flattened);
+
+        const filteredKeys = paramKeys.filter((key) => {
+          // TODO: avoid to fetch field twice!
+          const field = Utils.getMetadataField(`netParams.${key}`);
+          if (field && SUPPORTED_TYPES.includes(field.type)) {
+            return true;
+          }
+          return false;
+        });
+        next(setExperimentParameters({
+          parameters: filteredKeys,
+        }));
+        const expData = store.getState().experiments;
+        expData?.inDesign?.params?.map((param) => {
+          if(filteredKeys.includes(param.mapsTo)) {
+            simulateNetwork({ allTrials: false })
+            .then(toNetworkCallback(false), pythonErrorCallback);
+          } else {
+            pythonErrorCallback({errorDetails: 'Missing Parameters', errorMessage: 'Error'})
+          }
+        })
+      });
       break;
     }
     case SIMULATE_NETWORK:
-      simulateNetwork({ allTrials: action.payload, usePrevInst: false })
-        .then(toNetworkCallback(false), pythonErrorCallback);
+      ExperimentsApi.getParameters()
+      .then((params) => {
+        const flattened = Utils.flatten(params);
+        const paramKeys = Object.keys(flattened);
+
+        const filteredKeys = paramKeys.filter((key) => {
+          // TODO: avoid to fetch field twice!
+          const field = Utils.getMetadataField(`netParams.${key}`);
+          if (field && SUPPORTED_TYPES.includes(field.type)) {
+            return true;
+          }
+          return false;
+        });
+        next(setExperimentParameters({
+          parameters: filteredKeys,
+        }));
+        const expData = store.getState().experiments;
+        expData?.inDesign?.params?.map((param) => {
+          if(filteredKeys.includes(param.mapsTo)) {
+            simulateNetwork({ allTrials: action.payload, usePrevInst: false })
+            .then(toNetworkCallback(false), pythonErrorCallback);
+          } else {
+            pythonErrorCallback({errorDetails: 'Missing Parameters', errorMessage: 'Error'})
+          }
+        })
+      });
       break;
     case PYTHON_CALL: {
       const callback = (response) => {

webapp/redux/reducers/experiments.js

@@ -3,13 +3,15 @@ import {
   OPEN_LAUNCH_DIALOG,
   SET_EXPERIMENTS,
   CLOSE_LAUNCH_DIALOG,
+  SET_EXPERIMENT_PARAMETERS,
 } from 'root/redux/actions/experiments';
 import { EXPERIMENT_STATE } from 'root/constants';
 
 export const EXPERIMENTS_DEFAULT_STATE = {
   experiments: [],
   inDesign: null,
   openLaunchDialog: false,
+  experimentParams: [],
 };
 
 export default (state = EXPERIMENTS_DEFAULT_STATE, action) => {
@@ -20,6 +22,11 @@ export default (state = EXPERIMENTS_DEFAULT_STATE, action) => {
         experiments: action.payload,
         inDesign: action.payload.find((el) => el.state === EXPERIMENT_STATE.DESIGN),
       };
+    case SET_EXPERIMENT_PARAMETERS:
+      return {
+        ...state,
+        experimentParams: action.payload?.parameters,
+      };
     case OPEN_LAUNCH_DIALOG:
       return {
         ...state,