Skip to content

Commit 9bd92f0

Browse files
authored
Merge pull request #550 from MetaCell/feature/447_final
Feature/447 final
2 parents f833681 + 60cb280 commit 9bd92f0

13 files changed

Lines changed: 367 additions & 239 deletions

File tree

Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ RUN npm install --global yarn
3232
RUN npm install --global yalc
3333
RUN python install.py ${BUILD_ARGS} --geppetto ${GEPPETTO_VERSION}
3434

35+
# Temp fixes for eeg plots
36+
RUN wget -P `pip show LFPykit | grep "Location:" | awk '{print $2"/lfpykit"}'` https://www.parralab.org/nyhead/sa_nyhead.mat
37+
3538
WORKDIR ${INSTALLATION_FOLDER}
3639

3740
RUN pip install -r requirements-test.txt

netpyne_ui/netpyne_geppetto.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -824,7 +824,7 @@ def getAvailableCellTypes(self):
824824
def getAvailableRxDSections(self, selectedRegion):
825825
sections = set([])
826826
sections.add('all')
827-
if self.netParams.rxdParams.regions[selectedRegion].get('cells'):
827+
if selectedRegion in self.netParams.rxdParams.regions and self.netParams.rxdParams.regions[selectedRegion].get('cells'):
828828
if 'all' in self.netParams.rxdParams.regions[selectedRegion]['cells']:
829829
for cellRule in self.netParams.cellParams:
830830
for cellSect in self.netParams.cellParams[cellRule]['secs']:

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ defusedxml==0.6.0
1515
Deprecated==1.2.10
1616
entrypoints==0.3
1717
future==0.18.2
18+
h5py==3.7.0
1819
idna==2.9
1920
ipython-genutils==0.2.0
2021
ipywidgets==7.5.1

webapp/components/experiments/ExperimentEdit.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -480,8 +480,9 @@ const ExperimentEdit = (props) => {
480480
};
481481

482482
const setExperimentNameInfo = (val) => {
483-
validateExperimentName(val);
484-
setExperimentName(val);
483+
const name = val.replace(' ', '_');
484+
validateExperimentName(name);
485+
setExperimentName(name);
485486
};
486487

487488
return (

webapp/components/general/List.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,12 +293,14 @@ class ListComponent extends Component {
293293
<Box display="flex" alignItems="center" className={classes.addIcon}>
294294
<IconButton
295295
id={`${this.props.id}-button`}
296+
disabled={this.props.disabled}
296297
>
297298
<Add onClick={this.addChild} />
298299
</IconButton>
299300
</Box>
300301
<TextField
301302
variant="filled"
303+
disabled={this.props.disabled}
302304
id={this.props.id}
303305
label={
304306
this.props.label ? `Add new ${this.props.label}` : 'Add new item'

webapp/components/rxd/Rxd.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ const styles = ((theme) => ({
7878
},
7979
'& .MuiTabs-scroller': {
8080
borderBottom: `0.0625rem solid ${navShadow}`,
81-
}
81+
},
8282
},
8383

8484
button: {
@@ -276,6 +276,7 @@ class Rxd extends React.Component {
276276
<RxdRegions
277277
onAddRegion={this.onAddRegion}
278278
regions={controlledState?.checked?.regions}
279+
extracellular={controlledState?.checked?.extracellular}
279280
/>
280281
);
281282
} else if (value === 1) {
@@ -324,6 +325,7 @@ class Rxd extends React.Component {
324325
tabPanelContent = (
325326
<RxdExtracellulars
326327
onAddExtracellular={this.onAddExtracellular}
328+
regions={controlledState?.checked?.regions}
327329
extracellular={controlledState?.checked?.extracellular}
328330
/>
329331
);

webapp/components/rxd/RxdConstants.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,6 @@ import AddIcon from '@material-ui/icons/Add';
1616
import FontIcon from '@material-ui/core/Icon';
1717
import Utils from '../../Utils';
1818
import {
19-
bgDarkest,
20-
bgLight,
21-
bgRegular,
22-
secondaryColor,
23-
fontColor,
24-
radius,
25-
primaryColor,
26-
experimentInputColor,
27-
experimentFieldColor,
28-
experimentSvgColor,
29-
experimentLabelColor,
30-
experimentAutocompleteBorder,
31-
errorFieldBorder,
3219
tabsTextColor,
3320
} from '../../theme';
3421

webapp/components/rxd/RxdExtracellular.js

Lines changed: 0 additions & 107 deletions
This file was deleted.

0 commit comments

Comments
 (0)