Skip to content

Commit 52cdeaa

Browse files
committed
Change experiment edit textfield numbers format
1 parent 3c85b0d commit 52cdeaa

4 files changed

Lines changed: 24 additions & 10 deletions

File tree

sa_nyhead.mat

Whitespace-only changes.

webapp/components/experiments/ExperimentEdit.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ const ParameterRow = (parameter, index, handleParamSelection, handleChange, hand
102102
id={`${parameter.name}-from`}
103103
label="From"
104104
variant="filled"
105-
type="number"
105+
type="text" inputMode="numeric"
106106
value={parameter?.minVal || parameter?.min}
107-
onChange={(e) => handleRangeInput(e.target.value, index, parameter, 'min')}
107+
onChange={(e) => handleRangeInput(e.target, index, parameter, 'min')}
108108
error={parameter?.minerror}
109109
helperText={parameter?.minhelperText}
110110
autoComplete="off"
@@ -115,9 +115,9 @@ const ParameterRow = (parameter, index, handleParamSelection, handleChange, hand
115115
id={`${parameter.name}-to`}
116116
label="To"
117117
variant="filled"
118-
type="number"
118+
type="text" inputMode="numeric"
119119
value={parameter?.maxVal || parameter?.max}
120-
onChange={(e) => handleRangeInput(e.target.value, index, parameter, 'max')}
120+
onChange={(e) => handleRangeInput(e.target, index, parameter, 'max')}
121121
error={parameter?.maxerror}
122122
helperText={parameter?.maxhelperText}
123123
autoComplete="off"
@@ -128,9 +128,8 @@ const ParameterRow = (parameter, index, handleParamSelection, handleChange, hand
128128
id={`${parameter.name}-step`}
129129
label="Step"
130130
variant="filled"
131-
type="number"
132-
value={parameter?.stepVal || parameter?.step}
133-
onChange={(e) => handleRangeInput(e.target.value, index, parameter, 'step')}
131+
type="text" inputMode="numeric"
132+
onChange={(e) => handleRangeInput(e.target, index, parameter, 'step')}
134133
error={parameter?.steperror}
135134
helperText={parameter?.stephelperText}
136135
autoComplete="off"
@@ -463,10 +462,12 @@ const ExperimentEdit = (props) => {
463462
setGroupParameters(newGroupParams);
464463
};
465464

466-
const handleRangeInput = (val, index, parameter, key) => {
465+
const handleRangeInput = (input, index, parameter, key) => {
466+
const val = input.value ;
467467
const newParameters = parameter.inGroup ? [...groupParameters] : [...parameters];
468468
newParameters[index] = ExperimentHelper.validateRangeParameter(parameter, val, key);
469469
setParamChange(parameter.inGroup, newParameters);
470+
input.value = val ;
470471
};
471472

472473
const handleInputValues = (val, index, parameter) => {

webapp/components/experiments/ExperimentHelper.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,26 @@ export const convertFieldValue = (field, value) => {
2424
case REAL_TYPE.BOOL:
2525
return Boolean(value);
2626

27+
case REAL_TYPE_FLOAT:
28+
return validLocale(value);
29+
2730
default:
2831
// .. handling of more types
2932
// list(float), dict, list(list(float)), func
3033
return value;
3134
}
3235
};
3336

37+
function getLocale() {
38+
if (navigator.languages != undefined)
39+
return navigator.languages[0];
40+
return navigator.language;
41+
}
42+
function validLocale(num) {
43+
const locale = getLocale();
44+
return Intl.NumberFormat(locale).format(num);
45+
}
46+
3447
export const isValidValue = (value, type) => {
3548
if (type == null) {
3649
return false;

webapp/components/general/Dialog.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ const AboutContent = withStyles(styles)(({ classes }) => (
2626
<img width="250" src={logoNetpyne} />
2727
<Box m={1}>
2828
<Link variant="h5" style={{ display: 'block' }} href="https://github.com/MetaCell/NetPyNE-UI" target="_blank">
29-
NetPyNE-UI v0.9.0
29+
NetPyNE-UI v0.9.1
3030
</Link>
3131
<Link variant="h5" style={{ display: 'block' }} href="https://github.com/Neurosim-lab/netpyne" target="_blank">
32-
NetPyNE v1.0.3
32+
NetPyNE v1.0.3.1
3333
</Link>
3434
<Link variant="h5" style={{ display: 'block' }} href="https://www.neuron.yale.edu/neuron/" target="_blank">
3535
NEURON v8.0.2

0 commit comments

Comments
 (0)