Skip to content

Commit 468d740

Browse files
authored
Merge branch 'release/1.0.0' into feature/netpyne-99
2 parents 480450f + fe6a399 commit 468d740

4 files changed

Lines changed: 12 additions & 13 deletions

File tree

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ RUN jupyter nbextension enable --py --sys-prefix jupyter_geppetto
4646
RUN jupyter nbextension enable --py --sys-prefix widgetsnbextension
4747
RUN jupyter serverextension enable --py --sys-prefix jupyter_geppetto
4848

49-
RUN python utilities/install.py ${BUILD_ARGS} --geppetto ${GEPPETTO_VERSION} --netpyne $NETPYNE_VERSION --workspace WORKSPACE_VERSION --npm-skip
49+
RUN python utilities/install.py ${BUILD_ARGS} --geppetto ${GEPPETTO_VERSION} --workspace WORKSPACE_VERSION --npm-skip
5050

5151
RUN jupyter labextension disable @jupyterlab/hub-extension
5252

netpyne_ui/netpyne_geppetto.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ def _create3D_shapes(self, json_path: str):
513513
sim.loadSimData(json_path)
514514

515515
def loadFromIndexFile(self, json_path: str):
516-
cfg, netParams = sim.loadFromIndexFile(json_path)
516+
cfg, netParams = sim.loadModel(json_path, loadMechs=True, ignoreMechAlreadyExistsError=True)
517517
self.simConfig = cfg
518518
self.netParams = netParams
519519

@@ -539,7 +539,6 @@ def saveToIndexFile(self, srcPath, dstPath, exportNetParamsAsPython, exportSimCo
539539
exportNetParamsAsPython=exportNetParamsAsPython,
540540
exportSimConfigAsPython=exportSimConfigAsPython)
541541

542-
543542
def importModel(self, modelParameters):
544543
""" Imports a model stored in form of Python files.
545544
@@ -602,7 +601,7 @@ def importModel(self, modelParameters):
602601

603602
def importNeuroML(self, modelParameters):
604603
from netpyne_ui.helpers import neuroml
605-
604+
606605

607606
try:
608607
# Get Current dir
@@ -611,9 +610,9 @@ def importNeuroML(self, modelParameters):
611610
with redirect_stdout(sys.__stdout__):
612611
# NetParams
613612
filename = str(modelParameters["fileName"])
614-
613+
615614
json_fname = neuroml.convertNeuroML2(filename, compileMod=modelParameters["compileMod"])
616-
615+
617616
return self.loadModel(args=dict(
618617
compileMod=True,
619618
modFolder=os.path.dirname(json_fname),
@@ -632,7 +631,7 @@ def importNeuroML(self, modelParameters):
632631

633632
def importLEMS(self, modelParameters):
634633
from netpyne_ui.helpers import neuroml
635-
634+
636635

637636
try:
638637
# Get Current dir
@@ -641,7 +640,7 @@ def importLEMS(self, modelParameters):
641640
with redirect_stdout(sys.__stdout__):
642641
# NetParams
643642
filename = str(modelParameters["fileName"])
644-
643+
645644
json_fname = neuroml.convertLEMSSimulation(filename)
646645

647646
return self.loadModel(args=dict(

webapp/components/general/PythonControlledCapability.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,15 +105,15 @@ define((require) => {
105105

106106
componentDidMount () {
107107
super.componentDidMount();
108-
this.UNRELIABLE_SyncDefaultValueWithPython();
108+
this.UNRELIABLE_SyncDefaultValueWithPython(100);
109109
}
110110

111111
/*
112112
* since we don't know when a component will be synched with python,
113113
* we can't know when to check if this.state.value should be replaced
114114
* with this.props.default
115115
*/
116-
UNRELIABLE_SyncDefaultValueWithPython (timeInterval = 600, attemps = 0) {
116+
UNRELIABLE_SyncDefaultValueWithPython (timeInterval = 60000, attemps = 0) {
117117
if (attemps < 3) {
118118
setTimeout(() => {
119119
if (this.props.default && this.state.value === '') {
@@ -185,7 +185,7 @@ define((require) => {
185185
&& this.state.value === ''
186186
&& this.props.default
187187
) {
188-
this.UNRELIABLE_SyncDefaultValueWithPython(1000);
188+
this.UNRELIABLE_SyncDefaultValueWithPython(100);
189189
}
190190
}
191191

webapp/components/topbar/Topbar.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ import ImportExportHLSDialog from './dialogs/ImportExportHLS';
2323
import ImportCellParamsDialog from './dialogs/ImportCellParams';
2424
import UploadDownloadFilesDialog from './dialogs/UploadDownloadFiles';
2525

26-
import { TOPBAR_CONSTANTS, MODEL_STATE, DEFAULT_CONFIRMATION_DIALOG_MESSAGE, NETPYNE_COMMANDS } from '../../constants';
27-
import { LOAD_TUTORIAL, loadModel } from '../../redux/actions/general';
26+
import { TOPBAR_CONSTANTS, MODEL_STATE, DEFAULT_CONFIRMATION_DIALOG_MESSAGE, NETPYNE_COMMANDS } from '../../constants';
27+
import { LOAD_TUTORIAL, registerModelPath, loadModel } from '../../redux/actions/general';
2828
import OverwriteModel from './dialogs/OverwriteModel';
2929

3030
const styles = () => ({

0 commit comments

Comments
 (0)