Skip to content

Commit 34dd1ab

Browse files
netpyne-101 improved selectors
1 parent 245db1c commit 34dd1ab

2 files changed

Lines changed: 9 additions & 18 deletions

File tree

tests/frontend/e2e/tests/ControlPanel.test.js

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ describe('Test for the Control Panel - color picker', () => {
6060

6161
await page.on("dialog", dialog =>
6262
dialog.accept());
63-
63+
6464
await page.waitForSelector(selectors.SELECT_CELL_BUTTON_SELECTOR, { timeout: TIMEOUT, visible: true })
6565
await page.waitForSelector(selectors.FILE_TAB_SELECTOR, { timeout: PAGE_WAIT * 30 })
6666
await page.waitForTimeout(PAGE_WAIT)
@@ -78,7 +78,6 @@ describe('Test for the Control Panel - color picker', () => {
7878
return el == null || el.clientHeight === 0;
7979
}, { timeout: TIMEOUT });
8080

81-
8281
await page.waitForSelector(selectors.SELECT_CELL_BUTTON_SELECTOR, { timeout: TIMEOUT * 10 })
8382

8483
console.log('Page opened successfully')
@@ -93,16 +92,15 @@ describe('Test for the Control Panel - color picker', () => {
9392
await page.click(selectors.TUTORIALS_BUTTON_SELECTOR, { timeout: TIMEOUT })
9493

9594
console.log('Loading Tutorial #2')
95+
9696
await page.click(selectors.TUTORIAL_2_SELECTOR, { timeout: TIMEOUT })
9797
await page.waitForTimeout(PAGE_WAIT)
98-
9998
await page.waitForSelector(selectors.PYR_2_CELL_SELECTOR)
10099
await page.waitForSelector(selectors.INT_CELL_SELECTOR)
101100
await page.waitForTimeout(PAGE_WAIT)
102101

103102
console.log('Tutorial #2 loaded successfully')
104103

105-
106104
})
107105

108106

@@ -135,9 +133,7 @@ describe('Test for the Control Panel - color picker', () => {
135133
console.log('Opening Control Panel')
136134

137135
await page.waitForSelector(selectors.CONTROL_PANEL_TAB_SELECTOR)
138-
139136
await page.click(selectors.CONTROL_PANEL_TAB_SELECTOR)
140-
141137
await page.waitForSelector(selectors.NETWORKS_IN_CONTROL_PANEL_SELECTOR)
142138

143139
const network_items = (await page.$$(selectors.NETWORK_ITEMS_CONTROL_PANEL_SELECTOR)).length;
@@ -152,10 +148,8 @@ describe('Test for the Control Panel - color picker', () => {
152148
console.log('Randomize Main Level network color')
153149

154150
await page.waitForTimeout(PAGE_WAIT * 3)
155-
156151
await page.waitForSelector(selectors.CONTROL_PANEL_TABLE_SELECTOR)
157152

158-
159153
const primary_level_colors = await page.$$eval(selectors.COLOR_RECT_SELECTOR, primary_level_colors => {
160154
return primary_level_colors.map(primary_level_color => primary_level_color.outerHTML);
161155
});
@@ -209,7 +203,7 @@ describe('Test for the Control Panel - color picker', () => {
209203

210204

211205
expect(second_level_colors[1]).toEqual(second_level_colors[2])
212-
expect(second_level_colors[2]).toEqual(second_level_colors[3])
206+
expect(second_level_colors[2]).toEqual(second_level_colors[3])
213207

214208

215209
const buttons = await page.$$(selectors.COLOR_CONTROL_BUTTONS_SELECTOR)
@@ -235,7 +229,7 @@ describe('Test for the Control Panel - color picker', () => {
235229
})
236230

237231

238-
it('Pick a color for the sublevel I netowrk', async () => {
232+
it('Pick a color for the sublevel I netowrk', async () => {
239233

240234
console.log('Selecting a color for the I network')
241235

@@ -278,9 +272,7 @@ describe('Test for the Control Panel - color picker', () => {
278272
}, list_bounds);
279273

280274
await page.waitForTimeout(PAGE_WAIT)
281-
282275
await page.mouse.click(Math.round(rect.right) - 40, Math.round(rect.bottom) + 40)
283-
284276
await page.waitForTimeout(PAGE_WAIT * 2)
285277

286278
const rows_after_colouring_I = await page.$$(selectors.CONTROL_PANEL_NETWORK_ROWS_SELECTOR)
@@ -302,22 +294,20 @@ describe('Test for the Control Panel - color picker', () => {
302294

303295
it('Filter results from the Control panel', async () => {
304296

305-
306297
await page.waitForTimeout(PAGE_WAIT)
307298
console.log('Filtering results')
308299

309-
await expect(page).toFill('input[class="MuiInputBase-input MuiOutlinedInput-input"]', 'E')
300+
await expect(page).toFill(selectors.CONTROL_PANEL_FILTER_SELECTOR, 'E')
310301

311302
await page.waitForTimeout(PAGE_WAIT)
303+
await page.waitForSelector(selectors.NETWORKS_IN_CONTROL_PANEL_SELECTOR)
312304

313-
await page.waitForSelector('ul[role="tree"]')
314-
const network_items = (await page.$$('li[role="treeitem"]')).length;
305+
const network_items = (await page.$$(selectors.NETWORK_ITEMS_CONTROL_PANEL_SELECTOR)).length;
315306
await expect(network_items).toEqual(3)
316307

317308
console.log('Results filtered successfully')
318309

319310
})
320311

321312

322-
323313
});

tests/frontend/e2e/tests/selectors.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,4 +76,5 @@ export const NETWORK_ITEMS_CONTROL_PANEL_SELECTOR = 'li[role="treeitem"]'
7676
export const COLOR_CONTROL_BUTTONS_SELECTOR = 'button[class="MuiButtonBase-root MuiIconButton-root"]'
7777
export const COLOR_RECT_SELECTOR = 'rect[rx="5"]'
7878
export const CONTROL_PANEL_NETWORK_ROWS_SELECTOR = 'div[class = "MuiTypography-root MuiTreeItem-label MuiTypography-body1"]'
79-
export const CONTROL_PANEL_TABLE_SELECTOR = 'div[class="MuiGrid-root MuiGrid-container MuiGrid-justify-content-xs-space-between"]'
79+
export const CONTROL_PANEL_TABLE_SELECTOR = 'div[class="MuiGrid-root MuiGrid-container MuiGrid-justify-content-xs-space-between"]'
80+
export const CONTROL_PANEL_FILTER_SELECTOR = 'input[class="MuiInputBase-input MuiOutlinedInput-input"]'

0 commit comments

Comments
 (0)