Skip to content

Commit ee35db4

Browse files
committed
Use StringBuilder not StringJoiner for a small efficiency bonus..
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
1 parent 184ee6c commit ee35db4

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

src/main/java/cpw/mods/niofs/union/UnionPath.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,12 @@ public class UnionPath implements Path {
3232
this.absolute = false;
3333
this.pathParts = new String[0];
3434
} else {
35-
StringJoiner joiner = new StringJoiner(UnionFileSystem.SEP_STRING);
36-
for (String element : pathParts) {
35+
StringBuilder joiner = new StringBuilder();
36+
for (int i = 0; i < pathParts.length; i++) {
37+
final String element = pathParts[i];
3738
if (!element.isEmpty()) {
38-
joiner.add(element);
39+
joiner.append(element);
40+
if (i<pathParts.length-1) joiner.append(UnionFileSystem.SEP_STRING);
3941
}
4042
}
4143
final var longstring = joiner.toString();

0 commit comments

Comments
 (0)