Skip to content

Commit d3adab0

Browse files
committed
Aliases tests don't work for SQLite as each connection is always a new file
1 parent 89c9582 commit d3adab0

2 files changed

Lines changed: 19 additions & 16 deletions

File tree

test/resources/common.resource

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,8 @@ Connect To DB
2929
IF $alias is not None Set To Dictionary ${DB_KWARGS} alias=${alias}
3030
IF "${DB_MODULE_MODE}" == "custom"
3131
IF "${DB_MODULE}" == "sqlite3"
32-
${DB_Filename}= Set Variable ${DBName}
33-
IF $alias is not None
34-
${DB_Filename}= Set Variable ${DB_Filename}_${alias}
35-
END
36-
Remove File ${DB_Filename}.db
37-
Connect To Database Using Custom Params sqlite3 database="./${DB_Filename}.db", isolation_level=None
32+
Remove File ${DBName}.db
33+
Connect To Database Using Custom Params sqlite3 database="./${DBName}.db", isolation_level=None
3834
... &{DB_KWARGS}
3935
ELSE
4036
${Connection String}= Build Connection String
@@ -74,12 +70,12 @@ Create Person Table And Insert Data
7470
Insert Data In Person Table Using SQL Script
7571

7672
Insert Data In Person Table Using SQL Script
77-
${output}= Execute SQL Script ${CURDIR}/insert_data_in_person_table.sql
78-
RETURN ${output}
79-
80-
Insert Data In Person Table Using SQL Script Aliased
81-
[Arguments] ${alias}
82-
${output}= Execute SQL Script ${CURDIR}/insert_data_in_person_table.sql alias=${alias}
73+
[Arguments] ${alias}=${None}
74+
IF $alias is None
75+
${output}= Execute SQL Script ${CURDIR}/insert_data_in_person_table.sql
76+
ELSE
77+
${output}= Execute SQL Script ${CURDIR}/insert_data_in_person_table.sql alias=${alias}
78+
END
8379
RETURN ${output}
8480

8581
Create Foobar Table

test/tests/common_tests/aliased_connection.robot

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
*** Settings ***
22
Resource ../../resources/common.resource
3+
Suite Setup Skip If "${DB_MODULE}" == "sqlite3"
4+
... Aliases tests don't work for SQLite as each connection is always a new file
35

4-
Suite Setup Connect, Create Some Data And Disconnect
5-
Suite Teardown Connect, Clean Up Data And Disconnect
6-
Test Teardown Disconnect From All Databases
6+
Test Setup Connect, Create Some Data And Disconnect
7+
Test Teardown Connect, Clean Up Data And Disconnect
78

89

910
*** Test Cases ***
@@ -39,8 +40,9 @@ Switch Not Existing Alias
3940
... Switch Database second
4041

4142
Execute SQL Script - Insert Data In Person table
43+
[Setup] Connect, Create Some Data And Disconnect Run SQL script=${False}
4244
Connect To DB alias=aliased_conn
43-
${output} Insert Data In Person Table Using SQL Script Aliased alias=aliased_conn
45+
${output} Insert Data In Person Table Using SQL Script alias=aliased_conn
4446
Should Be Equal As Strings ${output} None
4547

4648
Check If Exists In DB - Franz Allan
@@ -115,11 +117,16 @@ Verify Delete All Rows From Table
115117

116118
*** Keywords ***
117119
Connect, Create Some Data And Disconnect
120+
[Arguments] ${Run SQL script}=${True}
118121
Connect To DB
119122
Create Person Table
123+
IF $Run_SQL_script
124+
Insert Data In Person Table Using SQL Script
125+
END
120126
Disconnect From Database
121127

122128
Connect, Clean Up Data And Disconnect
129+
Disconnect From All Databases
123130
Connect To DB
124131
Drop Tables Person And Foobar
125132
Disconnect From Database

0 commit comments

Comments
 (0)