Skip to content

Commit 18ba67e

Browse files
committed
add condition to verify map-geometry is legit
1 parent 9f39586 commit 18ba67e

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/map-feature.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,8 @@ export class MapFeature extends HTMLElement {
280280
if (!this.querySelector('map-geometry')) return;
281281
let fallbackCS = this._getFallbackCS();
282282
let content = parentLayer.src ? parentLayer.shadowRoot : parentLayer;
283-
this._geometry = layerToAddTo.createGeometry(this, fallbackCS); // side effect: extends `this` with this._groupEl, points to svg g element that renders to map SD
283+
this._geometry = layerToAddTo.createGeometry(this, fallbackCS); // side effect: extends `this` with this._groupEl if successful, points to svg g element that renders to map SD
284+
if (!this._geometry) return;
284285
layerToAddTo.addLayer(this._geometry);
285286
this._setUpEvents();
286287
}

src/mapml/layers/FeatureLayer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ export var FeatureLayer = L.FeatureGroup.extend({
427427
options.zoomBounds = feature.extent.zoom;
428428
}
429429
let geometry = this._geometryToLayer(feature, options, cs, +zoom, title);
430-
if (geometry) {
430+
if (geometry && Object.keys(geometry._layers).length !== 0) {
431431
// if the layer is being used as a query handler output, it will have
432432
// a color option set. Otherwise, copy classes from the feature
433433
if (!geometry.options.color && feature.hasAttribute('class')) {

0 commit comments

Comments
 (0)