Enforce no semicolon and fix lint errors

vramana · vramana · commit cd1f1e30aed1 · 2015-09-27T08:19:50.000+05:30
- Added babelrc
- Split npm test into npm run mocha and npm run lint
diff --git a/.babelrc b/.babelrc
@@ -0,0 +1,3 @@
+{
+  "stage": 0
+}
diff --git a/.eslintrc b/.eslintrc
@@ -1,7 +1,9 @@
 {
   "parser": "babel-eslint",
   "env": {
-    "es6": true
+    "es6": true,
+    "mocha": true,
+    "node": true
   },
   "ecmaFeatures": {
     "blockBindings": true,
@@ -14,6 +16,9 @@
     "max-len": 0,
     "semi": 0,
     "quotes": 0,
+    "semi": [2, "never"],
+    "no-unused-vars": 2,
+    "no-undef": 2,
     "no-console": 0,
     "no-trailing-spaces": 0,
     "curly": 0,
diff --git a/.gitignore b/.gitignore
@@ -6,3 +6,4 @@ lib
 /middleware
 /no-dom.js
 /tests.js
+npm-debug.log
diff --git a/package.json b/package.json
@@ -4,9 +4,11 @@
   "description": "a chainable testing library for React",
   "main": "legit-tests.js",
   "scripts": {
-    "compile": "babel src --stage 0 --out-dir .;",
-    "prepublish": "babel src --stage 0 --out-dir .;",
-    "test": "mocha --opts ./mocha.opts; eslint ./src/ ./tests/ --ext .jsx,.js --global require,exports:true"
+    "compile": "babel src --out-dir .",
+    "prepublish": "babel src  --out-dir .",
+    "lint": "eslint ./src/ ./tests/ --ext .jsx,.js --global require,exports:true",
+    "mocha": "mocha --opts ./mocha.opts",
+    "test": "npm run mocha; npm run lint"
   },
   "repository": {
     "type": "git",
diff --git a/src/dom.js b/src/dom.js
@@ -8,12 +8,12 @@ function propagateToGlobal (window) {
   }
 }
 
-var jsdom = require('jsdom');
+var jsdom = require('jsdom')
 
-var doc = jsdom.jsdom('<!doctype html><html><body></body></html>');
-var win = doc.defaultView;
+var doc = jsdom.jsdom('<!doctype html><html><body></body></html>')
+var win = doc.defaultView
 
-global.document = doc;
-global.window = win;
+global.document = doc
+global.window = win
 
-propagateToGlobal(win);
+propagateToGlobal(win)
diff --git a/src/legit-tests.js b/src/legit-tests.js
@@ -1,5 +1,2 @@
-/* globals global */
 import './dom'
-import Test from './tests'
-
-export default Test
+export default from './tests'
diff --git a/src/middleware/simulate.js b/src/middleware/simulate.js
@@ -2,10 +2,10 @@ import React from 'react'
 let { TestUtils } = React.addons
 
 export default function simulate(data){
-  let element = data.element ? this.helpers.elements[data.element] : this;
-  element = Array.isArray(element) ? element[0] : element;
+  let element = data.element ? this.helpers.elements[data.element] : this
+  element = Array.isArray(element) ? element[0] : element
   TestUtils.Simulate[data.method].call(this,
     element,
     data.options || null
-  );
+  )
 }
diff --git a/src/no-dom.js b/src/no-dom.js
@@ -1,3 +1 @@
-import Test from './tests'
-
-export default Test
+export default from './tests'
diff --git a/src/tests.js b/src/tests.js
@@ -25,16 +25,16 @@ function Test(component, config) {
     helpers: {},
     params() {
       const length = Object.keys(this.helpers).length
-      if(this.helpers.elements && length === 1) {
+      if (this.helpers.elements && length === 1) {
         return Object.assign({}, this, this.helpers.elements)
       }
       return this
     },
     element(select, callback) {
-      if(!this.helpers) return
+      if (!this.helpers) return
 
       let element
-      if(typeof select === 'string') {
+      if (typeof select === 'string') {
         element = this.helpers.elements[select]
         callback.call(this, element)
         return this
@@ -55,7 +55,7 @@ function Test(component, config) {
           return this
         }
       })
-      return this;
+      return this
     },
     test(callback) {
       const param = this.params()
@@ -67,7 +67,7 @@ function Test(component, config) {
       callback.call(null, componentString)
       return this
     }
-  };
+  }
 
   return testComponent.mixin({
     find: Find,
diff --git a/tests/components/component.jsx b/tests/components/component.jsx
@@ -1,5 +1,5 @@
-import React, { Component, PropTypes } from 'react'
-import TinyComponent from './tiny-component';
+import React, { Component } from 'react'
+import TinyComponent from './tiny-component'
 
 export default class TestComponent extends Component {
   constructor(props, context){
diff --git a/tests/components/tiny-component.jsx b/tests/components/tiny-component.jsx
@@ -1,4 +1,4 @@
-import React, { Component } from 'react';
+import React, { Component } from 'react'
 
 export default class TinyComponent extends Component {
   render() {
diff --git a/tests/element.jsx b/tests/element.jsx
@@ -1,10 +1,9 @@
 import React from 'react'
 
 import Test from '../src/legit-tests'
-import { Find } from '../src/middleware'
-import { expect } from 'chai';
+import { expect } from 'chai'
 
-import { TestComponent, TinyComponent } from './components'
+import { TestComponent } from './components'
 
 describe('.element', () => {
 
@@ -14,7 +13,7 @@ describe('.element', () => {
     .element(box => {
       expect(box.props.children).to.be.equal('found me!')
     })
-  });
+  })
 
   it('should find box, not div', () => {
     Test(<TestComponent/>)
@@ -23,5 +22,8 @@ describe('.element', () => {
     .element('box', box => {
       expect(box.props.children).to.be.equal('found me!')
     })
-  });
-});
+    .element('div', div => {
+      expect(div.length).to.be.equal(2)
+    })
+  })
+})
diff --git a/tests/find.jsx b/tests/find.jsx
@@ -2,7 +2,7 @@ import React from 'react'
 
 import Test from '../src/legit-tests'
 import { Find } from '../src/middleware'
-import { expect } from 'chai';
+import { expect } from 'chai'
 
 import { TestComponent, TinyComponent } from './components'
 
@@ -14,7 +14,7 @@ describe('Find middleware', () => {
     .test(function() {
       expect(this.helpers.elements.div[0].props.children).to.be.equal(undefined)
     })
-  });
+  })
 
   it('should find p tag with class', () => {
     Test(<TestComponent/>)
@@ -29,13 +29,13 @@ describe('Find middleware', () => {
       expect(box.props.children).to.be.equal('found me!')
     })
 
-  });
+  })
 
   it('should find a rendered component', () => {
     Test(<TestComponent/>)
     .find(TinyComponent)
     .test(({tinycomponent}) => {
-      expect(tinycomponent.props.test).to.be.equal('true');
-    });
-  });
-});
+      expect(tinycomponent.props.test).to.be.equal('true')
+    })
+  })
+})
diff --git a/tests/no-dom.jsx b/tests/no-dom.jsx
@@ -1,8 +1,7 @@
 import React from 'react'
 
 import Test from '../src/no-dom'
-import { Find } from '../src/middleware'
-import { expect } from 'chai';
+import { expect } from 'chai'
 
 import { TestComponent } from './components'
 
@@ -13,5 +12,5 @@ describe('no dom', () => {
     .test(function() {
       expect(this.instance).to.be.ok
     })
-  });
-});
+  })
+})
diff --git a/tests/renderToString.jsx b/tests/renderToString.jsx
@@ -1,8 +1,7 @@
 import React from 'react'
 
 import Test from '../src/legit-tests'
-import { Find } from '../src/middleware'
-import { expect } from 'chai';
+import { expect } from 'chai'
 
 import { TestComponent } from './components'
 
@@ -16,5 +15,5 @@ describe('Render To String', () => {
     .test(({instance}) => {
       expect(instance).to.be.ok
     })
-  });
-});
+  })
+})
diff --git a/tests/setState.jsx b/tests/setState.jsx
@@ -1,7 +1,7 @@
 import React from 'react'
 
 import Test from '../src/legit-tests'
-import { expect } from 'chai';
+import { expect } from 'chai'
 import { SetState, Find } from '../src/middleware'
 
 import { TestComponent } from './components'
@@ -19,6 +19,6 @@ describe('setState middleware', () => {
     .test(function() {
       expect(this.instance.state.test).to.be.equal('changed!')
     })
-  });
+  })
 
-});
+})
diff --git a/tests/shallowRender.jsx b/tests/shallowRender.jsx
@@ -1,8 +1,7 @@
 import React from 'react'
 
 import Test from '../src/legit-tests'
-import { Find } from '../src/middleware'
-import { expect } from 'chai';
+import { expect } from 'chai'
 
 import { TestComponent } from './components'
 
@@ -13,6 +12,6 @@ describe('Shallow Render', () => {
     .test(function() {
       expect(this.instance).to.be.ok
     })
-  });
+  })
 
-});
+})
diff --git a/tests/simulate.jsx b/tests/simulate.jsx
@@ -2,35 +2,35 @@ import React from 'react'
 
 import Test from '../src/legit-tests'
 import { Find, Simulate } from '../src/middleware'
-import { expect } from 'chai';
-import sinon from 'sinon';
+import { expect } from 'chai'
+import sinon from 'sinon'
 
 import { TestComponent } from './components'
 
 describe('simulate middleware', () => {
 
   it('should click a single element', () => {
-    let spy = sinon.spy();
+    let spy = sinon.spy()
 
     Test(<TestComponent onClick={spy}/>)
     .use(Find, 'div')
     .use(Simulate, {method: 'click', element: 'div'})
     .test(() => {
-      expect(spy.called).to.be.true;
+      expect(spy.called).to.be.true
     })
 
-  });
+  })
 
   it('should click the first element in an array', () => {
-    let spy = sinon.spy();
+    let spy = sinon.spy()
 
     Test(<TestComponent onClick={spy}/>)
     .find('button')
     .simulate({method: 'click', element: 'button'})
     .test(function() {
-      expect(spy.called).to.be.true;
+      expect(spy.called).to.be.true
     })
 
-  });
+  })
 
-});
+})
