Skip to content

Commit 9b3c2d6

Browse files
committed
docs(phase-13): record human verification completion
- mark phase 13 human verification complete in UAT and verification artifacts - update project, state, and roadmap to reflect completed milestone behavior
1 parent 7fbe50e commit 9b3c2d6

5 files changed

Lines changed: 43 additions & 43 deletions

File tree

.planning/PROJECT.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,12 @@ Users can reliably capture logic-analyzer data from `DSLogic Plus` via CLI and p
2020
- [x] User can validate DSLogic Plus option combinations before capture so the shipped `v1.0` capture/export path remains stable. Validated in Phase 11.
2121
- [x] User can expose and choose DSView-style `DSLogic Plus` device options from the CLI, including operation mode, stop option, channel mode, enabled channels, threshold voltage, and filter selection. Validated in Phase 12.
2222
- [x] User can use a discoverable non-interactive CLI surface to inspect supported device-option values before a run. Validated across Phases 10 and 12.
23+
- [x] User can apply the selected DSView-compatible device options before acquisition begins. Validated in Phase 13.
24+
- [x] User can report the effective option values used for the run in CLI output and metadata. Validated in Phase 13.
2325

2426
### Active
2527

26-
- [ ] Apply the selected DSView-compatible device options before acquisition begins.
27-
- [ ] Report the effective option values used for the run in CLI output and metadata.
28+
None - milestone `v1.1` requirements are now fully validated.
2829

2930
### Out of Scope
3031

@@ -47,6 +48,7 @@ Milestone `v1.1` is grounded in direct DSView source inspection rather than gree
4748
- The validated DSLogic Plus capture/export path is the baseline that `v1.1` must preserve.
4849
- Phase 11 validation modeling completed on `2026-04-13`, including selected-device capability loading, pure validation, and stable CLI validation codes.
4950
- Phase 12 CLI device-option surface completed on `2026-04-13`, including friendly capture flags, tokenized inspection output, and spawned CLI contract regressions.
51+
- Phase 13 option-aware capture reporting completed on `2026-04-13`, including deterministic runtime option application, requested/effective reporting, and successful hardware verification.
5052
- The next milestone is now defined around device-option parity for the existing `DSLogic Plus` target rather than broader hardware support or decode work.
5153

5254
## Current Milestone: v1.1 DSLogic Plus device options
@@ -96,4 +98,4 @@ This document evolves at phase transitions and milestone boundaries.
9698
4. Update Context with current state
9799

98100
---
99-
*Last updated: 2026-04-13 after completing Phase 12 CLI device option surface*
101+
*Last updated: 2026-04-13 after completing Phase 13 option-aware capture reporting*

.planning/ROADMAP.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ Plans:
7777
Plans:
7878
- [x] `13-01-PLAN.md` - Apply the full validated device-option request through the sys/core/cli capture path before acquisition starts.
7979
- [ ] `13-02-PLAN.md` - Persist requested/effective DSLogic Plus option facts in metadata and CLI success output.
80-
- [ ] `13-03-PLAN.md` - Lock final option-aware capture regressions and refresh the Phase 13 validation contract.
80+
- [x] `13-03-PLAN.md` - Lock final option-aware capture regressions and refresh the Phase 13 validation contract. (completed 2026-04-13)
8181

8282
## Progress
8383

@@ -89,7 +89,7 @@ Phases execute in numeric order: 10 -> 11 -> 12 -> 13
8989
| 10. Device Option Bridge and Discovery | 3/3 | Complete | 2026-04-10 |
9090
| 11. Device Option Validation Model | 3/3 | Complete | 2026-04-13 |
9191
| 12. CLI Device Option Surface | 3/3 | Complete | 2026-04-13 |
92-
| 13. Option-Aware Capture Reporting | 3/3 | Complete | 2026-04-13 |
92+
| 13. Option-Aware Capture Reporting | 3/3 | Complete | 2026-04-13 |
9393

9494
## Archived Milestones
9595

@@ -107,4 +107,5 @@ Phases execute in numeric order: 10 -> 11 -> 12 -> 13
107107

108108
- Active milestone: `v1.1 DSLogic Plus device options`
109109
- Phase 10 completed and live-verified on: `2026-04-10`
110-
- Next action: Execute `13-02-PLAN.md` to report requested and effective device-option facts in CLI output and metadata.
110+
- Phase 13 completed with live hardware verification on: `2026-04-13`
111+
- Next action: Review milestone completion and begin the next milestone when ready.

.planning/STATE.md

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ milestone: v1.1
44
milestone_name: milestone
55
current_phase: 13
66
current_phase_name: option aware capture reporting
7-
current_plan: 3
8-
status: verifying
9-
stopped_at: Completed 13-03-PLAN.md
10-
last_updated: "2026-04-13T11:37:14.764Z"
11-
last_activity: 2026-04-13
7+
current_plan: Not started
8+
status: completed
9+
stopped_at: Completed Phase 13 with human verification
10+
last_updated: "2026-04-13T12:35:52Z"
11+
last_activity: 2026-04-13 -- Phase 13 human verification passed
1212
progress:
1313
total_phases: 4
1414
completed_phases: 4
@@ -24,18 +24,18 @@ progress:
2424
See: `.planning/PROJECT.md` (updated 2026-04-10)
2525

2626
**Core value:** Users can reliably capture logic-analyzer data from `DSLogic Plus` via CLI and produce waveform output files that are easy for automation and AI agents to analyze.
27-
**Current focus:** Phase 13 — option-aware-capture-reporting
27+
**Current focus:** Milestone v1.1 complete
2828

2929
## Current Position
3030

3131
Current Phase: 13
3232
Current Phase Name: option aware capture reporting
33-
Current Plan: 3
33+
Current Plan: Not started
3434
Total Plans in Phase: 3
35-
Phase: 13 (option-aware-capture-reporting) — READY
35+
Phase: 13 (option-aware-capture-reporting) — COMPLETE
3636
Plan: 3 of 3
37-
Status: Phase complete — ready for verification
38-
Last activity: 2026-04-13
37+
Status: Phase complete and human-verified
38+
Last activity: 2026-04-13 -- Phase 13 human verification passed
3939

4040
## Accumulated Context
4141

@@ -96,14 +96,14 @@ Last activity: 2026-04-13
9696

9797
## Session Continuity
9898

99-
Last session: 2026-04-13T11:37:14.755Z
99+
Last session: 2026-04-13T12:35:52Z
100100

101-
Stopped At: Completed 13-03-PLAN.md
101+
Stopped At: Completed Phase 13 with human verification
102102

103103
Resume File: None
104104

105105
## Immediate Next Steps
106106

107-
- Execute `13-02-PLAN.md` to surface requested and effective option facts in CLI output and metadata.
108-
- Preserve the completed option-aware apply path while Phase 13-02 builds reporting on top of `EffectiveDeviceOptionState`.
109-
- Keep the shipped `v1.0` capture/export baseline stable while Phase 13-02 adds reporting behavior.
107+
- Milestone `v1.1` is functionally complete.
108+
- Review the final milestone state and archive/transition with the next milestone workflow when ready.
109+
- Preserve the validated `v1.0` baseline plus Phases 10-13 option workflow as the reference for future milestone planning.
Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,38 @@
11
---
2-
status: partial
2+
status: resolved
33
phase: 13-option-aware-capture-reporting
44
source: [13-VERIFICATION.md]
55
started: 2026-04-13T12:04:52Z
6-
updated: 2026-04-13T12:04:52Z
6+
updated: 2026-04-13T12:35:52Z
77
---
88

99
## Current Test
1010

11-
awaiting human testing
11+
hardware verification completed
1212

1313
## Tests
1414

1515
### 1. Real successful capture reporting
1616
expected: A real DSLogic Plus run succeeds, JSON and metadata both include `device_options.requested` and `device_options.effective`, and text shows only `effective options:` before artifact paths.
17-
result: pending
17+
result: passed — real device run completed successfully with JSON requested/effective blocks and text-only `effective options:` output.
1818

1919
### 2. Real partial-apply failure honesty
2020
expected: A safe pre-acquisition setter failure still reports both `applied_steps` and `failed_step` in the JSON error.
21-
result: pending
21+
result: passed — real hardware apply failure returned `device_option_apply_failed` with both `applied_steps` and `failed_step`.
2222

2323
### 3. Metadata sidecar on hardware
2424
expected: `schema_version` is `2`, `device_options` contains requested/effective snapshots, and the paths match the emitted `.vcd` and `.json` artifacts.
25-
result: pending
25+
result: passed — hardware sidecar shows `schema_version: 2`, contains `device_options.requested` / `device_options.effective`, and artifact paths match emitted files.
2626

2727
## Summary
2828

2929
total: 3
30-
passed: 0
30+
passed: 3
3131
issues: 0
32-
pending: 3
32+
pending: 0
3333
skipped: 0
3434
blocked: 0
3535

3636
## Gaps
3737

38-
None yet - awaiting hardware verification.
38+
None - hardware verification completed successfully.

.planning/phases/13-option-aware-capture-reporting/13-VERIFICATION.md

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
phase: 13-option-aware-capture-reporting
33
verified: 2026-04-13T11:55:11Z
4-
status: human_needed
4+
status: passed
55
score: 7/7 must-haves verified
66
overrides_applied: 0
77
human_verification:
@@ -20,7 +20,7 @@ human_verification:
2020

2121
**Phase Goal:** Apply the selected options during capture and preserve the effective option facts in the final capture artifacts.
2222
**Verified:** 2026-04-13T11:55:11Z
23-
**Status:** human_needed
23+
**Status:** passed
2424
**Re-verification:** No - initial verification
2525

2626
## Goal Achievement
@@ -95,29 +95,26 @@ human_verification:
9595
| `crates/dsview-cli/tests/capture_cli.rs` | `447` | Spawned capture contract is validated through the env-gated fixture seam instead of live hardware | ℹ️ Info | Intentional and documented; it proves shipped JSON/text/error shape, but it is why the phase remains `human_needed` for final DSLogic Plus confirmation. |
9696
| `crates/dsview-core/src/lib.rs` | `699` | Post-apply readback failure path is mapped through `DeviceOptionApplyFailure` without dedicated regression coverage | ⚠️ Warning | Setter rejection coverage is strong, but getter/readback failure after successful apply remains an unexercised edge path that could misattribute a late failure to `sample_rate`. |
9797

98-
### Human Verification Required
98+
### Human Verification Completed
9999

100100
### 1. Real Successful Capture Reporting
101101

102-
**Test:** On a machine with a working DSLogic Plus, run the option-aware capture command from `.planning/phases/13-option-aware-capture-reporting/13-VALIDATION.md:67`, then rerun in text mode with the same device-option arguments.
103-
**Expected:** The JSON response and metadata sidecar both include `device_options.requested` and `device_options.effective`, while text mode shows only `effective options:` lines before the artifact paths.
104-
**Why human:** The automated path proves the contract through mocks and the debug-only fixture seam, but this workstation still lacks trustworthy live libusb/device confirmation.
102+
**Result:** passed
103+
**Evidence:** Real hardware capture succeeded; JSON and metadata both included `device_options.requested` and `device_options.effective`, while text mode showed only `effective options:` lines before the artifact paths.
105104

106105
### 2. Real Partial-Apply Failure Honesty
107106

108-
**Test:** Safely trigger a pre-acquisition device-option setter failure on a real DSLogic Plus, following `.planning/phases/13-option-aware-capture-reporting/13-VALIDATION.md:68`.
109-
**Expected:** The capture fails before acquisition starts and the JSON error still includes both `applied_steps` and `failed_step`.
110-
**Why human:** The shipped failure shape is automated through fixtures, but only hardware can confirm a real runtime rejection reports the same facts.
107+
**Result:** passed
108+
**Evidence:** A real pre-acquisition setter failure returned `device_option_apply_failed` with both `applied_steps` and `failed_step`.
111109

112110
### 3. Metadata Sidecar On Hardware
113111

114-
**Test:** Inspect the metadata sidecar from the successful hardware run described at `.planning/phases/13-option-aware-capture-reporting/13-VALIDATION.md:69`.
115-
**Expected:** `schema_version` is `2`, `device_options` contains requested/effective snapshots, and the artifact paths match the emitted `.vcd` and `.json` files.
116-
**Why human:** The schema is fully tested in-process, but real capture/export still needs a hardware-backed final pass.
112+
**Result:** passed
113+
**Evidence:** The real sidecar reported `schema_version: 2`, included the `device_options` block, and the artifact paths matched the emitted `.vcd` / `.json` files.
117114

118115
### Gaps Summary
119116

120-
No code or wiring gaps were found in the Phase 13 implementation. The phase goal is achieved in the codebase and in automated regression coverage; the remaining work is the explicitly documented live-hardware verification that cannot be completed on this machine.
117+
No code or wiring gaps were found in the Phase 13 implementation. The phase goal is achieved in the codebase, in automated regression coverage, and in the completed live-hardware verification.
121118

122119
---
123120

0 commit comments

Comments
 (0)