You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs(phase-13): record human verification completion
- mark phase 13 human verification complete in UAT and verification artifacts
- update project, state, and roadmap to reflect completed milestone behavior
Copy file name to clipboardExpand all lines: .planning/PROJECT.md
+5-3Lines changed: 5 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -20,11 +20,12 @@ Users can reliably capture logic-analyzer data from `DSLogic Plus` via CLI and p
20
20
-[x] User can validate DSLogic Plus option combinations before capture so the shipped `v1.0` capture/export path remains stable. Validated in Phase 11.
21
21
-[x] User can expose and choose DSView-style `DSLogic Plus` device options from the CLI, including operation mode, stop option, channel mode, enabled channels, threshold voltage, and filter selection. Validated in Phase 12.
22
22
-[x] User can use a discoverable non-interactive CLI surface to inspect supported device-option values before a run. Validated across Phases 10 and 12.
23
+
-[x] User can apply the selected DSView-compatible device options before acquisition begins. Validated in Phase 13.
24
+
-[x] User can report the effective option values used for the run in CLI output and metadata. Validated in Phase 13.
23
25
24
26
### Active
25
27
26
-
-[ ] Apply the selected DSView-compatible device options before acquisition begins.
27
-
-[ ] Report the effective option values used for the run in CLI output and metadata.
28
+
None - milestone `v1.1` requirements are now fully validated.
28
29
29
30
### Out of Scope
30
31
@@ -47,6 +48,7 @@ Milestone `v1.1` is grounded in direct DSView source inspection rather than gree
47
48
- The validated DSLogic Plus capture/export path is the baseline that `v1.1` must preserve.
48
49
- Phase 11 validation modeling completed on `2026-04-13`, including selected-device capability loading, pure validation, and stable CLI validation codes.
49
50
- Phase 12 CLI device-option surface completed on `2026-04-13`, including friendly capture flags, tokenized inspection output, and spawned CLI contract regressions.
51
+
- Phase 13 option-aware capture reporting completed on `2026-04-13`, including deterministic runtime option application, requested/effective reporting, and successful hardware verification.
50
52
- The next milestone is now defined around device-option parity for the existing `DSLogic Plus` target rather than broader hardware support or decode work.
51
53
52
54
## Current Milestone: v1.1 DSLogic Plus device options
@@ -96,4 +98,4 @@ This document evolves at phase transitions and milestone boundaries.
stopped_at: Completed Phase 13 with human verification
10
+
last_updated: "2026-04-13T12:35:52Z"
11
+
last_activity: 2026-04-13 -- Phase 13 human verification passed
12
12
progress:
13
13
total_phases: 4
14
14
completed_phases: 4
@@ -24,18 +24,18 @@ progress:
24
24
See: `.planning/PROJECT.md` (updated 2026-04-10)
25
25
26
26
**Core value:** Users can reliably capture logic-analyzer data from `DSLogic Plus` via CLI and produce waveform output files that are easy for automation and AI agents to analyze.
expected: A real DSLogic Plus run succeeds, JSON and metadata both include `device_options.requested` and `device_options.effective`, and text shows only `effective options:` before artifact paths.
17
-
result: pending
17
+
result: passed — real device run completed successfully with JSON requested/effective blocks and text-only `effective options:` output.
18
18
19
19
### 2. Real partial-apply failure honesty
20
20
expected: A safe pre-acquisition setter failure still reports both `applied_steps` and `failed_step` in the JSON error.
21
-
result: pending
21
+
result: passed — real hardware apply failure returned `device_option_apply_failed` with both `applied_steps` and `failed_step`.
22
22
23
23
### 3. Metadata sidecar on hardware
24
24
expected: `schema_version` is `2`, `device_options` contains requested/effective snapshots, and the paths match the emitted `.vcd` and `.json` artifacts.
25
-
result: pending
25
+
result: passed — hardware sidecar shows `schema_version: 2`, contains `device_options.requested` / `device_options.effective`, and artifact paths match emitted files.
Copy file name to clipboardExpand all lines: .planning/phases/13-option-aware-capture-reporting/13-VERIFICATION.md
+10-13Lines changed: 10 additions & 13 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,7 +1,7 @@
1
1
---
2
2
phase: 13-option-aware-capture-reporting
3
3
verified: 2026-04-13T11:55:11Z
4
-
status: human_needed
4
+
status: passed
5
5
score: 7/7 must-haves verified
6
6
overrides_applied: 0
7
7
human_verification:
@@ -20,7 +20,7 @@ human_verification:
20
20
21
21
**Phase Goal:** Apply the selected options during capture and preserve the effective option facts in the final capture artifacts.
22
22
**Verified:** 2026-04-13T11:55:11Z
23
-
**Status:**human_needed
23
+
**Status:**passed
24
24
**Re-verification:** No - initial verification
25
25
26
26
## Goal Achievement
@@ -95,29 +95,26 @@ human_verification:
95
95
|`crates/dsview-cli/tests/capture_cli.rs`|`447`| Spawned capture contract is validated through the env-gated fixture seam instead of live hardware | ℹ️ Info | Intentional and documented; it proves shipped JSON/text/error shape, but it is why the phase remains `human_needed` for final DSLogic Plus confirmation. |
96
96
|`crates/dsview-core/src/lib.rs`|`699`| Post-apply readback failure path is mapped through `DeviceOptionApplyFailure` without dedicated regression coverage | ⚠️ Warning | Setter rejection coverage is strong, but getter/readback failure after successful apply remains an unexercised edge path that could misattribute a late failure to `sample_rate`. |
97
97
98
-
### Human Verification Required
98
+
### Human Verification Completed
99
99
100
100
### 1. Real Successful Capture Reporting
101
101
102
-
**Test:** On a machine with a working DSLogic Plus, run the option-aware capture command from `.planning/phases/13-option-aware-capture-reporting/13-VALIDATION.md:67`, then rerun in text mode with the same device-option arguments.
103
-
**Expected:** The JSON response and metadata sidecar both include `device_options.requested` and `device_options.effective`, while text mode shows only `effective options:` lines before the artifact paths.
104
-
**Why human:** The automated path proves the contract through mocks and the debug-only fixture seam, but this workstation still lacks trustworthy live libusb/device confirmation.
102
+
**Result:** passed
103
+
**Evidence:** Real hardware capture succeeded; JSON and metadata both included `device_options.requested` and `device_options.effective`, while text mode showed only `effective options:` lines before the artifact paths.
105
104
106
105
### 2. Real Partial-Apply Failure Honesty
107
106
108
-
**Test:** Safely trigger a pre-acquisition device-option setter failure on a real DSLogic Plus, following `.planning/phases/13-option-aware-capture-reporting/13-VALIDATION.md:68`.
109
-
**Expected:** The capture fails before acquisition starts and the JSON error still includes both `applied_steps` and `failed_step`.
110
-
**Why human:** The shipped failure shape is automated through fixtures, but only hardware can confirm a real runtime rejection reports the same facts.
107
+
**Result:** passed
108
+
**Evidence:** A real pre-acquisition setter failure returned `device_option_apply_failed` with both `applied_steps` and `failed_step`.
111
109
112
110
### 3. Metadata Sidecar On Hardware
113
111
114
-
**Test:** Inspect the metadata sidecar from the successful hardware run described at `.planning/phases/13-option-aware-capture-reporting/13-VALIDATION.md:69`.
115
-
**Expected:**`schema_version` is `2`, `device_options` contains requested/effective snapshots, and the artifact paths match the emitted `.vcd` and `.json` files.
116
-
**Why human:** The schema is fully tested in-process, but real capture/export still needs a hardware-backed final pass.
112
+
**Result:** passed
113
+
**Evidence:** The real sidecar reported `schema_version: 2`, included the `device_options` block, and the artifact paths matched the emitted `.vcd` / `.json` files.
117
114
118
115
### Gaps Summary
119
116
120
-
No code or wiring gaps were found in the Phase 13 implementation. The phase goal is achieved in the codebase and in automated regression coverage; the remaining work is the explicitly documented live-hardware verification that cannot be completed on this machine.
117
+
No code or wiring gaps were found in the Phase 13 implementation. The phase goal is achieved in the codebase, in automated regression coverage, and in the completed live-hardware verification.
0 commit comments