Skip to content

Commit 79a3412

Browse files
committed
Update to simplified version of AutoMockedDataAttribute
1 parent 783b084 commit 79a3412

3 files changed

Lines changed: 45 additions & 39 deletions

File tree

BencodeNET.Tests/AutoMockedDataAttribute.cs

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,25 +5,31 @@
55

66
namespace BencodeNET.Tests
77
{
8-
public class AutoMockedDataAttribute : AutoDataAttribute
8+
public class AutoMockedDataAttribute : CompositeDataAttribute
99
{
1010
public AutoMockedDataAttribute()
11-
: base(() => new Fixture().Customize(new AutoNSubstituteCustomization {ConfigureMembers = true}))
11+
: this(new BaseAutoMockedDataAttribute())
1212
{ }
13-
}
1413

15-
public class InlineAutoMockedDataAttribute : CompositeDataAttribute
16-
{
17-
public InlineAutoMockedDataAttribute()
18-
: this(new AutoMockedDataAttribute())
14+
public AutoMockedDataAttribute(params object[] values)
15+
: this(new BaseAutoMockedDataAttribute(), values)
1916
{ }
2017

21-
public InlineAutoMockedDataAttribute(params object[] values)
22-
: this(new AutoMockedDataAttribute(), values)
18+
private AutoMockedDataAttribute(BaseAutoMockedDataAttribute baseAutoDataAttribute, params object[] values)
19+
: base(new InlineDataAttribute(values), baseAutoDataAttribute)
2320
{ }
2421

25-
public InlineAutoMockedDataAttribute(AutoMockedDataAttribute autoDataAttributeAttribute, params object[] values)
26-
: base(new InlineDataAttribute(values), autoDataAttributeAttribute)
27-
{ }
22+
private class BaseAutoMockedDataAttribute : AutoDataAttribute
23+
{
24+
public BaseAutoMockedDataAttribute()
25+
: base(Configure)
26+
{
27+
}
28+
29+
private static IFixture Configure()
30+
{
31+
return new Fixture().Customize(new AutoNSubstituteCustomization { ConfigureMembers = true });
32+
}
33+
}
2834
}
2935
}

BencodeNET.Tests/Torrents/TorrentParserTests.cs

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,10 @@ public void CreationDate_InvalidValue_ReturnsEpoch()
130130
}
131131

132132
[Theory]
133-
[InlineAutoMockedData("utf8")]
134-
[InlineAutoMockedData("UTF8")]
135-
[InlineAutoMockedData("utf-8")]
136-
[InlineAutoMockedData("UTF-8")]
133+
[AutoMockedData("utf8")]
134+
[AutoMockedData("UTF8")]
135+
[AutoMockedData("utf-8")]
136+
[AutoMockedData("UTF-8")]
137137
public void Encoding_UTF8_CanBeParsed(string encoding)
138138
{
139139
// Arrange
@@ -149,8 +149,8 @@ public void Encoding_UTF8_CanBeParsed(string encoding)
149149
}
150150

151151
[Theory]
152-
[InlineAutoMockedData("ascii")]
153-
[InlineAutoMockedData("ASCII")]
152+
[AutoMockedData("ascii")]
153+
[AutoMockedData("ASCII")]
154154
public void Encoding_ASCII_CanBeParsed(string encoding)
155155
{
156156
// Arrange
@@ -166,10 +166,10 @@ public void Encoding_ASCII_CanBeParsed(string encoding)
166166
}
167167

168168
[Theory]
169-
[InlineAutoMockedData("")]
170-
[InlineAutoMockedData("asdf")]
171-
[InlineAutoMockedData("1")]
172-
[InlineAutoMockedData("UTF 8")]
169+
[AutoMockedData("")]
170+
[AutoMockedData("asdf")]
171+
[AutoMockedData("1")]
172+
[AutoMockedData("UTF 8")]
173173
public void Encoding_InvalidValidAsNull(string encoding)
174174
{
175175
// Arrange
@@ -220,11 +220,11 @@ public void Info_Pieces_IsParsed([RepeatCount(20)] byte[] pieces)
220220
}
221221

222222
[Theory]
223-
[InlineAutoMockedData(-1, false)]
224-
[InlineAutoMockedData(0, false)]
225-
[InlineAutoMockedData(1, true)]
226-
[InlineAutoMockedData(42, false)]
227-
[InlineAutoMockedData(12345, false)]
223+
[AutoMockedData(-1, false)]
224+
[AutoMockedData(0, false)]
225+
[AutoMockedData(1, true)]
226+
[AutoMockedData(42, false)]
227+
[AutoMockedData(12345, false)]
228228
public void Info_Private_ShouldBeTrueOnlyIfValueIsOne(int value, bool expectedResult)
229229
{
230230
// Arrange

BencodeNET.Tests/Torrents/TorrentTests.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,9 @@ public void PiecesAsHexString_Set_NullThrowsArgumentException()
189189
}
190190

191191
[Theory]
192-
[InlineAutoMockedData("qwer")]
193-
[InlineAutoMockedData("123456789012345678901234567890123456789")]
194-
[InlineAutoMockedData("12345678901234567890123456789012345678901")]
192+
[AutoMockedData("qwer")]
193+
[AutoMockedData("123456789012345678901234567890123456789")]
194+
[AutoMockedData("12345678901234567890123456789012345678901")]
195195
public void PiecesAsHexString_Set_LengthNotMultipleOf40ShouldThrowArgumentException(string value)
196196
{
197197
var torrent = new Torrent();
@@ -200,15 +200,15 @@ public void PiecesAsHexString_Set_LengthNotMultipleOf40ShouldThrowArgumentExcept
200200
}
201201

202202
[Theory]
203-
[InlineAutoMockedData("a")]
204-
[InlineAutoMockedData("b")]
205-
[InlineAutoMockedData("c")]
206-
[InlineAutoMockedData("G")]
207-
[InlineAutoMockedData("H")]
208-
[InlineAutoMockedData("T")]
209-
[InlineAutoMockedData(".")]
210-
[InlineAutoMockedData("*")]
211-
[InlineAutoMockedData("[")]
203+
[AutoMockedData("a")]
204+
[AutoMockedData("b")]
205+
[AutoMockedData("c")]
206+
[AutoMockedData("G")]
207+
[AutoMockedData("H")]
208+
[AutoMockedData("T")]
209+
[AutoMockedData(".")]
210+
[AutoMockedData("*")]
211+
[AutoMockedData("[")]
212212
public void PiecesAsHexString_Set_ValueWithNonUppercaseHexCharacterShouldThrowArgumentException(string value)
213213
{
214214
var torrent = new Torrent();

0 commit comments

Comments
 (0)