Fix #265

Author: Keyang

.gitignore

@@ -16,4 +16,5 @@ graph.png
 .vscode
 coverage/
 .nyc_output
-.coveralls.yml
+.coveralls.yml
+.ts-node

package.json

@@ -294,7 +294,7 @@
   "scripts": {
     "dev": "tsc -w",
     "build": "rm -Rf ./v2 && tsc",
-    "test": "TS_NODE_CACHE=false mocha -r ts-node/register src/**/*.test.ts ./test/*.ts -R spec",
+    "test": "rm -Rf .ts-node && TS_NODE_CACHE_DIRECTORY=.ts-node mocha -r ts-node/register src/**/*.test.ts ./test/*.ts -R spec",
     "travis": "nyc --reporter lcov mocha -r ts-node/register src/**/*.test.ts ./test/*.ts -R spec",
     "test:debug": "mocha debug -r ts-node/register src/**/*.test.ts ./test/*.ts -R spec",
     "test-all": "mocha  ./test -R spec && CSV_WORKER=3 mocha ./test -R spec ",

src/rowSplit.test.ts

@@ -106,5 +106,25 @@ describe("RowSplit.parse function", function () {
     assert.equal(res.closed, true);
     assert.equal(res.cells[2], 'csvtojson,a"\nwesome');
   });
+  it ("should allow blank quotes",()=>{
+    const data="a|^^|^b^";
+    
+    const rowSplit = new RowSplit(new Converter({
+      delimiter: '|',
+      quote: '^',
+      noheader: true
+    }));
+    const res=rowSplit.parse(data);
+    assert.equal(res.cells[1],"");
+  })
+  it ("should allow blank quotes in quotes",()=>{
+    const data='a,"hello,this,"", test"';
+    
+    const rowSplit = new RowSplit(new Converter({
+      noheader: true
+    }));
+    const res=rowSplit.parse(data);
+    assert.equal(res.cells[1],'hello,this,", test');
+  })
 
 });

src/rowSplit.ts

@@ -63,7 +63,10 @@ export class RowSplit {
       }
       const len = e.length;
       if (!inquote) {
-        if (this.isQuoteOpen(e)) { //quote open
+        if (len === 2 && e ===this.quote+this.quote){
+          row.push("");
+          continue;
+        }else if (this.isQuoteOpen(e)) { //quote open
           e = e.substr(1);
           if (this.isQuoteClose(e)) { //quote close
             e = e.substring(0, e.lastIndexOf(quote));

test/testCSVConverter3.ts

@@ -46,8 +46,8 @@ describe("testCSVConverter3", function () {
       .subscribe(function (json) {
         assert.equal(typeof json.column1, "string");
         assert.equal(json.column5, "hello world");
-        assert.strictEqual(json["name#!"],false);
-        assert.strictEqual(json["column9"],true);
+        assert.strictEqual(json["name#!"], false);
+        assert.strictEqual(json["column9"], true);
       })
       .on('done', function () {
         done()
@@ -194,26 +194,38 @@ describe("testCSVConverter3", function () {
   "1","2","3"
   "fefe,5",6`)
       .then((d) => {
-        assert.equal(d[0].a,'"1"');
-        assert.equal(d[0].b,'"2"');
-        assert.equal(d[1].a,'"fefe');
-        assert.equal(d[1].b,'5"');
+        assert.equal(d[0].a, '"1"');
+        assert.equal(d[0].b, '"2"');
+        assert.equal(d[1].a, '"fefe');
+        assert.equal(d[1].b, '5"');
       })
   })
-  it ("should allow ignoreEmpty with checkColumn",()=>{
+  it("should allow ignoreEmpty with checkColumn", () => {
     return csv({
-      checkColumn:true,
+      checkColumn: true,
       ignoreEmpty: true
     })
-    .fromString(`date,altitude,airtime
+      .fromString(`date,altitude,airtime
     2016-07-08,2000,23
     
     2016-07-09,3000,43`)
-    .then((data)=>{
+      .then((data) => {
 
-    },(err)=>{
-      console.log(err);
-      assert(!err);
+      }, (err) => {
+        console.log(err);
+        assert(!err);
+      })
+  });
+  it("should allow quotes without content", () => {
+    const data = "a|^^|^b^";
+    return csv({
+      delimiter: '|',
+      quote: '^',
+      noheader: true,
     })
+      .fromString(data)
+      .then((jsonObj) => {
+        assert.equal(jsonObj[0].field2, "");
+      });
   })
 });