Fixed bug in ospf interface cost config generation

giovanni-grieco · giovanni-grieco · commit d1e43f9190c9 · 2024-11-05T16:22:33.000+01:00
diff --git a/src/lab-generator/make.js b/src/lab-generator/make.js
@@ -123,7 +123,7 @@ function makeRouterFrr(machine, lab) {
 			//nb: i costi vanno qui alla fine
 			if (machine.routing.ospf.en) {
 				for (let interface of machine.routing.ospf.if) {
-					if (interface.cost != "" && interface.cost) {
+					if (interface && interface !== undefined && interface.cost != "" && interface.cost) {
 						lab.file[machine.name + "/etc/frr/frr.conf"] += "interface eth" + interface.interface + "\n";
 						lab.file[machine.name + "/etc/frr/frr.conf"] += "ospf cost " + interface.cost + "\n";
 					}

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ function makeRouterFrr(machine, lab) {`
`123`	`123`	`//nb: i costi vanno qui alla fine`
`124`	`124`	`if (machine.routing.ospf.en) {`
`125`	`125`	`for (let interface of machine.routing.ospf.if) {`
`126`		`- if (interface.cost != "" && interface.cost) {`
	`126`	`+ if (interface && interface !== undefined && interface.cost != "" && interface.cost) {`
`127`	`127`	`lab.file[machine.name + "/etc/frr/frr.conf"] += "interface eth" + interface.interface + "\n";`
`128`	`128`	`lab.file[machine.name + "/etc/frr/frr.conf"] += "ospf cost " + interface.cost + "\n";`
`129`	`129`	`}`