disambiguate make(String, 0.3, 9)

Author: rfourquet

src/sampling.jl

@@ -457,11 +457,16 @@ make(::Type{X}, p::AbstractFloat, dims::Dims{1}) where {X} = make(SparseVector,
 make(X,         p::AbstractFloat, dims::Dims{2})           = make(SparseMatrixCSC, X, p, dims)
 make(::Type{X}, p::AbstractFloat, dims::Dims{2}) where {X} = make(SparseMatrixCSC, X, p, dims)
 
-make(X,         p::AbstractFloat, dims::Integer...)           = make(X,                               p, Dims(dims))
-make(::Type{X}, p::AbstractFloat, dims::Integer...) where {X} = make(X,                               p, Dims(dims))
-make(           p::AbstractFloat, dims::Dims)                 = make(default_sampling(AbstractArray), p, dims)
-make(           p::AbstractFloat, dims::Integer...)           = make(default_sampling(AbstractArray), p, Dims(dims))
-
+make(X,         p::AbstractFloat, d1::Integer)                        = make(X,                               p, Dims(d1))
+make(X,         p::AbstractFloat, d1::Integer, d2::Integer)           = make(X,                               p, Dims((d1, d2)))
+make(::Type{X}, p::AbstractFloat, d1::Integer) where {X}              = make(X,                               p, Dims(d1))
+make(::Type{X}, p::AbstractFloat, d1::Integer, d2::Integer) where {X} = make(X,                               p, Dims((d1, d2)))
+make(           p::AbstractFloat, dims::Dims)                         = make(default_sampling(AbstractArray), p, dims)
+make(           p::AbstractFloat, d1::Integer)                        = make(default_sampling(AbstractArray), p, Dims(d1))
+make(           p::AbstractFloat, d1::Integer, d2::Integer)           = make(default_sampling(AbstractArray), p, Dims((d1, d2)))
+
+# disambiguate (away from make(String, chars, n::Integer))
+make(::Type{String}, p::AbstractFloat, d1::Integer) = make(String, p, Dims(d1))
 
 Sampler(RNG::Type{<:AbstractRNG}, c::Make3{A}, n::Repetition) where {A<:AbstractSparseArray} =
     SamplerTag{A}((sp = sampler(RNG, c.x, n),

test/runtests.jl

@@ -477,6 +477,7 @@ end
         @test length(s) == 6
     end
     @test rand(make(spString, 0.3, 9)) isa SparseVector{String}
+    @test rand(make(String, 0.9, 2)) isa SparseVector{String} # can be ambiguous with make(String, chars, n)
 end
 
 @testset "rand(make(default))" begin